From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web12.21770.1641983764469799565 for ; Wed, 12 Jan 2022 02:36:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p0ZD6jPQ; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4697FB81E9C for ; Wed, 12 Jan 2022 10:36:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 107D3C36AE9 for ; Wed, 12 Jan 2022 10:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641983761; bh=t2vpGm4BOmieWU4Urm1Kjdq/aYETmK/KWVjQ9ZKWLq0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=p0ZD6jPQxuYF7KBbyuDGOmKQ3vIGU7EXH/wITs6/qA4bJa0RrOXWtHxHflNTQQu55 gELjXYi421HRo4qcbBgR/TjVzU8ORrIT2/bDjtq+su1zxJebrD4jMQR4od7qLFpJC0 xTqsgK+61gVsATvo8fINwOtC9WR8yluU7n2AjhgpUbl9Upp24ARFDcEeTkpXFv6WOk TTOklLH7fmxQWNE+rRKuZbKI1R1xFpcDkA4kul08eecbTlGIywgaqvtxCo8T1IK8AK Gsfab5i02ZNxvT0QVtJTaptdDoG8NuahCIdBGxA/1Aq4j1xczlfLKyc6luvl3FZ69E Z053ersxRZ1Aw== Received: by mail-wm1-f52.google.com with SMTP id w26so1283034wmi.0 for ; Wed, 12 Jan 2022 02:36:00 -0800 (PST) X-Gm-Message-State: AOAM531i+6TPzG6YPZrdxTvh06BFsmeoDEyq3E2T7DesqhJOjSDl3lX8 yfpP1ov4u1DRAEPHUZLEFtrXQi2W8ESYYbR7ejY= X-Google-Smtp-Source: ABdhPJzLubNvDr9vcO+n1ycLvAOTkivx5lnsLEuoGp1wezKW3xDAUYQcqVzmJwdDPJ/H0MKVowUahkus/R3EkP1AYVo= X-Received: by 2002:a05:600c:3c9c:: with SMTP id bg28mr6108385wmb.190.1641983759332; Wed, 12 Jan 2022 02:35:59 -0800 (PST) MIME-Version: 1.0 References: <20220111214626.1597-1-Sunny.Wang@arm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 12 Jan 2022 11:35:47 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platform PATCH v1] Silicon/Marvell/Armada7k8k: Fix wrong SMBIOS version issue To: Marcin Wojtas Cc: Sunny Wang , edk2-devel-groups-io , Leif Lindholm , Ard Biesheuvel , Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 12 Jan 2022 at 00:00, Marcin Wojtas wrote: > > wt., 11 sty 2022 o 22:46 Sunny Wang napisa=C5=82(a): > > > > The SMBIOS data is based on v3.3.0, but its version is set to v3.2.0. > > Since PcdSmbiosVersion in MdeModulePkg.dec is v3.3.0, so just remove > > the platform overridden value in .dsc file to fix this issue. > > > > This also fixed the FWTS failure below: > > dmicheck: Type 17 expects length of 0x54, has incorrect length of 0x5c > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Marcin Wojtas > > Cc: Samer El-Haj-Mahmoud > > > > Signed-off-by: Sunny Wang > > --- > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Ma= rvell/Armada7k8k/Armada7k8k.dsc.inc > > index 3b76acd99c..5e15378207 100644 > > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > > @@ -1,5 +1,5 @@ > > # > > -#Copyright (c) 2011-2012, ARM Limited. All rights reserved. > > +#Copyright (c) 2011-2022, ARM Limited. All rights reserved. > > #Copyright (C) 2016 Marvell International Ltd. > > # > > #SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -387,7 +387,6 @@ > > # SMBIOS/DMI > > gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0 > > gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosEntryPointProvideMethod|0x2 > > - gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0302 > > gMarvellTokenSpaceGuid.PcdFirmwareVersion|"EDK2 SH 1.1" > > > > > Reviewed-by: Marcin Wojtas > Pushed as d5ead8b73d62..60bb320b9e47 But in the future, please omit the copyright banner updates if you are not making changes that establish copyright on the code (and I don't see how that could be the case when you are deleting a single line)