From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6C35AD81113 for ; Tue, 9 Jan 2024 10:46:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hcI9PSxNCIks9PfI/0QlquH73PS/IhaedpzR18fdZCg=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1704797172; v=1; b=qbwpYCgGZ3HvIx262ZYKR1poEsGyRClIcflH6GmqxYRQSTXeEbzAhaqV8qclnDVBqJ6wqmoR +hq2GQDrhBOPbUmI0JCiokItw+6twHxXHHQxDqWwjXgRrdjG2Nlz0TNL0aFNO3Cu6LAtvmAlt9O MePbNOFNZ6pi7SZT5OygEtCk= X-Received: by 127.0.0.2 with SMTP id CDzgYY7687511xbFYCD5wuXl; Tue, 09 Jan 2024 02:46:12 -0800 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.13884.1704797171462724769 for ; Tue, 09 Jan 2024 02:46:11 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 00CD56134B for ; Tue, 9 Jan 2024 10:46:11 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F97DC43394 for ; Tue, 9 Jan 2024 10:46:10 +0000 (UTC) X-Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50e6ee8e911so2871896e87.1 for ; Tue, 09 Jan 2024 02:46:10 -0800 (PST) X-Gm-Message-State: 6NJ9SBzmdQjY3huLup3qP1tDx7686176AA= X-Google-Smtp-Source: AGHT+IGSarOPQKtiOVdoGtZSEUnl+BFJuCQxDu+373rN1RmsOdGiuDH7wW9Hx/UCKBsh901cKZxwlcfBu4OePiPI92U= X-Received: by 2002:a19:2d4c:0:b0:50e:7dfc:e70d with SMTP id t12-20020a192d4c000000b0050e7dfce70dmr1835861lft.116.1704797168628; Tue, 09 Jan 2024 02:46:08 -0800 (PST) MIME-Version: 1.0 References: <2490526e-539f-9d5c-4572-f09c324a07aa@redhat.com> In-Reply-To: <2490526e-539f-9d5c-4572-f09c324a07aa@redhat.com> From: "Ard Biesheuvel" Date: Tue, 9 Jan 2024 11:45:57 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] Updates to .mailmap needed for Jeff Brasen, Jake Garver, Joey Vagades and Michael Roth? To: devel@edk2.groups.io, lersek@redhat.com, Michael Kinney Cc: rebecca@os.amperecomputing.com, Jeff Brasen , jake@nvidia.com, Michael.Roth@amd.com, joeyvagedes@microsoft.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qbwpYCgG; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) On Tue, 9 Jan 2024 at 10:17, Laszlo Ersek wrote: > > On 1/5/24 01:05, Rebecca Cran via groups.io wrote: > > I noticed recent commits by Jeff Brasen, Jake Garver, Joey Vagades and > > Michael Roth have funky Author lines, which I think means .mailmap needs > > updated? > > > > Author: Jeff Brasen via groups.io > > Author: Joey Vagedes via groups.io > > Author: Jake Garver via groups.io > > Author: Roth, Michael via groups.io > > I'm sure I'm confusing the terms here, but this is a consequence of > DMARC / DKIM / whatever, for some senders. groups.io cannot resend some > kind of messages to list subscribers where the original sender domain > (such as nvidia.com, microsoft.com, amd.com) is cryptographically > authenticated. If groups.io resent those messages with identical "from", > then the recipients (list subscribers) would reject those messages, > because they'd perceive the messages as fakes (the crypto check would > catch that the messages came from groups.io but claimed to originate > from nvidia.com, microsoft.com, amd.com -- that's exactly what DKIM / > DMARC etc etc are supposed to prevent). Therefore groups.io rewrites the > sender email addresses like seen above, and then "git-am" picks up those > rewritten addresses verbatim. That's how they end up in the git commit > history. > > This can be manually fixed by whoever applies such patches from the > list: after the initial "git-am", a git-rebase is needed, and each patch > needs to have its author meta-datum fixed with "git commit --amend > --author='corrected email address'". It's a lot of manual and error > prone work (unless someone scripts it, effectively "decoding" the > rewriting format that groups.io employs). As much as it pains me to > admit it, this is definitely an argument in favor of git forge-based > contributions, and against mailing list-based patches. > > ".mailmap" can be used to mitigate this issue, per gitmailmap(5); it'd > be better just not to permit such mangled "From:" fields to seep into > the git log, in the future. :/ > Agreed, and I think this came up somewhere last year perhaps? Mike Kinney (cc'ed) might remember if that went anywhere, but the idea was for PatchCheck.py (which is also used in CI) to reject patches using an email address in this format. Note that git am does support a 'From: ' header as the first line of the commit log, and will use it correctly to supersede the From: header in the SMTP envelope. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113438): https://edk2.groups.io/g/devel/message/113438 Mute This Topic: https://groups.io/mt/103534194/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-