public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: chris.willing@linux.com
Cc: Gerd Hoffmann <gerd@kraxel.org>,
	edk2-devel-groups-io <devel@edk2.groups.io>,
	 James Bottomley <James.Bottomley@hansenpartnership.com>,
	 Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel()
Date: Wed, 11 Aug 2021 12:30:38 +0200	[thread overview]
Message-ID: <CAMj1kXE1wu8sD-bpgf2LKjxLQ25ZkYzsx-cN7NpwAOKaxWT0-g@mail.gmail.com> (raw)
In-Reply-To: <5eb58219-758c-e12b-8bd3-5d646dba72bc@linux.com>

On Wed, 11 Aug 2021 at 11:55, Christoph Willing
<475.chris.willing@gmail.com> wrote:
>
> On 11/8/21 4:12 pm, Gerd Hoffmann wrote:
> >   Hi,
> >
> >> I amended my script to have:
> >>
> >> -drive if=none,id=sd00,file=disk.img,format=raw \
> >> -device virtio-scsi-pci,id=scsi \
> >> -device scsi-hd,bus=scsi.0,drive=sd00 \
> >
> > That switches storage from ide to virtio-scsi.
> >
> > Which is a good idea from the performance point of view.  Will obviously
> > also workaround ide problems.  But might fail now due to virtio-scsi
> > driver not being part of your initrd.
> >
>
> Thank you James & Gerd,
>
> Your suggestions & comments led me to reconsider the contents of the
> initrd and the problem is now fixed.
>
> I had been using an initrd that worked perfectly in a non-UEFI boot and
> half worked with UEFI boot (the working half being when code was
> patched). However when I generated a completely new initrd after
> installing a new system in UEFI mode, I could see many virtio modules
> being added which were not part of the old initrd I had been using.
> Booting with the new initrd works perfectly in  all boot modes using
> OVMF files created without any code patching.
>
> Is there a particular procedure to withdraw my patch request, or does it
> die a quiet death by being ignored now?
>

Glad to hear that the mystery is solved now.

As for the patch, we will just disregard it - no need for any other
action on your part.

-- 
Ard.

  reply	other threads:[~2021-08-11 10:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28  2:02 [PATCH 0/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel() Christoph Willing
2021-07-28  2:02 ` [PATCH 1/1] " Christoph Willing
2021-08-09 13:08   ` [edk2-devel] " Ard Biesheuvel
     [not found] ` <1695D2E15A92C8E7.3876@groups.io>
2021-08-09 12:53   ` Christoph Willing
2021-08-09 14:52     ` James Bottomley
2021-08-10  0:10       ` Christoph Willing
2021-08-10  6:01         ` Gerd Hoffmann
2021-08-10 12:10           ` Christoph Willing
2021-08-10 14:26         ` James Bottomley
2021-08-10 23:04           ` Christoph Willing
2021-08-10 23:24             ` James Bottomley
2021-08-11  0:34               ` Christoph Willing
2021-08-11  6:12                 ` Gerd Hoffmann
2021-08-11  9:55                   ` Christoph Willing
2021-08-11 10:30                     ` Ard Biesheuvel [this message]
2021-08-12 12:41                       ` Christoph Willing
2021-08-12 13:36                         ` Gerd Hoffmann
2021-08-12 14:07                           ` Christoph Willing
2021-08-11  6:08           ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXE1wu8sD-bpgf2LKjxLQ25ZkYzsx-cN7NpwAOKaxWT0-g@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox