From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web09.5824.1628677851182425858 for ; Wed, 11 Aug 2021 03:30:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MI/GKqof; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 7DB5160551 for ; Wed, 11 Aug 2021 10:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628677850; bh=8vzv/H25Q/ak1/IKNNGhnP9SuJqbs2H1nnRN9W8ep4M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MI/GKqofE580gM9VLIeBY7V0TmNiWfTkyjLfz5g0XdXowvN5uab7I495E/4l30a9a c21qm2bRdQM+9TPf1ptF39/VkckBr+SzyYKMQu1b8A7v1Kt5HPs6qo7vCSbYkvK+a4 YQ6eR2DmrLstQEQkdzuBt2bsChNczj+OCgz93ECfG2qDfZ90Of/WDIQnOYg25+B1Wx avidGfJ6K6vstovjdnIHkC3ub/YyqoHGz+GDrNHKWTwnrptSPGje/UuLD0JSNBYmqP RbYE+MD8HARsSKXHPyXqj1Zz8LGoAohPZk+7pyPRHIiQiAKZ7cnIxv5y0+1tVziZcu 0HsYEo5cmkcAA== Received: by mail-oi1-f169.google.com with SMTP id t128so3900820oig.1 for ; Wed, 11 Aug 2021 03:30:50 -0700 (PDT) X-Gm-Message-State: AOAM530nzC5g5BFJ4Kp4Zy2uKdZY4ejCkWsN88MzQfdxq8jO7I0zMt7L jMH5tZKlnh0KxzboL17OCbn8JkIeX4Fl8ZV7+Lk= X-Google-Smtp-Source: ABdhPJwpoM69YOj5HTyoV9xoXkbNaDEohervMhkQvDb1VepH/x24rN+soXC5m7bGeIfXLewW6tI/6Kztuf3NRThkXWc= X-Received: by 2002:aca:dd89:: with SMTP id u131mr6970170oig.47.1628677849860; Wed, 11 Aug 2021 03:30:49 -0700 (PDT) MIME-Version: 1.0 References: <20210728020232.127332-1-chris.willing@linux.com> <1695D2E15A92C8E7.3876@groups.io> <62f9ffa0-786f-09dd-9546-c4c118fa2a17@linux.com> <1b544f28-b5b9-c08c-bab7-8c1f41778dce@linux.com> <5c85a3f963d1ab7d20e177db9a07a73e82a0eed0.camel@HansenPartnership.com> <7dc3b9d2-5ebb-c261-46b4-658dcbbfd0f4@linux.com> <8286f815812caccbffaa3696f5e884a62ec0a046.camel@HansenPartnership.com> <20210811061223.prihfxnufka6gzxp@sirius.home.kraxel.org> <5eb58219-758c-e12b-8bd3-5d646dba72bc@linux.com> In-Reply-To: <5eb58219-758c-e12b-8bd3-5d646dba72bc@linux.com> From: "Ard Biesheuvel" Date: Wed, 11 Aug 2021 12:30:38 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel() To: chris.willing@linux.com Cc: Gerd Hoffmann , edk2-devel-groups-io , James Bottomley , Ard Biesheuvel , Jiewen Yao Content-Type: text/plain; charset="UTF-8" On Wed, 11 Aug 2021 at 11:55, Christoph Willing <475.chris.willing@gmail.com> wrote: > > On 11/8/21 4:12 pm, Gerd Hoffmann wrote: > > Hi, > > > >> I amended my script to have: > >> > >> -drive if=none,id=sd00,file=disk.img,format=raw \ > >> -device virtio-scsi-pci,id=scsi \ > >> -device scsi-hd,bus=scsi.0,drive=sd00 \ > > > > That switches storage from ide to virtio-scsi. > > > > Which is a good idea from the performance point of view. Will obviously > > also workaround ide problems. But might fail now due to virtio-scsi > > driver not being part of your initrd. > > > > Thank you James & Gerd, > > Your suggestions & comments led me to reconsider the contents of the > initrd and the problem is now fixed. > > I had been using an initrd that worked perfectly in a non-UEFI boot and > half worked with UEFI boot (the working half being when code was > patched). However when I generated a completely new initrd after > installing a new system in UEFI mode, I could see many virtio modules > being added which were not part of the old initrd I had been using. > Booting with the new initrd works perfectly in all boot modes using > OVMF files created without any code patching. > > Is there a particular procedure to withdraw my patch request, or does it > die a quiet death by being ignored now? > Glad to hear that the mystery is solved now. As for the patch, we will just disregard it - no need for any other action on your part. -- Ard.