From: "Ard Biesheuvel" <ardb@kernel.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, Pedro Falcato <pedro.falcato@gmail.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Michael Brown <mcb30@ipxe.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy
Date: Mon, 4 Sep 2023 14:06:48 +0200 [thread overview]
Message-ID: <CAMj1kXE2wvv9xn4BH4hk-Qhb2yHRjeSEphXZUvVTwFGdxkx3vA@mail.gmail.com> (raw)
In-Reply-To: <ywvixrp2ze647qe6747etc6qkfz4ffqyig3f3tsq3j3njinxys@jyma3t62tcw7>
On Mon, 4 Sept 2023 at 13:45, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Thu, Aug 31, 2023 at 06:01:56PM +0200, Ard Biesheuvel wrote:
> > On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel <ardb@kernel.org> wrote:
> > >
> > > On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > > >
> > > > Hi,
> > > >
> > > > > I have tried the patch below, and I don't see any slowdowns with or
> > > > > without the patch, running both DEBUG and RELEASE builds under
> > > > > ordinary KVM/nested-virt. Note that the change in the first hunk will
> > > > > cause the ASSERT()s removed in the other hunks to trigger so the code
> > > > > is definitely being exercised.
> > > >
> > > > QE team tested again with fresh builds, the slowdown isn't there any
> > > > more. Not fully clear where it came from, but most likely not from
> > > > this patch.
> > > >
> > > > Only 20 successful test runs so far, which a good start, but with
> > > > a reproduce rate below 20% not that much. I'll post an update
> > > > when it I get more results.
> > > >
> > >
> > > Excellent, thanks for the update.
> >
> > Given that the QE engineer appears to have lost interest, I intend to
> > merge this patch as-is unless anyone feels this is premature.
>
> I was offline a few days. QE actually reported back: 100 test runs
> without problems.
>
> Tested-by: Gerd Hoffmann <kraxel@redhat.com>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
>
Thanks for reporting back. This is merged now.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108257): https://edk2.groups.io/g/devel/message/108257
Mute This Topic: https://groups.io/mt/100256049/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-09-04 12:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 13:45 [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy Ard Biesheuvel
2023-07-21 22:55 ` Pedro Falcato
2023-07-24 14:21 ` Ard Biesheuvel
2023-07-24 17:08 ` Pedro Falcato
2023-08-22 6:25 ` Gerd Hoffmann
2023-08-22 7:57 ` Ard Biesheuvel
2023-08-23 11:07 ` Gerd Hoffmann
2023-08-23 15:11 ` Ard Biesheuvel
2023-08-23 17:18 ` Gerd Hoffmann
2023-08-23 18:10 ` Pedro Falcato
2023-08-24 8:06 ` Gerd Hoffmann
2023-08-24 10:31 ` Ard Biesheuvel
2023-08-28 9:16 ` Gerd Hoffmann
2023-08-28 11:13 ` Ard Biesheuvel
2023-08-31 16:01 ` Ard Biesheuvel
2023-09-04 11:45 ` Gerd Hoffmann
2023-09-04 12:06 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXE2wvv9xn4BH4hk-Qhb2yHRjeSEphXZUvVTwFGdxkx3vA@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox