From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E9DB4D80CA0 for ; Mon, 4 Sep 2023 12:07:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GsuVTGzVHJImQ4/BMAP5ZQxmmwdAHB1l7/Yo+uFw3aA=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1693829226; v=1; b=ktpo3hVJrUq1QcQrl5BYeZSrNURgNgPVwyCmzDUTiitZciaTAIq4lPv2g4+X4b9tHVrCwev/ +jiWRWjcSiv3ocWYpgCNvRezV/r1lzRBLSBjxiGVCTiKAnBb330Kjxh+T+tnzVcnKAfoFeVYgBJ lgClVvy+v9CAI1sRvdJqARac= X-Received: by 127.0.0.2 with SMTP id TxDuYY7687511xSv1YKMm8Gv; Mon, 04 Sep 2023 05:07:06 -0700 X-Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.46632.1693829225490043712 for ; Mon, 04 Sep 2023 05:07:05 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 96178B80C9D for ; Mon, 4 Sep 2023 12:07:03 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E5F4C433CC for ; Mon, 4 Sep 2023 12:07:02 +0000 (UTC) X-Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-50078e52537so2278858e87.1 for ; Mon, 04 Sep 2023 05:07:02 -0700 (PDT) X-Gm-Message-State: APePwHwzAbbeS5H1PWA8gnGex7686176AA= X-Google-Smtp-Source: AGHT+IEiLPxGDWm08oHxOhkTz7H5lEauV5vDSLs30JVzlSO1emScDive02bSnCIGxy0aWmPjZItam4BejejwPnCwlG4= X-Received: by 2002:a05:6512:3994:b0:4f9:570c:7b28 with SMTP id j20-20020a056512399400b004f9570c7b28mr8260944lfu.32.1693829220327; Mon, 04 Sep 2023 05:07:00 -0700 (PDT) MIME-Version: 1.0 References: <4bd53ehby2cto5n2venjfkucot5ayj2xtsl7z6diegh6llrpm2@tj5oh6txxjck> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 4 Sep 2023 14:06:48 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy To: Gerd Hoffmann Cc: devel@edk2.groups.io, Pedro Falcato , Jiewen Yao , Michael Brown , Tom Lendacky , Michael Roth Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ktpo3hVJ; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) On Mon, 4 Sept 2023 at 13:45, Gerd Hoffmann wrote: > > On Thu, Aug 31, 2023 at 06:01:56PM +0200, Ard Biesheuvel wrote: > > On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel wrote: > > > > > > On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote: > > > > > > > > Hi, > > > > > > > > > I have tried the patch below, and I don't see any slowdowns with or > > > > > without the patch, running both DEBUG and RELEASE builds under > > > > > ordinary KVM/nested-virt. Note that the change in the first hunk will > > > > > cause the ASSERT()s removed in the other hunks to trigger so the code > > > > > is definitely being exercised. > > > > > > > > QE team tested again with fresh builds, the slowdown isn't there any > > > > more. Not fully clear where it came from, but most likely not from > > > > this patch. > > > > > > > > Only 20 successful test runs so far, which a good start, but with > > > > a reproduce rate below 20% not that much. I'll post an update > > > > when it I get more results. > > > > > > > > > > Excellent, thanks for the update. > > > > Given that the QE engineer appears to have lost interest, I intend to > > merge this patch as-is unless anyone feels this is premature. > > I was offline a few days. QE actually reported back: 100 test runs > without problems. > > Tested-by: Gerd Hoffmann > Acked-by: Gerd Hoffmann > Thanks for reporting back. This is merged now. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108257): https://edk2.groups.io/g/devel/message/108257 Mute This Topic: https://groups.io/mt/100256049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-