From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A506F78042F for ; Tue, 30 Jan 2024 14:49:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=uwY4CFjif4MPfYNDCTM7FVavPqgavjbS4Zz7HldhzNE=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1706626177; v=1; b=a6gXn1eUNDiSXnTz4MOx7Aw9tsjCfkj6Ju/xqRG7nnALO5KKVV10sGvQEn+BM/k3MTEuF2ct cXYLuzyf2nlu5AdjsYbxi0x1p9Yzj+/RcN36wvXf36cQBCCJqU3EhYOCPDh8nhuVGRr6MXFs6RE oD22ag6CTbiw/hF3c36Fzs5c= X-Received: by 127.0.0.2 with SMTP id Brv0YY7687511xmP4UO5sBz8; Tue, 30 Jan 2024 06:49:37 -0800 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.19877.1706626176468988844 for ; Tue, 30 Jan 2024 06:49:36 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id AB9F2CE1AA9 for ; Tue, 30 Jan 2024 14:49:31 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4ADDC43390 for ; Tue, 30 Jan 2024 14:49:24 +0000 (UTC) X-Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5101cd91017so4452155e87.2 for ; Tue, 30 Jan 2024 06:49:24 -0800 (PST) X-Gm-Message-State: AXNOfWnFNrr09DvItfVQQcbCx7686176AA= X-Google-Smtp-Source: AGHT+IH7kZx4k80/YdrSADiKzQSDuHr5DCVI71jBTzYMKOWZc3bxg+7Lp+S8vrr0+bV/wEjf4+QvreSneI2Esj5RWtE= X-Received: by 2002:a05:6512:e9b:b0:510:ee2d:c185 with SMTP id bi27-20020a0565120e9b00b00510ee2dc185mr6381191lfb.13.1706626163117; Tue, 30 Jan 2024 06:49:23 -0800 (PST) MIME-Version: 1.0 References: <20240129182514.1375466-1-rebecca@os.amperecomputing.com> <20240129182514.1375466-2-rebecca@os.amperecomputing.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 30 Jan 2024 15:49:11 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v5 1/3] ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset To: Sami Mujawar Cc: Rebecca Cran , Leif Lindholm , Ard Biesheuvel , "devel@edk2.groups.io" , nd Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=a6gXn1eU; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 30 Jan 2024 at 15:01, Sami Mujawar wrote: > > Hi Rebecca, > > Please find my feedback inline marked [SAMI]. > > I have fixed those changes in the pull request at https://github.com/tianocore/edk2/pull/5322 > Please let me know if you agree with the changes. > > Hi Ard, Leif, > > Can you please let me know if it is ok to merge the above pull request, please? > Yes, please go ahead and merge this if you are happy with the changes. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114789): https://edk2.groups.io/g/devel/message/114789 Mute This Topic: https://groups.io/mt/104037319/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-