failed Pr

failed Pr

[Ard Biesheuvel]

Hello all,

Regarding

https://github.com/tianocore/edk2/pull/4442

could someone please explain to me:
- what went wrong,
- where to find the button to push to resubmit this PR to CI

Thanks,
Ard.

Re: [edk2-devel] failed Pr

[Attar, AbdulLateef (Abdul Lateef)]

[AMD Official Use Only - General]

Emulator PR failed, that might be the reason its not allowing to push
https://github.com/tianocore/edk2/pull/4442/checks?check_run_id=13834435150

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel via groups.io
Sent: Monday, May 29, 2023 6:19 PM
To: Michael Kinney <michael.d.kinney@intel.com>; Michael Kubacki <michael.kubacki@microsoft.com>; Liming Gao (Byosoft address) <gaoliming@byosoft.com.cn>; edk2-devel-groups-io <devel@edk2.groups.io>
Subject: [edk2-devel] failed Pr

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Hello all,

Regarding

https://github.com/tianocore/edk2/pull/4442

could someone please explain to me:
- what went wrong,
- where to find the button to push to resubmit this PR to CI

Thanks,
Ard.

Re: [edk2-devel] failed Pr

[Rebecca Cran]

It looks like the agent or machine running the CI task crashed.

"##[error]We stopped hearing from agent Azure Pipelines 18. Verify the 
agent machine is running and has a healthy network connection. Anything 
that terminates an agent process, starves it for CPU, or blocks its 
network access can cause this error. For more information, see: 
https://go.microsoft.com/fwlink/?linkid=846610"









The only way I've found to make CI run again is to do something to cause 
the commit hash to change, for example by making a change to ReadMe.rst 
then reverting it.


-- 

Rebecca Cran


On 5/29/23 6:48 AM, Ard Biesheuvel wrote:
> Hello all,
>
> Regarding
>
> https://github.com/tianocore/edk2/pull/4442
>
> could someone please explain to me:
> - what went wrong,
> - where to find the button to push to resubmit this PR to CI
>
> Thanks,
> Ard.
>
>
> 
>
>

Re: [edk2-devel] failed Pr

[Ard Biesheuvel]

On Mon, 29 May 2023 at 16:37, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> It looks like the agent or machine running the CI task crashed.
>
> "##[error]We stopped hearing from agent Azure Pipelines 18. Verify the
> agent machine is running and has a healthy network connection. Anything
> that terminates an agent process, starves it for CPU, or blocks its
> network access can cause this error. For more information, see:
> https://go.microsoft.com/fwlink/?linkid=846610"
>

Hmm, it would be nice if this thing could distinguish between 'error
in your code' and 'internal error' where the latter does not mark your
PR as being rejected.

>
>
>
>
> The only way I've found to make CI run again is to do something to cause
> the commit hash to change, for example by making a change to ReadMe.rst
> then reverting it.
>

Mike Kinney mentioned last time that there is a button I could push. Mike?

I am reluctant to make unnecessary changes to the state of the branch
just to trick the CI into having another go at it.

Re: [edk2-devel] failed Pr

[Sean]

[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]

It has been rerun.

________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Ard Biesheuvel <ardb@kernel.org>
Sent: Monday, May 29, 2023 7:44:37 AM
To: Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Michael Kinney <michael.d.kinney@intel.com>; Michael Kubacki <michael.kubacki@microsoft.com>; Liming Gao (Byosoft address) <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] failed Pr

On Mon, 29 May 2023 at 16:37, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> It looks like the agent or machine running the CI task crashed.
>
> "##[error]We stopped hearing from agent Azure Pipelines 18. Verify the
> agent machine is running and has a healthy network connection. Anything
> that terminates an agent process, starves it for CPU, or blocks its
> network access can cause this error. For more information, see:
> https://go.microsoft.com/fwlink/?linkid=846610"
>

Hmm, it would be nice if this thing could distinguish between 'error
in your code' and 'internal error' where the latter does not mark your
PR as being rejected.

>
>
>
>
> The only way I've found to make CI run again is to do something to cause
> the commit hash to change, for example by making a change to ReadMe.rst
> then reverting it.
>

Mike Kinney mentioned last time that there is a button I could push. Mike?

I am reluctant to make unnecessary changes to the state of the branch
just to trick the CI into having another go at it.






[-- Attachment #2: Type: text/html, Size: 2455 bytes --]

Re: [edk2-devel] failed Pr

[Michael D Kinney]

[-- Attachment #1: Type: text/plain, Size: 2428 bytes --]

Hi Sean,

Do you know what GitHub permissions are required to see the re-run button?

I think it is reasonable for all Maintainers to have that available.

Mike

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean
Sent: Monday, May 29, 2023 8:12 AM
To: devel@edk2.groups.io; ardb@kernel.org; Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; Kubacki, Michael <michael.kubacki@microsoft.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] failed Pr

It has been rerun.

________________________________
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Ard Biesheuvel <ardb@kernel.org<mailto:ardb@kernel.org>>
Sent: Monday, May 29, 2023 7:44:37 AM
To: Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Michael Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Michael Kubacki <michael.kubacki@microsoft.com<mailto:michael.kubacki@microsoft.com>>; Liming Gao (Byosoft address) <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
Subject: Re: [edk2-devel] failed Pr

On Mon, 29 May 2023 at 16:37, Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>> wrote:
>
> It looks like the agent or machine running the CI task crashed.
>
> "##[error]We stopped hearing from agent Azure Pipelines 18. Verify the
> agent machine is running and has a healthy network connection. Anything
> that terminates an agent process, starves it for CPU, or blocks its
> network access can cause this error. For more information, see:
> https://go.microsoft.com/fwlink/?linkid=846610"<https://go.microsoft.com/fwlink/?linkid=846610%22>
>

Hmm, it would be nice if this thing could distinguish between 'error
in your code' and 'internal error' where the latter does not mark your
PR as being rejected.

>
>
>
>
> The only way I've found to make CI run again is to do something to cause
> the commit hash to change, for example by making a change to ReadMe.rst
> then reverting it.
>

Mike Kinney mentioned last time that there is a button I could push. Mike?

I am reluctant to make unnecessary changes to the state of the branch
just to trick the CI into having another go at it.






[-- Attachment #2: Type: text/html, Size: 5703 bytes --]

Re: [edk2-devel] failed Pr

[Sean]

[-- Attachment #1: Type: text/plain, Size: 3902 bytes --]

It has changed over time and I no longer see a button on the "checks" page of GitHub.  I only see the button in the azure pipeline which would mean maintainers would need to be "contributors" in the azure DevOps organization/project. I have no problem with that and it looks like you can sign in with a GitHub account so it should just be a matter of collecting the email address associated with their GitHub and inviting them to join.  We only get 5 free basic users but we get unlimited free "stakeholder" accounts. I assume we might need basic accounts to interact with the pipeline stuff but I don't know for sure.  Anyone who has paid Microsoft visual studio subscriptions (like from an employer) usually doesn't count towards the 5.

Regardless for those actively contributing and interested we should add them up to the limit.  This was one of the reasons we had desired long term to align on GitHub build services instead.

Other thoughts?

Thanks
Sean
________________________________
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Monday, May 29, 2023 8:13:32 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; spbrogan@outlook.com <spbrogan@outlook.com>; ardb@kernel.org <ardb@kernel.org>; Rebecca Cran <rebecca@bsdio.com>
Cc: Kubacki, Michael <michael.kubacki@microsoft.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2-devel] failed Pr


Hi Sean,



Do you know what GitHub permissions are required to see the re-run button?



I think it is reasonable for all Maintainers to have that available.



Mike



From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean
Sent: Monday, May 29, 2023 8:12 AM
To: devel@edk2.groups.io; ardb@kernel.org; Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; Kubacki, Michael <michael.kubacki@microsoft.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] failed Pr



It has been rerun.



________________________________

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Ard Biesheuvel <ardb@kernel.org<mailto:ardb@kernel.org>>
Sent: Monday, May 29, 2023 7:44:37 AM
To: Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Michael Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Michael Kubacki <michael.kubacki@microsoft.com<mailto:michael.kubacki@microsoft.com>>; Liming Gao (Byosoft address) <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
Subject: Re: [edk2-devel] failed Pr



On Mon, 29 May 2023 at 16:37, Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>> wrote:
>
> It looks like the agent or machine running the CI task crashed.
>
> "##[error]We stopped hearing from agent Azure Pipelines 18. Verify the
> agent machine is running and has a healthy network connection. Anything
> that terminates an agent process, starves it for CPU, or blocks its
> network access can cause this error. For more information, see:
> https://go.microsoft.com/fwlink/?linkid=846610"<https://go.microsoft.com/fwlink/?linkid=846610%22>
>

Hmm, it would be nice if this thing could distinguish between 'error
in your code' and 'internal error' where the latter does not mark your
PR as being rejected.

>
>
>
>
> The only way I've found to make CI run again is to do something to cause
> the commit hash to change, for example by making a change to ReadMe.rst
> then reverting it.
>

Mike Kinney mentioned last time that there is a button I could push. Mike?

I am reluctant to make unnecessary changes to the state of the branch
just to trick the CI into having another go at it.







[-- Attachment #2: Type: text/html, Size: 6704 bytes --]

Re: [edk2-devel] failed Pr

[Rebecca Cran]

I pay for a Visual Studio subscription, so I shouldn’t count towards the limit then.
My GitHub email address is the same as I use here.

— 
Rebecca

On Mon, May 29, 2023, at 9:37 AM, Sean wrote:
> It has changed over time and I no longer see a button on the "checks" 
> page of GitHub.  I only see the button in the azure pipeline which 
> would mean maintainers would need to be "contributors" in the azure 
> DevOps organization/project. I have no problem with that and it looks 
> like you can sign in with a GitHub account so it should just be a 
> matter of collecting the email address associated with their GitHub and 
> inviting them to join.  We only get 5 free basic users but we get 
> unlimited free "stakeholder" accounts. I assume we might need basic 
> accounts to interact with the pipeline stuff but I don't know for sure. 
>  Anyone who has paid Microsoft visual studio subscriptions (like from 
> an employer) usually doesn't count towards the 5.   
>
> Regardless for those actively contributing and interested we should add 
> them up to the limit.  This was one of the reasons we had desired long 
> term to align on GitHub build services instead.
>
> Other thoughts?
>
> Thanks
> Sean 
> *From:* Kinney, Michael D <michael.d.kinney@intel.com>
> *Sent:* Monday, May 29, 2023 8:13:32 AM
> *To:* devel@edk2.groups.io <devel@edk2.groups.io>; spbrogan@outlook.com 
> <spbrogan@outlook.com>; ardb@kernel.org <ardb@kernel.org>; Rebecca Cran 
> <rebecca@bsdio.com>
> *Cc:* Kubacki, Michael <michael.kubacki@microsoft.com>; Gao, Liming 
> <gaoliming@byosoft.com.cn>; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> *Subject:* RE: [edk2-devel] failed Pr 
> 
> Hi Sean,
>
> 
>
> Do you know what GitHub permissions are required to see the re-run button?
>
> 
>
> I think it is reasonable for all Maintainers to have that available.
>
> 
>
> Mike
>
> 
>
> *From:* devel@edk2.groups.io <devel@edk2.groups.io> * On Behalf Of *Sean
> *Sent:* Monday, May 29, 2023 8:12 AM
> *To:* devel@edk2.groups.io; ardb@kernel.org; Rebecca Cran 
> <rebecca@bsdio.com>
> *Cc:* devel@edk2.groups.io; Kinney, Michael D 
> <michael.d.kinney@intel.com>; Kubacki, Michael 
> <michael.kubacki@microsoft.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> *Subject:* Re: [edk2-devel] failed Pr
>
> 
>
> It has been rerun. 
>
> 
>
> *From:* devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Ard 
> Biesheuvel <ardb@kernel.org>
> *Sent:* Monday, May 29, 2023 7:44:37 AM
> *To:* Rebecca Cran <rebecca@bsdio.com>
> *Cc:* devel@edk2.groups.io <devel@edk2.groups.io>; Michael Kinney 
> <michael.d.kinney@intel.com>; Michael Kubacki 
> <michael.kubacki@microsoft.com>; Liming Gao (Byosoft address) 
> <gaoliming@byosoft.com.cn>
> *Subject:* Re: [edk2-devel] failed Pr 
>
> 
>
> On Mon, 29 May 2023 at 16:37, Rebecca Cran <rebecca@bsdio.com> wrote:
>>
>> It looks like the agent or machine running the CI task crashed.
>>
>> "##[error]We stopped hearing from agent Azure Pipelines 18. Verify the
>> agent machine is running and has a healthy network connection. Anything
>> that terminates an agent process, starves it for CPU, or blocks its
>> network access can cause this error. For more information, see:
>> https://go.microsoft.com/fwlink/?linkid=846610" <https://go.microsoft.com/fwlink/?linkid=846610%22>
>>
>
> Hmm, it would be nice if this thing could distinguish between 'error
> in your code' and 'internal error' where the latter does not mark your
> PR as being rejected.
>
>>
>>
>>
>>
>> The only way I've found to make CI run again is to do something to cause
>> the commit hash to change, for example by making a change to ReadMe.rst
>> then reverting it.
>>
>
> Mike Kinney mentioned last time that there is a button I could push. Mike?
>
> I am reluctant to make unnecessary changes to the state of the branch
> just to trick the CI into having another go at it.
>
>
>
>
>
>
> 

Re: [edk2-devel] failed Pr

[Michael D Kinney]

[-- Attachment #1: Type: text/plain, Size: 5878 bytes --]

Hi Sean,

I see the "rerun" button on the "checks" page of GitHub from my login.

We have a mix of both Azure Pipelines and GitHub Actions today, so I think it is important to see the "rerun" from GitHub view for Maintainers.

This github page describes the feature, but not the permissions required.

https://docs.github.com/en/actions/managing-workflow-runs/re-running-workflows-and-jobs

We currently have EDK II Maintainer Team set to "Triage Role" permissions.  From the table below, only "Write" and above are allowed to re-run.

https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization#permissions-for-each-role

"Write" permissions add a lot of options, so I think we should discuss tradeoffs in the next Tools/CI meeting.

One option is to add a bot based on a new label to request failed jobs to be re-run.  The bot can use a token with permissions to re-run.

Best regards,

Mike

From: Sean Brogan <spbrogan@outlook.com>
Sent: Monday, May 29, 2023 8:37 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; ardb@kernel.org; Rebecca Cran <rebecca@bsdio.com>
Cc: Kubacki, Michael <michael.kubacki@microsoft.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] failed Pr

It has changed over time and I no longer see a button on the "checks" page of GitHub.  I only see the button in the azure pipeline which would mean maintainers would need to be "contributors" in the azure DevOps organization/project. I have no problem with that and it looks like you can sign in with a GitHub account so it should just be a matter of collecting the email address associated with their GitHub and inviting them to join.  We only get 5 free basic users but we get unlimited free "stakeholder" accounts. I assume we might need basic accounts to interact with the pipeline stuff but I don't know for sure.  Anyone who has paid Microsoft visual studio subscriptions (like from an employer) usually doesn't count towards the 5.

Regardless for those actively contributing and interested we should add them up to the limit.  This was one of the reasons we had desired long term to align on GitHub build services instead.

Other thoughts?

Thanks
Sean
________________________________
From: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Sent: Monday, May 29, 2023 8:13:32 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; spbrogan@outlook.com<mailto:spbrogan@outlook.com> <spbrogan@outlook.com<mailto:spbrogan@outlook.com>>; ardb@kernel.org<mailto:ardb@kernel.org> <ardb@kernel.org<mailto:ardb@kernel.org>>; Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>>
Cc: Kubacki, Michael <michael.kubacki@microsoft.com<mailto:michael.kubacki@microsoft.com>>; Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Subject: RE: [edk2-devel] failed Pr


Hi Sean,



Do you know what GitHub permissions are required to see the re-run button?



I think it is reasonable for all Maintainers to have that available.



Mike



From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Sean
Sent: Monday, May 29, 2023 8:12 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; ardb@kernel.org<mailto:ardb@kernel.org>; Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Kubacki, Michael <michael.kubacki@microsoft.com<mailto:michael.kubacki@microsoft.com>>; Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
Subject: Re: [edk2-devel] failed Pr



It has been rerun.



________________________________

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Ard Biesheuvel <ardb@kernel.org<mailto:ardb@kernel.org>>
Sent: Monday, May 29, 2023 7:44:37 AM
To: Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Michael Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Michael Kubacki <michael.kubacki@microsoft.com<mailto:michael.kubacki@microsoft.com>>; Liming Gao (Byosoft address) <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
Subject: Re: [edk2-devel] failed Pr



On Mon, 29 May 2023 at 16:37, Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>> wrote:
>
> It looks like the agent or machine running the CI task crashed.
>
> "##[error]We stopped hearing from agent Azure Pipelines 18. Verify the
> agent machine is running and has a healthy network connection. Anything
> that terminates an agent process, starves it for CPU, or blocks its
> network access can cause this error. For more information, see:
> https://go.microsoft.com/fwlink/?linkid=846610"<https://go.microsoft.com/fwlink/?linkid=846610%22>
>

Hmm, it would be nice if this thing could distinguish between 'error
in your code' and 'internal error' where the latter does not mark your
PR as being rejected.

>
>
>
>
> The only way I've found to make CI run again is to do something to cause
> the commit hash to change, for example by making a change to ReadMe.rst
> then reverting it.
>

Mike Kinney mentioned last time that there is a button I could push. Mike?

I am reluctant to make unnecessary changes to the state of the branch
just to trick the CI into having another go at it.






[-- Attachment #2: Type: text/html, Size: 12121 bytes --]

Re: [edk2-devel] failed Pr

[Ard Biesheuvel]

On Mon, 29 May 2023 at 18:45, Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> Hi Sean,
>
>
>
> I see the “rerun” button on the “checks” page of GitHub from my login.
>
>
>
> We have a mix of both Azure Pipelines and GitHub Actions today, so I think it is important to see the “rerun” from GitHub view for Maintainers.
>

Yes, that would be lovely.

>
>
> This github page describes the feature, but not the permissions required.
>
>
>
> https://docs.github.com/en/actions/managing-workflow-runs/re-running-workflows-and-jobs
>
>
>
> We currently have EDK II Maintainer Team set to “Triage Role” permissions.  From the table below, only “Write” and above are allowed to re-run.
>
>
>
> https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization#permissions-for-each-role
>
>
>
> “Write” permissions add a lot of options, so I think we should discuss tradeoffs in the next Tools/CI meeting.
>
>
>
> One option is to add a bot based on a new label to request failed jobs to be re-run.  The bot can use a token with permissions to re-run.
>

This would work for me - as long as I don't have to make changes to
the branch, I'm happy with whatever we come up with.

Re: [edk2-devel] failed Pr

[Michael D Kinney]

After looking at GitHub Action features the best approach is likely
a PR comment that provides a request to rerun all failed jobs.

We can define a comment format to indicate a command to a tianocore bot.

Mike




> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Tuesday, May 30, 2023 7:36 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Sean Brogan <spbrogan@outlook.com>; Rebecca Cran <rebecca@bsdio.com>;
> Kubacki, Michael <michael.kubacki@microsoft.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>
> Subject: Re: [edk2-devel] failed Pr
> 
> On Mon, 29 May 2023 at 18:45, Michael D Kinney
> <michael.d.kinney@intel.com> wrote:
> >
> > Hi Sean,
> >
> >
> >
> > I see the “rerun” button on the “checks” page of GitHub from my login.
> >
> >
> >
> > We have a mix of both Azure Pipelines and GitHub Actions today, so I
> think it is important to see the “rerun” from GitHub view for Maintainers.
> >
> 
> Yes, that would be lovely.
> 
> >
> >
> > This github page describes the feature, but not the permissions required.
> >
> >
> >
> > https://docs.github.com/en/actions/managing-workflow-runs/re-running-
> workflows-and-jobs
> >
> >
> >
> > We currently have EDK II Maintainer Team set to “Triage Role”
> permissions.  From the table below, only “Write” and above are allowed to
> re-run.
> >
> >
> >
> > https://docs.github.com/en/organizations/managing-user-access-to-your-
> organizations-repositories/repository-roles-for-an-
> organization#permissions-for-each-role
> >
> >
> >
> > “Write” permissions add a lot of options, so I think we should discuss
> tradeoffs in the next Tools/CI meeting.
> >
> >
> >
> > One option is to add a bot based on a new label to request failed jobs to
> be re-run.  The bot can use a token with permissions to re-run.
> >
> 
> This would work for me - as long as I don't have to make changes to
> the branch, I'm happy with whatever we come up with.

Re: [edk2-devel] failed Pr

[Ard Biesheuvel]

On Tue, 30 May 2023 at 17:36, Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
>
> After looking at GitHub Action features the best approach is likely
> a PR comment that provides a request to rerun all failed jobs.
>
> We can define a comment format to indicate a command to a tianocore bot.
>

Sounds reasonable, although doesn't that imply that anyone who can
comment can trigger this action?


>
> > -----Original Message-----
> > From: Ard Biesheuvel <ardb@kernel.org>
> > Sent: Tuesday, May 30, 2023 7:36 AM
> > To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> > Cc: Sean Brogan <spbrogan@outlook.com>; Rebecca Cran <rebecca@bsdio.com>;
> > Kubacki, Michael <michael.kubacki@microsoft.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>
> > Subject: Re: [edk2-devel] failed Pr
> >
> > On Mon, 29 May 2023 at 18:45, Michael D Kinney
> > <michael.d.kinney@intel.com> wrote:
> > >
> > > Hi Sean,
> > >
> > >
> > >
> > > I see the “rerun” button on the “checks” page of GitHub from my login.
> > >
> > >
> > >
> > > We have a mix of both Azure Pipelines and GitHub Actions today, so I
> > think it is important to see the “rerun” from GitHub view for Maintainers.
> > >
> >
> > Yes, that would be lovely.
> >
> > >
> > >
> > > This github page describes the feature, but not the permissions required.
> > >
> > >
> > >
> > > https://docs.github.com/en/actions/managing-workflow-runs/re-running-
> > workflows-and-jobs
> > >
> > >
> > >
> > > We currently have EDK II Maintainer Team set to “Triage Role”
> > permissions.  From the table below, only “Write” and above are allowed to
> > re-run.
> > >
> > >
> > >
> > > https://docs.github.com/en/organizations/managing-user-access-to-your-
> > organizations-repositories/repository-roles-for-an-
> > organization#permissions-for-each-role
> > >
> > >
> > >
> > > “Write” permissions add a lot of options, so I think we should discuss
> > tradeoffs in the next Tools/CI meeting.
> > >
> > >
> > >
> > > One option is to add a bot based on a new label to request failed jobs to
> > be re-run.  The bot can use a token with permissions to re-run.
> > >
> >
> > This would work for me - as long as I don't have to make changes to
> > the branch, I'm happy with whatever we come up with.

Re: [edk2-devel] failed Pr

[Michael D Kinney]

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Tuesday, May 30, 2023 8:45 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: devel@edk2.groups.io; Sean Brogan <spbrogan@outlook.com>; Rebecca Cran
> <rebecca@bsdio.com>; Kubacki, Michael <michael.kubacki@microsoft.com>; Gao,
> Liming <gaoliming@byosoft.com.cn>
> Subject: Re: [edk2-devel] failed Pr
> 
> On Tue, 30 May 2023 at 17:36, Kinney, Michael D
> <michael.d.kinney@intel.com> wrote:
> >
> > After looking at GitHub Action features the best approach is likely
> > a PR comment that provides a request to rerun all failed jobs.
> >
> > We can define a comment format to indicate a command to a tianocore bot.
> >
> 
> Sounds reasonable, although doesn't that imply that anyone who can
> comment can trigger this action?

Yes.  However, the bot can also check to see if the submitter of the comment
is a member of the EDK II Maintainers team.

> 
> 
> >
> > > -----Original Message-----
> > > From: Ard Biesheuvel <ardb@kernel.org>
> > > Sent: Tuesday, May 30, 2023 7:36 AM
> > > To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> > > Cc: Sean Brogan <spbrogan@outlook.com>; Rebecca Cran
> <rebecca@bsdio.com>;
> > > Kubacki, Michael <michael.kubacki@microsoft.com>; Gao, Liming
> > > <gaoliming@byosoft.com.cn>
> > > Subject: Re: [edk2-devel] failed Pr
> > >
> > > On Mon, 29 May 2023 at 18:45, Michael D Kinney
> > > <michael.d.kinney@intel.com> wrote:
> > > >
> > > > Hi Sean,
> > > >
> > > >
> > > >
> > > > I see the “rerun” button on the “checks” page of GitHub from my
> login.
> > > >
> > > >
> > > >
> > > > We have a mix of both Azure Pipelines and GitHub Actions today, so I
> > > think it is important to see the “rerun” from GitHub view for
> Maintainers.
> > > >
> > >
> > > Yes, that would be lovely.
> > >
> > > >
> > > >
> > > > This github page describes the feature, but not the permissions
> required.
> > > >
> > > >
> > > >
> > > > https://docs.github.com/en/actions/managing-workflow-runs/re-running-
> > > workflows-and-jobs
> > > >
> > > >
> > > >
> > > > We currently have EDK II Maintainer Team set to “Triage Role”
> > > permissions.  From the table below, only “Write” and above are allowed
> to
> > > re-run.
> > > >
> > > >
> > > >
> > > > https://docs.github.com/en/organizations/managing-user-access-to-
> your-
> > > organizations-repositories/repository-roles-for-an-
> > > organization#permissions-for-each-role
> > > >
> > > >
> > > >
> > > > “Write” permissions add a lot of options, so I think we should
> discuss
> > > tradeoffs in the next Tools/CI meeting.
> > > >
> > > >
> > > >
> > > > One option is to add a bot based on a new label to request failed
> jobs to
> > > be re-run.  The bot can use a token with permissions to re-run.
> > > >
> > >
> > > This would work for me - as long as I don't have to make changes to
> > > the branch, I'm happy with whatever we come up with.

failed pr

[Ard Biesheuvel]

Could someone push the merge button on this pr please?

https://github.com/tianocore/edk2/pull/4470