From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id A989D740035 for ; Thu, 9 May 2024 07:44:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=sHahiK2FvxGiGUjG5X7q5tJVHnSjXdoV9g0vj8kf5jI=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715240646; v=1; b=DkiXTMRdWBWEUZYNvyn//JH4XOjCRAU2K+e6JZwD5ZdkWQH/QtEkjuCHFUfDXSW1xAay4zmT cxSmwc23x7iTvma3my5YuHVBi3RImmWNC2iRzwpBxHQXi5s6f/8kvtmm7KDPjCGBzpmKocNQUl3 ebwhiXjip1xc25cQ3N6SEYbD0toaXeMOs+xz+UXi1vGxPa7fB1KHzNtV9tn2zRSZxh4uTdYquQC xfSv+B+d6gffqPfg8NZ9qdB8sKNcEthf6SWu4dZhYYe2tLCoo5u1DmYDbMfgFZJn0nFzPaCYRcC y3TH2VZoTTDj6QogAmPdAtJ/SIozWCJKUSjXB98dj+1Ow== X-Received: by 127.0.0.2 with SMTP id jsnZYY7687511xA0eaE6ybsk; Thu, 09 May 2024 00:44:06 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.4742.1715240645101447225 for ; Thu, 09 May 2024 00:44:05 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5B27261CF2 for ; Thu, 9 May 2024 07:44:04 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EDB9C32783 for ; Thu, 9 May 2024 07:44:03 +0000 (UTC) X-Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-51fdc9af005so772686e87.3 for ; Thu, 09 May 2024 00:44:03 -0700 (PDT) X-Gm-Message-State: AttjoAm4GQ9rUXWDE5SEIUO1x7686176AA= X-Google-Smtp-Source: AGHT+IFlYcf8k5Dr7XsSpFA+cnLPWKjoGfHXFniEsrb7+9qgtdlDu7us1FU6IyPYfvtnwkTcMFVUzXQDftxhip3uLqA= X-Received: by 2002:ac2:4c2c:0:b0:51c:eeee:8679 with SMTP id 2adb3069b0e04-5217cf3cb15mr3802210e87.56.1715240641879; Thu, 09 May 2024 00:44:01 -0700 (PDT) MIME-Version: 1.0 References: <20240426121720.54308-1-jiaxin.wu@intel.com> <00fb01daa1e3$a1db8fa0$e592aee0$@byosoft.com.cn> In-Reply-To: <00fb01daa1e3$a1db8fa0$e592aee0$@byosoft.com.cn> From: "Ard Biesheuvel" Date: Thu, 9 May 2024 09:43:50 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: "Wu, Jiaxin" , "Yao, Jiewen" , "Ni, Ray" , "Zeng, Star" , Gerd Hoffmann , "Kumar, Rahul R" , "Dong, Guo" , "Rhodes, Sean" , "Lu, James" , "Guo, Gua" , Abdul Lateef Attar , Abner Chang , Tom Lendacky Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 09 May 2024 00:44:05 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=DkiXTMRd; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks Liming. On Thu, 9 May 2024 at 09:36, gaoliming via groups.io wrote: > > Ard: > Gerd is the reviewer of OvmfPkg. He gave Acked-by before soft feature f= reeze. So, this patch set can be merged for this stable tag 202405. > > And, this patch set has been merged. > > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Ard Biesheuvel > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=889=E6=97=A5= 0:44 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: Wu, Jiaxin ; Liming G= ao (Byosoft address) > > > > =E6=8A=84=E9=80=81: Yao, Jiewen ; Ni, Ray ; > > devel@edk2.groups.io; Zeng, Star ; Gerd Hoffmann > > ; Kumar, Rahul R ; Dong, Gu= o > > ; Rhodes, Sean ; Lu, James > > ; Guo, Gua ; Abdul Lateef Attar > > ; Abner Chang ; Tom > > Lendacky > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocation= Lib > > > > Happy to merge this. > > > > Liming, please let me know if this meets the soft freeze requirements? > > > > Thanks, > > > > > > On Tue, 7 May 2024 at 07:18, Wu, Jiaxin wrote: > > > > > > Thanks Jiewen. > > > > > > > > > > > > > > > > > > > > > > > > From: Yao, Jiewen > > > Sent: Tuesday, May 7, 2024 12:59 PM > > > To: Wu, Jiaxin ; Ni, Ray ; > > devel@edk2.groups.io; Ard Biesheuvel > > > Cc: Zeng, Star ; Gerd Hoffmann ; > > Kumar, Rahul R ; Dong, Guo ; > > Rhodes, Sean ; Lu, James ; G= uo, > > Gua ; Abdul Lateef Attar = ; > > Abner Chang ; Tom Lendacky > > > > > Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib > > > > > > > > > > > > Acked-by: Jiewen Yao > > > > > > > > > > > > From: Wu, Jiaxin > > > Sent: Tuesday, May 7, 2024 11:39 AM > > > To: Ni, Ray ; devel@edk2.groups.io; Ard Biesheuvel > > ; Yao, Jiewen > > > Cc: Zeng, Star ; Gerd Hoffmann ; > > Kumar, Rahul R ; Dong, Guo ; > > Rhodes, Sean ; Lu, James ; G= uo, > > Gua ; Abdul Lateef Attar = ; > > Abner Chang ; Tom Lendacky > > > > > Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib > > > > > > > > > > > > Hi Jiewen and Ard, > > > > > > > > > > > > @Yao, Jiewen, @Ard Biesheuvel, do you agree we merge the change relat= ed to > > OVMF package since you are the OVMF maintainers. Please help check /rev= iew. > > > > > > > > > > > > The patches have been acked/tested by the Gerd. > > > > > > > > > > > > [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for > > OVMF > > > [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create > > gEfiSmmSmramMemoryGuid > > > [PATCH v4 10/14] OvmfPkg: Refine SmmAccess implementation > > > [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation > > is done or not > > > [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase > > > > > > > > > > > > Thanks, > > > > > > Jiaxin > > > > > > > > > > > > From: Wu, Jiaxin > > > Sent: Tuesday, April 30, 2024 6:14 PM > > > To: Ni, Ray ; devel@edk2.groups.io > > > Cc: Zeng, Star ; Gerd Hoffmann ; > > Kumar, Rahul R ; Dong, Guo ; > > Rhodes, Sean ; Lu, James ; G= uo, > > Gua ; Ard Biesheuvel ; Ya= o, > > Jiewen ; Abdul Lateef Attar > > ; Abner Chang ; Tom > > Lendacky > > > Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib > > > > > > > > > > > > Thanks Ray, I missed to add some already reviewed-by tag in v4. All V= 4 patches > > are tested & acted by Gerd: > > > > > > Tested-by: Gerd Hoffmann > > > > > > Acked-by: Gerd Hoffmann > > > > > > > > > > > > For each one: listed as below, *so need Ray =E2=80=9Creviewed-by=E2= =80=9D tag on the patch: > > 05/06/14, need Gerd =E2=80=9Creviewed-by=E2=80=9D tag on the patch: 08= /09/10/11/12* > > > > > > > > > > > > [PATCH v4 01/14] UefiCpuPkg: Add SmmRelocationLib class > > > > > > Reviewed-by: Ray Ni --> no change compared to V3 > > > > > > > > > [PATCH v4 02/14] UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib > > library instance > > > > > > Reviewed-by: Ray Ni --> no change compared to V3 > > > > > > > > > [PATCH v4 03/14] UefiCpuPkg/SmmRelocationLib: Rename global variabl= es > > > > > > Reviewed-by: Ray Ni --> no change compared to V3 > > > > > > > > > [PATCH v4 04/14] UefiCpuPkg/SmmRelocationLib: Avoid unnecessary > > memory allocation > > > > > > Reviewed-by: Ray Ni --> no change compared to V3 > > > > > > > > > [PATCH v4 05/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary > > global variable > > > [PATCH v4 06/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary > > CpuIndex > > > > > > * Change Based on Ray=E2=80=99s comment on V3: split the removal of C= puIndex > > parameter in a new patch, so add the 06 patch in V4.* > > > > > > > > > [PATCH v4 07/14] UefiCpuPkg/SmmRelocationLib: Add library instance = for > > AMD > > > > > > Reviewed-by: Abdul Lateef Attar --> no ch= ange > > compared to V3 > > > > > > > > > [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for > > OVMF > > > [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create > > gEfiSmmSmramMemoryGuid > > > [PATCH v4 10/14] OvmfPkg: Refine SmmAccess implementation > > > [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation > > is done or not > > > [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase > > > > > > *Change Based on Gerd=E2=80=99s comment on V3: 1. Creating the > > EFI_SMM_SMRAM_MEMORY_GUID HOB should be moved to its own function. > > 2) refine the comment in SmmAccess 3) refine the commit log.* > > > > > > > > > [PATCH v4 13/14] UefiPayloadPkg/UefiPayloadPkg.dsc: Include > > SmmRelocationLib > > > > > > Reviewed-by: Gua Guo > > > > > > Reviewed-by: Guo Dong > > > > > > > > > [PATCH v4 14/14] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases > > relocation logic > > > > > > *Change Based on Ray=E2=80=99s comment on V3: move the "TileSize" che= ck just below > > the original TileSize calculation logic* > > > > > > > > > > > > Thanks, > > > > > > Jiaxin > > > > > > > > > > > > From: Ni, Ray > > > Sent: Tuesday, April 30, 2024 2:01 PM > > > To: Wu, Jiaxin ; devel@edk2.groups.io > > > Cc: Zeng, Star ; Gerd Hoffmann ; > > Kumar, Rahul R ; Dong, Guo ; > > Rhodes, Sean ; Lu, James ; G= uo, > > Gua ; Ard Biesheuvel ; Ya= o, > > Jiewen ; Abdul Lateef Attar > > ; Abner Chang ; Tom > > Lendacky > > > Subject: Re: [PATCH v4 00/14] Add SmmRelocationLib > > > > > > > > > > > > Jiaxin, > > > > > > You need to add the missing Reviewed-by for each patch if the patch d= oesn't > > change in V4. > > > > > > > > > > > > Can you reply to this mail to list what patches have already got Revi= ewed-by > > from whom? > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > Ray > > > > > > ________________________________ > > > > > > From: Wu, Jiaxin > > > Sent: Friday, April 26, 2024 20:17 > > > To: devel@edk2.groups.io > > > Cc: Ni, Ray ; Zeng, Star ; Ger= d > > Hoffmann ; Kumar, Rahul R ; > > Dong, Guo ; Rhodes, Sean ; L= u, > > James ; Guo, Gua ; Ard Biesheuve= l > > ; Yao, Jiewen ; Abdul > > Lateef Attar ; Abner Chang > > ; Tom Lendacky > > > Subject: [PATCH v4 00/14] Add SmmRelocationLib > > > > > > > > > > > > PR: https://github.com/tianocore/edk2/pull/5546 > > > > > > Intel plans to separate the smbase relocation logic from > > > PiSmmCpuDxeSmm driver, and the related behavior will be > > > moved to the new interface defined by the SmmRelocationLib > > > class. > > > > > > The SmmRelocationLib class provides the SmmRelocationInit() > > > interface for platform to do the smbase relocation, which > > > shall provide below 2 functionalities: > > > 1. Relocate smbases for each processor. > > > 2. Create the gSmmBaseHobGuid HOB. > > > > > > With SmmRelocationLib, PiSmmCpuDxeSmm driver (which runs at > > > a later phase) can be simplfied as below for SMM init: > > > 1. Consume the gSmmBaseHobGuid HOB for the relocated smbases > > > for each Processor. > > > 2. Execute the early SMM Init. > > > > > > Cc: Ray Ni > > > Cc: Zeng Star > > > Cc: Gerd Hoffmann > > > Cc: Rahul Kumar > > > Cc: Guo Dong > > > Cc: Sean Rhodes > > > Cc: James Lu > > > Cc: Gua Guo > > > Cc: Ard Biesheuvel > > > Cc: Jiewen Yao > > > Cc: Abdul Lateef Attar > > > Cc: Abner Chang > > > Cc: Tom Lendacky > > > Signed-off-by: Jiaxin Wu > > > > > > Jiaxin Wu (14): > > > UefiCpuPkg: Add SmmRelocationLib class > > > UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib library instance > > > UefiCpuPkg/SmmRelocationLib: Rename global variables > > > UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory allocation > > > UefiCpuPkg/SmmRelocationLib: Remove unnecessary global variable > > > UefiCpuPkg/SmmRelocationLib: Remove unnecessary CpuIndex > > > UefiCpuPkg/SmmRelocationLib: Add library instance for AMD > > > OvmfPkg/SmmRelocationLib: Add library instance for OVMF > > > OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid > > > OvmfPkg: Refine SmmAccess implementation > > > OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done or not > > > OvmfPkg/PlatformPei: Relocate SmBases in PEI phase > > > UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocationLib > > > UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic > > > > > > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + > > > OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + > > > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 135 +++-- > > > .../Library/PlatformInitLib/PlatformInitLib.inf | 6 +- > > > .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 33 +- > > > .../Library/SmmRelocationLib}/Ia32/Semaphore.c | 13 +- > > > .../Library/SmmRelocationLib}/Ia32/SmmInit.nasm | 83 +++- > > > .../SmmRelocationLib/InternalSmmRelocationLib.h | 127 +++++ > > > .../Library/SmmRelocationLib/SmmRelocationLib.c | 549 > > +++++++++++++++++++++ > > > .../Library/SmmRelocationLib/SmmRelocationLib.inf | 60 +++ > > > .../SmmRelocationLib/SmramSaveStateConfig.c | 100 ++++ > > > .../Library/SmmRelocationLib}/X64/Semaphore.c | 13 +- > > > .../Library/SmmRelocationLib}/X64/SmmInit.nasm | 85 +++- > > > OvmfPkg/Microvm/MicrovmX64.dsc | 1 + > > > OvmfPkg/OvmfPkgIa32.dsc | 1 + > > > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > > > OvmfPkg/OvmfPkgX64.dsc | 1 + > > > OvmfPkg/PlatformPei/Platform.c | 3 + > > > OvmfPkg/PlatformPei/Platform.h | 5 + > > > OvmfPkg/PlatformPei/PlatformPei.inf | 5 +- > > > OvmfPkg/PlatformPei/SmmRelocation.c | 80 +++ > > > OvmfPkg/SmmAccess/SmmAccess2Dxe.c | 4 +- > > > OvmfPkg/SmmAccess/SmmAccess2Dxe.inf | 5 + > > > OvmfPkg/SmmAccess/SmmAccessPei.c | 116 ++--- > > > OvmfPkg/SmmAccess/SmmAccessPei.inf | 11 +- > > > OvmfPkg/SmmAccess/SmramInternal.c | 72 +-- > > > OvmfPkg/SmmAccess/SmramInternal.h | 19 +- > > > UefiCpuPkg/Include/Library/SmmRelocationLib.h | 42 ++ > > > .../SmmRelocationLib/AmdSmmRelocationLib.inf | 60 +++ > > > .../SmmRelocationLib/AmdSmramSaveStateConfig.c | 125 +++++ > > > .../SmmRelocationLib}/Ia32/Semaphore.c | 13 +- > > > .../SmmRelocationLib}/Ia32/SmmInit.nasm | 83 +++- > > > .../SmmRelocationLib/InternalSmmRelocationLib.h | 127 +++++ > > > .../Library/SmmRelocationLib/SmmRelocationLib.c | 549 > > +++++++++++++++++++++ > > > .../Library/SmmRelocationLib/SmmRelocationLib.inf | 61 +++ > > > .../SmmRelocationLib/SmramSaveStateConfig.c | 136 +++++ > > > .../SmmRelocationLib}/X64/Semaphore.c | 13 +- > > > .../SmmRelocationLib}/X64/SmmInit.nasm | 85 +++- > > > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 21 +- > > > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 10 +- > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 334 > > ++----------- > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 103 +--- > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 4 - > > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMpPerf.h | 2 +- > > > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 69 --- > > > UefiCpuPkg/UefiCpuPkg.dec | 3 + > > > UefiCpuPkg/UefiCpuPkg.dsc | 2 + > > > UefiPayloadPkg/UefiPayloadPkg.dsc | 2 + > > > 48 files changed, 2578 insertions(+), 796 deletions(-) > > > copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> > > OvmfPkg/Library/SmmRelocationLib}/Ia32/Semaphore.c (71%) > > > copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> > > OvmfPkg/Library/SmmRelocationLib}/Ia32/SmmInit.nasm (47%) > > > create mode 100644 > > OvmfPkg/Library/SmmRelocationLib/InternalSmmRelocationLib.h > > > create mode 100644 > > OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.c > > > create mode 100644 > > OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.inf > > > create mode 100644 > > OvmfPkg/Library/SmmRelocationLib/SmramSaveStateConfig.c > > > copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> > > OvmfPkg/Library/SmmRelocationLib}/X64/Semaphore.c (78%) > > > copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> > > OvmfPkg/Library/SmmRelocationLib}/X64/SmmInit.nasm (59%) > > > create mode 100644 OvmfPkg/PlatformPei/SmmRelocation.c > > > create mode 100644 UefiCpuPkg/Include/Library/SmmRelocationLib.h > > > create mode 100644 > > UefiCpuPkg/Library/SmmRelocationLib/AmdSmmRelocationLib.inf > > > create mode 100644 > > UefiCpuPkg/Library/SmmRelocationLib/AmdSmramSaveStateConfig.c > > > rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> > > Library/SmmRelocationLib}/Ia32/Semaphore.c (71%) > > > rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> > > Library/SmmRelocationLib}/Ia32/SmmInit.nasm (47%) > > > create mode 100644 > > UefiCpuPkg/Library/SmmRelocationLib/InternalSmmRelocationLib.h > > > create mode 100644 > > UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.c > > > create mode 100644 > > UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.inf > > > create mode 100644 > > UefiCpuPkg/Library/SmmRelocationLib/SmramSaveStateConfig.c > > > rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> > > Library/SmmRelocationLib}/X64/Semaphore.c (78%) > > > rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> > > Library/SmmRelocationLib}/X64/SmmInit.nasm (59%) > > > > > > -- > > > 2.16.2.windows.1 > > > > > > > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118748): https://edk2.groups.io/g/devel/message/118748 Mute This Topic: https://groups.io/mt/105997310/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-