From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 86DC07803E6 for ; Mon, 11 Dec 2023 14:44:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=s2rQf6irjnWEPXuPdmis7A4KKCAGZ04h4XzdSIWax0E=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1702305868; v=1; b=Owq0+Ulk4+RCUglpVnkWrjzO7gYLhdaLHvj2FnezwNNcJCulXsEkrStDoPdCpfoJo668HmB8 UwaKEKR3X92Tqa0l4K+qxtHDbPlKcdod9Vvvl071+YgJPnf4eg+sy1lLfazkHU/TgYT0PMbs1mk 4kBTtZfp4GMmNOlaceZ8Vrms= X-Received: by 127.0.0.2 with SMTP id H40OYY7687511xfKh4rJ4zyf; Mon, 11 Dec 2023 06:44:28 -0800 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.9945.1702305867548256322 for ; Mon, 11 Dec 2023 06:44:27 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D6A1A61331 for ; Mon, 11 Dec 2023 14:44:26 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C6C0C433AD for ; Mon, 11 Dec 2023 14:44:26 +0000 (UTC) X-Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50bf82f4409so4432628e87.0 for ; Mon, 11 Dec 2023 06:44:26 -0800 (PST) X-Gm-Message-State: zXd1f2hv6tLTjNL8IJXS238nx7686176AA= X-Google-Smtp-Source: AGHT+IE8VbLpzRkgDqQIkS6RsxWt4GMrmZW75a6aKyV7AIExdsYzHVnRLRz2iUw9zeMVc69dXImQJAi8MuRhwUSpQHE= X-Received: by 2002:a19:914b:0:b0:50b:e47f:e971 with SMTP id y11-20020a19914b000000b0050be47fe971mr2393783lfj.24.1702305864633; Mon, 11 Dec 2023 06:44:24 -0800 (PST) MIME-Version: 1.0 References: <20231211104024.185070-1-ardb@google.com> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 11 Dec 2023 15:44:13 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v3] ArmVirt: Allow memory attributes protocol to be disabled To: Laszlo Ersek Cc: Gerd Hoffmann , Ard Biesheuvel , devel@edk2.groups.io, Oliver Steffen , Alexander Graf , Oliver Smith-Denny , Taylor Beebe , Peter Jones , Leif Lindholm Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Owq0+Ulk; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, 11 Dec 2023 at 15:33, Laszlo Ersek wrote: > > On 12/11/23 11:55, Gerd Hoffmann wrote: > >> + // > >> + // Work around shim's terminally broken use of the EFI memory attributes > >> + // protocol, by uninstalling it if requested on the QEMU command line. > >> + // > >> + // E.g., > >> + // -fw_cfg opt/org.tianocore/UninstallMemAttrProtocol,string=y > >> + // > >> + // This is only needed on the first boot, when fbaa64.efi is being invoked to > >> + // set the boot order variables. Subsequent boots involving GRUB are not > >> + // affected. > >> + // > > (1) I think this last paragraph of the comment no longer applies; is > that right? We don't restrict the proto masking to first boot any longer > (i.e., in v3). > Indeed. > >> + Uninstall = FixedPcdGetBool (PcdUninstallMemAttrProtocol); > >> + QemuFwCfgParseBool ("opt/org.tianocore/UninstallMemAttrProtocol", &Uninstall); > >> + if (Uninstall) { > >> + UninstallEfiMemoryAttributesProtocol (); > >> + } > > > > Can we please have a log message here, for both uninstall and > > keep-installed cases? > > Good idea! > > > > > Otherwise the patch looks good to me. > > With those two updates (assuming I'm right about (1)): > > Reviewed-by: Laszlo Ersek > Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112302): https://edk2.groups.io/g/devel/message/112302 Mute This Topic: https://groups.io/mt/103106391/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-