From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.35454.1653908943187355705 for ; Mon, 30 May 2022 04:09:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=meWs89XF; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 99C7461147 for ; Mon, 30 May 2022 11:09:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F3A0C36AE5 for ; Mon, 30 May 2022 11:09:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653908942; bh=RIWCWRWD/zOzmfpZufG8/jr4WPH7I2zrfQjYklLEP+4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=meWs89XFe3FvvDM/E7oRDWAyMW8124IZKD2IfEUaHIORioQe8mTJ/J+7wvaNUVL5I aDSFz0srK/x1zjQ+V0D5zyQunCch+S8cOWS7pSldN6JOAkjQD863ffjdem4tLi2ruV iMMdJXSKh5dM6ZCdACiSv9AdMCtbQL4Xl5iRkbQBGb4BZrZ/BmdL01hEGGdFj/Vh1X FxFxexpucYBnoumPN0yTnc/8KFE7l33Q1vDmC5rUTr2MqCnfKQmPC76QNXv3OeqnEM ZSB+WaJ1XuuawkyFYSsSdtcdXQhBqWP0VAcbLY9QllhdAGgyCOWEX3x1UEkTOOXulb v8f4uqj1iDOzg== Received: by mail-ot1-f49.google.com with SMTP id l10-20020a9d7a8a000000b0060b151de434so7494417otn.2 for ; Mon, 30 May 2022 04:09:01 -0700 (PDT) X-Gm-Message-State: AOAM530nsJNDTj+2BrmVZx8lJg/YMr2oyZvHzoQruQ8rQ5UQ3dE4al8I jDqOaFn2yJ2gfrMRhccA7ZL4jTQtiI5VPXpmbEs= X-Google-Smtp-Source: ABdhPJyeE2hAOh4od9I9qGZPjpbUl109jiKyVL5MbCWT94Xiw/jZ+zcZr2miZStELbHxVtF9LdJ5xG3pwPVkWRZLKt8= X-Received: by 2002:a05:6830:9c2:b0:606:1e0a:cc8d with SMTP id y2-20020a05683009c200b006061e0acc8dmr20674208ott.265.1653908941186; Mon, 30 May 2022 04:09:01 -0700 (PDT) MIME-Version: 1.0 References: <20220530092255.279983-1-kraxel@redhat.com> <20220530102106.p3zh5ox5xxc66z6f@sirius.home.kraxel.org> In-Reply-To: <20220530102106.p3zh5ox5xxc66z6f@sirius.home.kraxel.org> From: "Ard Biesheuvel" Date: Mon, 30 May 2022 13:08:50 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] OvmfPkg/VirtioGpuDxe: replace struct copy with CopyMem call To: Gerd Hoffmann Cc: edk2-devel-groups-io , Ard Biesheuvel , Oliver Steffen , Jiewen Yao , Jordan Justen , Pawel Polawski , Rebecca Cran Content-Type: text/plain; charset="UTF-8" On Mon, 30 May 2022 at 12:21, Gerd Hoffmann wrote: > > On Mon, May 30, 2022 at 11:32:03AM +0200, Ard Biesheuvel wrote: > > Hi Gerd, > > > > On Mon, 30 May 2022 at 11:23, Gerd Hoffmann wrote: > > > > > > Buildfix for `-t CLANG38 -b NOOPT -p OvmfPkg/OvmfPkgX64.dsc`. > > > > > > Fixes: 5f6ecaa398ba ("OvmfPkg/VirtioGpuDxe: use GopQueryMode in GopSetMode") > > > Reported-by: Rebecca Cran > > > Signed-off-by: Gerd Hoffmann > > > --- > > > OvmfPkg/VirtioGpuDxe/Gop.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/OvmfPkg/VirtioGpuDxe/Gop.c b/OvmfPkg/VirtioGpuDxe/Gop.c > > > index 70a81c10c8b5..18b29e5a23d2 100644 > > > --- a/OvmfPkg/VirtioGpuDxe/Gop.c > > > +++ b/OvmfPkg/VirtioGpuDxe/Gop.c > > > @@ -509,7 +509,7 @@ GopSetMode ( > > > // Populate Mode and ModeInfo (mutable fields only). > > > // > > > VgpuGop->GopMode.Mode = ModeNumber; > > > - VgpuGop->GopModeInfo = *GopModeInfo; > > > + CopyMem(&VgpuGop->GopModeInfo, GopModeInfo, sizeof(*GopModeInfo)); > > > > Mind if I change this to > > > > CopyMem (&VgpuGop->GopModeInfo, GopModeInfo, sizeof VgpuGop->GopModeInfo); > > No (that's what running uncrustify would have done I guess?) > Not sure - I don't know how to run that. But the missing space before ( caught my eye Merged as #2925 Thanks,