From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B7FC7941BAB for ; Mon, 30 Oct 2023 22:36:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=HACjQM1lGPB5aRVzzkYPU5ryRa2GVPZGyLnrSvKULHI=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1698705394; v=1; b=cb+KnMx7bUK8Y/6icgJuYb7xrKgNKfyfWamjGb9feuJXFbv2oMyMk5Ewjun7ilPTiP1KCeLa ifO8Fs2ehwiAqFSlalLoggfEPq0NwCupbJ1C7W88DuXb+aC52aUdjAEHAN57OjQjDnDV4l8TQsM yX2CudCI5d5wM9N1Q6EzZil8= X-Received: by 127.0.0.2 with SMTP id 1xp9YY7687511xJYpmwDJ5f2; Mon, 30 Oct 2023 15:36:34 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.173080.1698705393795730104 for ; Mon, 30 Oct 2023 15:36:33 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2679B60A5B for ; Mon, 30 Oct 2023 22:36:33 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CCF7C43391 for ; Mon, 30 Oct 2023 22:36:32 +0000 (UTC) X-Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-507b9408c61so6993733e87.0 for ; Mon, 30 Oct 2023 15:36:32 -0700 (PDT) X-Gm-Message-State: uVj02G4luIqBaVcRtWUJd54qx7686176AA= X-Google-Smtp-Source: AGHT+IH7sqnxoA28nFX2WU+NqPonOheQUdcOISCrCL0VPLA1xxEbNoCS0JMeI96hd+RpsaXoXlhRhxUYSsahUhyfaZ4= X-Received: by 2002:ac2:546e:0:b0:507:9855:bc68 with SMTP id e14-20020ac2546e000000b005079855bc68mr7900877lfn.37.1698705390671; Mon, 30 Oct 2023 15:36:30 -0700 (PDT) MIME-Version: 1.0 References: <20231030203112.736-1-mikuback@linux.microsoft.com> <20231030203112.736-5-mikuback@linux.microsoft.com> In-Reply-To: <20231030203112.736-5-mikuback@linux.microsoft.com> From: "Ard Biesheuvel" Date: Mon, 30 Oct 2023 23:36:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v3 4/4] ArmVirtPkg: Add varpolicy shell command To: mikuback@linux.microsoft.com Cc: devel@edk2.groups.io, Ard Biesheuvel , Gerd Hoffmann , Julien Grall , Laszlo Ersek , Leif Lindholm , Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=cb+KnMx7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, 30 Oct 2023 at 21:31, wrote: > > From: Michael Kubacki > > Adds the varpolicy EFI shell command to all DSC files that > currently include other dynamic shell commands from ShellPkg. > > This command allows variable policies to be dumped in the EFI > shell for convenient auditing and debug. > > Use the command in the EFI shell as follows: > > - `"varpolicy"` dumps platform variables > - `"varpolicy -?"` shows help text > - `"varpolicy -b"` pages output as expected > - `"varpolicy -s"` shows accurate variable statistic information > - `"varpolicy -p"` shows accurate UEFI variable policy information > - `"varpolicy-v -b"` dumps all information including variable data hex dump > > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc: Julien Grall > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Sami Mujawar > Signed-off-by: Michael Kubacki Reviewed-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirt.dsc.inc | 4 ++++ > ArmVirtPkg/ArmVirtCloudHv.fdf | 1 + > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 + > ArmVirtPkg/ArmVirtXen.fdf | 1 + > 4 files changed, 7 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 4ed86b979e1a..fe6488ee9910 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -393,6 +393,10 @@ [Components.common] > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > } > + ShellPkg/DynamicCommand/VariablePolicyDynamicCommand/VariablePolicyDynamicCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf { > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > diff --git a/ArmVirtPkg/ArmVirtCloudHv.fdf b/ArmVirtPkg/ArmVirtCloudHv.fdf > index a5f172d79bfc..56d1ea6e8c1b 100644 > --- a/ArmVirtPkg/ArmVirtCloudHv.fdf > +++ b/ArmVirtPkg/ArmVirtCloudHv.fdf > @@ -169,6 +169,7 @@ [FV.FvMain] > INF ShellPkg/Application/Shell/Shell.inf > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf > + INF ShellPkg/DynamicCommand/VariablePolicyDynamicCommand/VariablePolicyDynamicCommand.inf > INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf > > # > diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > index 2894bc853a46..9b3e37d5c998 100644 > --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > @@ -103,6 +103,7 @@ [FV.FvMain] > INF ShellPkg/Application/Shell/Shell.inf > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf > + INF ShellPkg/DynamicCommand/VariablePolicyDynamicCommand/VariablePolicyDynamicCommand.inf > INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf > > # > diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf > index 770fbf7289be..ea835551b375 100644 > --- a/ArmVirtPkg/ArmVirtXen.fdf > +++ b/ArmVirtPkg/ArmVirtXen.fdf > @@ -180,6 +180,7 @@ [FV.FvMain] > INF ShellPkg/Application/Shell/Shell.inf > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf > + INF ShellPkg/DynamicCommand/VariablePolicyDynamicCommand/VariablePolicyDynamicCommand.inf > INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf > > # > -- > 2.42.0.windows.2 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110347): https://edk2.groups.io/g/devel/message/110347 Mute This Topic: https://groups.io/mt/102284388/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-