From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.9268.1675427394609732388 for ; Fri, 03 Feb 2023 04:29:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FlLp4egN; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 04078B82AA1 for ; Fri, 3 Feb 2023 12:29:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE462C433D2 for ; Fri, 3 Feb 2023 12:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675427391; bh=UvZ5TZYiJAJE7WGn/7YmSBzVxS9dAtoIPqKo78xSh90=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FlLp4egNGXCpi7mCecnJ4/5r9iJMfDHUaBZre4kMUQXND4rYSMRdYwAQBnYrdkpRD sFHA1bu2hDP/I837NfvawZe7CyC0TURimPj6+Tcdp9vOWuvUWIhBeEJdGcrblGtsZ0 RQDvONW6k72S2oYOoj5EmFQ58v2GdlbyLzUEjFnB85/vvS8ijyzEngLCeVd4GmW4EL d11GqFC0ayW2DDQgLkxZkZLQWTd29U0AoVx+tLxg7tg3jiKRdoH9+swNjvDEKmyxT6 CXaB48PqxcegU9rPos9BNc+hzw5c7kcn9SDi8HpI9mQRBu9QEl+k3JdQ3+fkkuu1Dd 2NbRDa8S5TH3w== Received: by mail-lf1-f50.google.com with SMTP id w11so7528270lfu.11 for ; Fri, 03 Feb 2023 04:29:51 -0800 (PST) X-Gm-Message-State: AO0yUKVWpBqnCbhZOYmC04b/V95f2G47ggULWr/OuHBp9mpJjqgr4WEX OSYL6Yycb5hy8NQbXe5dkWpJ9vyRUB1KO8DHhT0= X-Google-Smtp-Source: AK7set9n1mZKkpwtvW0INLy+XNEhg0y+qEom3+IpkOCwwmXa/R3cAlkkqmgmaagSniQrQxh5tM0ihmeUrXEDCBN3OZA= X-Received: by 2002:ac2:5b9c:0:b0:4d8:767b:8b6b with SMTP id o28-20020ac25b9c000000b004d8767b8b6bmr1927965lfn.63.1675427389711; Fri, 03 Feb 2023 04:29:49 -0800 (PST) MIME-Version: 1.0 References: <20230128191807.2080547-1-sunilvl@ventanamicro.com> <173E8F29CD0D02D8.27165@groups.io> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 3 Feb 2023 13:29:38 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 11/20] ArmVirtPkg/PlatformHasAcpiDtDxe: Move to OvmfPkg To: Sunil V L Cc: devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann Content-Type: text/plain; charset="UTF-8" On Mon, 30 Jan 2023 at 14:44, Sunil V L wrote: > > Hi Ard, Leif, > > Do you see any issues with this migration? > > Thanks! > Sunil > > On Sun, Jan 29, 2023 at 12:47:58AM +0530, Sunil V L via groups.io wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 > > > > This module is required by other architectures like RISC-V. > > Hence, move this to OvmfPkg. > > > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Gerd Hoffmann > > Signed-off-by: Sunil V L Acked-by: Ard Biesheuvel > > --- > > ArmVirtPkg/ArmVirtPkg.dec | 9 --------- > > OvmfPkg/OvmfPkg.dec | 7 +++++++ > > {ArmVirtPkg => OvmfPkg}/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf | 3 +-- > > {ArmVirtPkg => OvmfPkg}/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.c | 0 > > 4 files changed, 8 insertions(+), 11 deletions(-) > > > > diff --git a/ArmVirtPkg/ArmVirtPkg.dec b/ArmVirtPkg/ArmVirtPkg.dec > > index 89d21ec3a364..4645c91a8375 100644 > > --- a/ArmVirtPkg/ArmVirtPkg.dec > > +++ b/ArmVirtPkg/ArmVirtPkg.dec > > @@ -34,8 +34,6 @@ [Guids.common] > > gEarly16550UartBaseAddressGuid = { 0xea67ca3e, 0x1f54, 0x436b, { 0x97, 0x88, 0xd4, 0xeb, 0x29, 0xc3, 0x42, 0x67 } } > > gArmVirtSystemMemorySizeGuid = { 0x504eccb9, 0x1bf0, 0x4420, { 0x86, 0x5d, 0xdc, 0x66, 0x06, 0xd4, 0x13, 0xbf } } > > > > - gArmVirtVariableGuid = { 0x50bea1e5, 0xa2c5, 0x46e9, { 0x9b, 0x3a, 0x59, 0x59, 0x65, 0x16, 0xb0, 0x0a } } > > - > > [PcdsFeatureFlag] > > # > > # Feature Flag PCD that defines whether TPM2 support is enabled > > @@ -69,10 +67,3 @@ [PcdsFixedAtBuild, PcdsPatchableInModule] > > # Cloud Hypervisor has no other way to pass Rsdp address to the guest except use a PCD. > > # > > gArmVirtTokenSpaceGuid.PcdCloudHvAcpiRsdpBaseAddress|0x0|UINT64|0x00000005 > > - > > -[PcdsDynamic] > > - # > > - # Whether to force disable ACPI, regardless of the fw_cfg settings > > - # exposed by QEMU > > - # > > - gArmVirtTokenSpaceGuid.PcdForceNoAcpi|0x0|BOOLEAN|0x00000003 > > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > > index a22eb246c625..e52602db5b79 100644 > > --- a/OvmfPkg/OvmfPkg.dec > > +++ b/OvmfPkg/OvmfPkg.dec > > @@ -157,6 +157,7 @@ [Guids] > > gVMMBootOrderGuid = {0x668f4529, 0x63d0, 0x4bb5, {0xb6, 0x5d, 0x6f, 0xbb, 0x9d, 0x36, 0xa4, 0x4a}} > > gUefiOvmfPkgTdxAcpiHobGuid = {0x6a0c5870, 0xd4ed, 0x44f4, {0xa1, 0x35, 0xdd, 0x23, 0x8b, 0x6f, 0x0c, 0x8d}} > > gEfiNonCcFvGuid = {0xae047c6d, 0xbce9, 0x426c, {0xae, 0x03, 0xa6, 0x8e, 0x3b, 0x8a, 0x04, 0x88}} > > + gOvmfVariableGuid = {0x50bea1e5, 0xa2c5, 0x46e9, {0x9b, 0x3a, 0x59, 0x59, 0x65, 0x16, 0xb0, 0x0a}} > > > > [Ppis] > > # PPI whose presence in the PPI database signals that the TPM base address > > @@ -463,6 +464,12 @@ [PcdsDynamic, PcdsDynamicEx] > > # 2 - set by GOP Driver. > > gUefiOvmfPkgTokenSpaceGuid.PcdVideoResolutionSource|0|UINT8|0x64 > > > > + # > > + # Whether to force disable ACPI, regardless of the fw_cfg settings > > + # exposed by QEMU > > + # > > + gUefiOvmfPkgTokenSpaceGuid.PcdForceNoAcpi|0x0|BOOLEAN|0x69 > > + > > [PcdsFeatureFlag] > > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE|BOOLEAN|0x1c > > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|FALSE|BOOLEAN|0x1d > > diff --git a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf b/OvmfPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > > similarity index 89% > > rename from ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > > rename to OvmfPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > > index e900aa992661..85873f73b2eb 100644 > > --- a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > > +++ b/OvmfPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > > @@ -19,7 +19,6 @@ [Sources] > > PlatformHasAcpiDtDxe.c > > > > [Packages] > > - ArmVirtPkg/ArmVirtPkg.dec > > EmbeddedPkg/EmbeddedPkg.dec > > MdeModulePkg/MdeModulePkg.dec > > MdePkg/MdePkg.dec > > @@ -38,7 +37,7 @@ [Guids] > > gEdkiiPlatformHasDeviceTreeGuid ## SOMETIMES_PRODUCES ## PROTOCOL > > > > [Pcd] > > - gArmVirtTokenSpaceGuid.PcdForceNoAcpi > > + gUefiOvmfPkgTokenSpaceGuid.PcdForceNoAcpi > > > > [Depex] > > gEfiVariableArchProtocolGuid > > diff --git a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.c b/OvmfPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.c > > similarity index 100% > > rename from ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.c > > rename to OvmfPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.c > > -- > > 2.38.0 > > > > > > > > > > > >