From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Corvin Köhne" <corvink@freebsd.org>
Cc: devel@edk2.groups.io, Laszlo Ersek <lersek@redhat.com>,
Rebecca Cran <rebecca@bsdio.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/Bhyve: use a proper PCI IO range
Date: Thu, 7 Dec 2023 17:34:12 +0100 [thread overview]
Message-ID: <CAMj1kXE9bX80OL2ZyLLhNRy5Di67o+d0iwW7jyBgPyMJSUtaiQ@mail.gmail.com> (raw)
In-Reply-To: <20231120072453.10433-1-corvink@FreeBSD.org>
On Mon, 20 Nov 2023 at 08:25, Corvin Köhne <corvink@freebsd.org> wrote:
>
> Bhyve uses an io port range of [ 0x2000, 0x10000 ] [1]. At the moment,
> EDKII is using a subset of this range [ 0xC000, 0x10000 ] [2]. Even
> though the EDKII range doesn't exceed the bhyve range, it's causing
> issues on some guests like OpenBSD [3]. We don't know why it's causing
> issues yet. However, using the same IO port range in EDKII fixes the
> issue and is a good idea anyway.
>
> [1] https://github.com/freebsd/freebsd-src/blob/82ea0132c8b17a7a6067c8a36c6434e587ede6de/usr.sbin/bhyve/pci_emul.c#L133-L134
> [2] https://github.com/tianocore/edk2/blob/fb044b7fe893a4545995bfe2701fd38e593355d9/OvmfPkg/Bhyve/PlatformPei/Platform.c#L156-L157
> [3] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274389
>
> Signed-off-by: Corvin Köhne <corvink@FreeBSD.org>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
Queued up as #5121 - thanks.
> ---
> OvmfPkg/Bhyve/PlatformPei/Platform.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/OvmfPkg/Bhyve/PlatformPei/Platform.c b/OvmfPkg/Bhyve/PlatformPei/Platform.c
> index f6d9a9038e12..bd1b22a9476e 100644
> --- a/OvmfPkg/Bhyve/PlatformPei/Platform.c
> +++ b/OvmfPkg/Bhyve/PlatformPei/Platform.c
> @@ -153,8 +153,8 @@ MemMapInitialization (
> UINT64 PciIoSize;
> RETURN_STATUS PcdStatus;
>
> - PciIoBase = 0xC000;
> - PciIoSize = 0x4000;
> + PciIoBase = 0x2000;
> + PciIoSize = 0xE000;
>
> //
> // Create Memory Type Information HOB
> --
> 2.42.0
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112203): https://edk2.groups.io/g/devel/message/112203
Mute This Topic: https://groups.io/mt/102703362/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-12-07 16:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 7:24 [edk2-devel] [PATCH v2 1/1] OvmfPkg/Bhyve: use a proper PCI IO range Corvin Köhne
2023-12-07 16:34 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXE9bX80OL2ZyLLhNRy5Di67o+d0iwW7jyBgPyMJSUtaiQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox