From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1545EAC182B for ; Thu, 3 Aug 2023 21:25:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WkyBfyuJQ7ZGINqp+6iXdw5+DwHw4TdfICihdpRmwOk=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1691097956; v=1; b=sG2HfWdCDqHI3aoHCvwHaNP7RREO/VfEOYm24ygqpLnoeFrTA14NArP1fPp7Sb6T8XNKliOX 3jDh7+YmZvBVbx87wk8lTN9KhM/Q+uMH4apuPJYAQ5mZrP33Isahyxgi/Xv24hPqo+6BnM0rsz9 i1YwlzY35VAtHFrxLMog22/Q= X-Received: by 127.0.0.2 with SMTP id Pq4fYY7687511xpBWtFSDwCt; Thu, 03 Aug 2023 14:25:56 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.5926.1691097955602172920 for ; Thu, 03 Aug 2023 14:25:55 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E71C261EA4 for ; Thu, 3 Aug 2023 21:25:54 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B2D3C433C7 for ; Thu, 3 Aug 2023 21:25:54 +0000 (UTC) X-Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4fe48d0ab0fso2399474e87.1 for ; Thu, 03 Aug 2023 14:25:54 -0700 (PDT) X-Gm-Message-State: mpDCRT3yJphBkcB3xMdonwQ3x7686176AA= X-Google-Smtp-Source: APBJJlFFN/1pJ+jWuJvDiowy9CkdToX70tNyyY8zUzYe6zZwo1yNVoWXMJuzquDXLBp4a3lZhQ58upkENbKtqndz64g= X-Received: by 2002:a19:2d04:0:b0:4f8:7568:e94b with SMTP id k4-20020a192d04000000b004f87568e94bmr7643437lfj.56.1691097952340; Thu, 03 Aug 2023 14:25:52 -0700 (PDT) MIME-Version: 1.0 References: <20230803114425.318246-1-osteffen@redhat.com> <001ed4ff-89fa-c7bf-3a29-305a28b94b41@linux.microsoft.com> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 3 Aug 2023 23:25:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" , "osteffen@redhat.com" , "Feng, Bob C" , Gerd Hoffmann , "Yao, Jiewen" , "Justen, Jordan L" , "Gao, Liming" , Rebecca Cran , Sean Brogan , "Chen, Christine" , Laszlo Ersek Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=sG2HfWdC; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D wrote: > > Hi Ard, > > This is the email with the analysis and the flag > setting required for SMP to work with SMM enabled for > IA32/X64 QEMU. > > https://edk2.groups.io/g/devel/message/102364 > > > I tried latest version of QEMU earlier in the Summer > and did not see any improvements. > Ah thanks, I had forgotten all about that rabbit hole you went down :-) So let's respin this with -smp 4 --accel=tcg,thread=single. It is still an improvement to exercise the MP code even if it doesn't strictly execute concurrently. (It will be very hard to catch/reproduce true concurrency issues in TCG anyway) Oliver, mind spinning a v2? Thanks, > > -----Original Message----- > > From: Ard Biesheuvel > > Sent: Thursday, August 3, 2023 9:54 AM > > To: devel@edk2.groups.io; mikuback@linux.microsoft.com > > Cc: osteffen@redhat.com; Feng, Bob C ; Gerd > > Hoffmann ; Yao, Jiewen ; > > Justen, Jordan L ; Gao, Liming > > ; Kinney, Michael D > > ; Rebecca Cran ; Sean > > Brogan ; Chen, Christine > > ; Laszlo Ersek > > Subject: Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP > > in tests > > > > On Thu, 3 Aug 2023 at 16:37, Michael Kubacki > > wrote: > > > > > > For the series. > > > > > > Reviewed-by: Michael Kubacki > > > > > > > Thanks > > > > I've pushed this to the CI but Platform_CI OVMF_IA32X64_FULL_DEBUG > > keeps timing out for me > > > > https://github.com/tianocore/edk2/pull/4718 > > > > Might it help if we restrict SMP to a subset of the builds? And would > > it help if we added "--accel=tcg,thread=multi" ? > > > > > > > > > On 8/3/2023 7:44 AM, Oliver Steffen wrote: > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 > > > > PR: https://github.com/tianocore/edk2/pull/4711 > > > > > > > > This series switches the OVMF CI jobs on Windows to a recent Qemu > > > > version and re-enables SMP in the Qemu "Run to shell" CI jobs. > > > > The Qemu tests run a little bit slower in SMP mode and sometimes > > > > hit the time limit of 2 minutes, thus this limit is increased to 4 > > > > minutes. > > > > > > > > Together with 81cb0371f9db ("CI: Use latest image for Linux jobs > > (Qemu > > > > 8, gcc 12)" this series is sufficient to close Bug 4324. > > > > > > > > > > > > Gerd Hoffmann (1): > > > > OvmfPkg/PlatformCI: Boot OVMF in SMP mode. > > > > > > > > Oliver Steffen (3): > > > > OvmfPkg/PlatformCI: Use recent Qemu on Windows > > > > OvmfPkg/PlatformCI VS2019: Disable workaround for cpuhp bugfix > > > > CI: Increase time limit of "Run to shell" task to 4 minutes > > > > > > > > .../templates/platform-build-run-steps.yml | 2 +- > > > > .../PlatformCI/.azurepipelines/Windows-VS2019.yml | 4 ++-- > > > > OvmfPkg/PlatformCI/PlatformBuildLib.py | 13 +-------- > > ---- > > > > 3 files changed, 4 insertions(+), 15 deletions(-) > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107557): https://edk2.groups.io/g/devel/message/107557 Mute This Topic: https://groups.io/mt/100524063/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-