From: "Ard Biesheuvel" <ardb@kernel.org>
To: edk2-devel-groups-io <devel@edk2.groups.io>,
Abner Chang <abner.chang@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>,
Sunil V L <sunilvl@ventanamicro.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Leif Lindholm <leif@nuviainc.com>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf
Date: Sat, 29 Jan 2022 18:16:52 +0100 [thread overview]
Message-ID: <CAMj1kXE=rJu16SG_whpabnCEr8UY4iHZ3-Yg3Wd3PXX6oLrqAw@mail.gmail.com> (raw)
In-Reply-To: <20220129160348.3247-3-abner.chang@hpe.com>
On Sat, 29 Jan 2022 at 18:05, Abner Chang <abner.chang@hpe.com> wrote:
>
> Remove the dependency with ArmVirtPkg and add RISCV64 in VALID_ARCHITECTURES.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> ---
> .../BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> index 33568f568f..0383a37cbf 100644
> --- a/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> +++ b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> @@ -21,15 +21,15 @@
> CONSTRUCTOR = PciExpressLibInitialize
>
> #
> -# VALID_ARCHITECTURES = ARM AARCH64
> +# VALID_ARCHITECTURES = ARM AARCH64 RISCV64
> #
>
I am going to fold the above hunk into patch #1, given that
> [Sources]
> PciExpressLib.c
>
> [Packages]
> - ArmVirtPkg/ArmVirtPkg.dec
> MdePkg/MdePkg.dec
> + OvmfPkg/OvmfPkg.dec
>
this change is unnecessary - either package reference is unnecessary
so I will just drop the reference to ArmVirtPkg/ArmVirtPkg.dec when
moving it.
> [LibraryClasses]
> BaseLib
> --
> 2.31.1
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#86214): https://edk2.groups.io/g/devel/message/86214
> Mute This Topic: https://groups.io/mt/88770183/5717338
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org]
> ------------
>
>
next prev parent reply other threads:[~2022-01-29 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 16:03 [PATCH v2 0/2] Migrate BaseCachingPciExpressLib Abner Chang
2022-01-29 16:03 ` [PATCH v2 1/2] OvmfPkg/BaseCachingPciExpressLib: " Abner Chang
2022-01-29 18:42 ` [edk2-devel] " Ard Biesheuvel
2022-01-29 16:03 ` [PATCH v2 2/2] OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf Abner Chang
2022-01-29 17:16 ` Ard Biesheuvel [this message]
2022-01-30 3:38 ` [edk2-devel] " Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXE=rJu16SG_whpabnCEr8UY4iHZ3-Yg3Wd3PXX6oLrqAw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox