From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io, dun.tan@intel.com,
Ray Ni <ray.ni@intel.com>,
Michael Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [Patch V8 00/14] Subject: [Patch V8 00/14] Use CpuPageTableLib to create and update smm page table
Date: Thu, 21 Sep 2023 09:05:53 +0000 [thread overview]
Message-ID: <CAMj1kXEA6Lwz32YOdvD+rHjDGwwX96Vxu43x6ChCEJTvZe_EmQ@mail.gmail.com> (raw)
In-Reply-To: <20230629100847.1132-1-dun.tan@intel.com>
On Thu, 29 Jun 2023 at 10:09, duntan <dun.tan@intel.com> wrote:
>
> In the V8 patch set:
> In 'OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry', I refined the commit message and added comments in the code around the areas being changed to explain this code change.
>
> Only resend the changed patch in OvmfPkg. The patch set has been reviewed-by
>
> Dun Tan (14):
> OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry
> MdeModulePkg: Remove other attribute protection in UnsetGuardPage
> UefiCpuPkg: Use CpuPageTableLib to convert SMM paging attribute.
This patch breaks SMM on IA32.
!!!! IA32 Exception Type - 0E(#PF - Page-Fault) CPU Apic ID - 00000000 !!!!
ExceptionData - 00000008 I:0 R:1 U:0 W:0 P:0 PK:0 SS:0 SGX:0
EIP - 07FF97A6, CS - 00000008, EFLAGS - 00000046
EAX - 07FF2400, ECX - 07FC5140, EDX - 06AD7120, EBX - FFFFFFFF
ESP - 07FCCDB4, EBP - 07FCCF4C, ESI - 00000000, EDI - 00000000
DS - 00000020, ES - 00000020, FS - 00000020, GS - 00000020, SS - 00000020
CR0 - 8001003B, CR2 - 06AD713C, CR3 - 07FA5000, CR4 - 00000668
DR0 - 00000000, DR1 - 00000000, DR2 - 00000000, DR3 - 00000000
DR6 - FFFF0FF0, DR7 - 00000400
GDTR - 07FC3000 0000004F, IDTR - 07FC6000 000000FF
LDTR - 00000000, TR - 00000040
FXSAVE_STATE - 07FC7D60
qemu: terminating on signal 2
This appears to be a result from the following code in
UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c:SmmInitPageTable()
@@ -31,7 +31,7 @@ SmmInitPageTable (
InitializeSpinLock (mPFLock);
mPhysicalAddressBits = 32;
mPagingMode = PagingPae;
which seems to be the wrong paging mode. However, 'Paging32bit' is not
actually supported by the library so changing it results in an
ASSERT():
Patch page table start ...
ASSERT_RETURN_ERROR (Status = Unsupported)
ASSERT [PiSmmCpuDxeSmm]
/home/ardb/build/edk2/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c(537):
!(((INTN)(RETURN_STATUS)(Status)) < 0)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108937): https://edk2.groups.io/g/devel/message/108937
Mute This Topic: https://groups.io/mt/99847923/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-21 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 10:08 [Patch V8 00/14] Subject: [Patch V8 00/14] Use CpuPageTableLib to create and update smm page table duntan
2023-06-29 10:08 ` [Patch V8 01/14] OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry duntan
2023-09-21 9:05 ` Ard Biesheuvel [this message]
2023-09-21 10:09 ` [edk2-devel] [Patch V8 00/14] Subject: [Patch V8 00/14] Use CpuPageTableLib to create and update smm page table duntan
2023-09-21 11:42 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXEA6Lwz32YOdvD+rHjDGwwX96Vxu43x6ChCEJTvZe_EmQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox