From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.17746.1683726679259954932 for ; Wed, 10 May 2023 06:51:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WrvQz7OV; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ADC0C630F1 for ; Wed, 10 May 2023 13:51:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22937C4339E for ; Wed, 10 May 2023 13:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683726678; bh=6sUBzwj1XwIv8n+dl4tv8cnLJX+6F3G/3a58nGWIC4A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WrvQz7OVNOwrjP1O4A4K6386mfhIkrlvJp3Ju1uh6gzebo7x+O7uud4wfIuiEHMrX LfwQqvUtU12vHzenvhp39h+UZwUIlhFd9528mR9uDSeXVfWDPZme9QktuGCKHdU1FR lA5DvFusZs1mX+FUg+MW21chz5uKK8/mAk4U6q8sujpB7zZKx/DbNqNPrwqcxyJCqJ FqQ+r1/Yk2YNcEhgUk2vhQybOcutzfLNYM/zbAOMzSsxSXVY98Hu/NBcpbTRe30vJZ eRUxyZLDsNIDj50hyOynslZMUl7mZyo7o28vMot9mzCJfGzNtm7cJfaQpC9nbfodPl qTOrAjf03bGoA== Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-4effb818c37so8171385e87.3 for ; Wed, 10 May 2023 06:51:18 -0700 (PDT) X-Gm-Message-State: AC+VfDySQkDLu1uCkSJRYtDFLpR6Ze4abOqDycnRToQeFkPgFscBJmnC SYsUE8taJIdmFroLR3sJRwx5L6oAyoWaApkL2oo= X-Google-Smtp-Source: ACHHUZ6LNbIJXLv3eouMOLLrF4LIaldipn1aEiMkLMFaGccXdpeCLgYYKyyI5CG6WCc7hfa2/dcrWXnI4FacQYqNRZI= X-Received: by 2002:ac2:5607:0:b0:4f1:4796:af9d with SMTP id v7-20020ac25607000000b004f14796af9dmr1617558lfd.66.1683726676096; Wed, 10 May 2023 06:51:16 -0700 (PDT) MIME-Version: 1.0 References: <20230510123141.1880782-1-rebecca@bsdio.com> <3173f4a8-5079-ac73-7ce2-1802152a14f1@bsdio.com> In-Reply-To: <3173f4a8-5079-ac73-7ce2-1802152a14f1@bsdio.com> From: "Ard Biesheuvel" Date: Wed, 10 May 2023 15:51:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-stable202305 PATCH 1/1] BaseTools: Revert Set the CLANGDWARF OBJCOPY path in tools_def.template To: Rebecca Cran Cc: devel@edk2.groups.io, Liming Gao , Bob Feng , Yuwei Chen Content-Type: text/plain; charset="UTF-8" On Wed, 10 May 2023 at 14:46, Rebecca Cran wrote: > > On 5/10/23 06:37, Ard Biesheuvel wrote: > > On Wed, 10 May 2023 at 14:31, Rebecca Cran wrote: > >> This reverts commit 11f62f4cc09f16d265da1a737dabfd8ed65f8c00. > >> > >> While GCC uses objcopy for the OBJCOPY command, it's not needed for the > >> CLANGDWARF toolchain and can be left as echo. > >> > > Are you sure you want to change this for IA32 and X86 as well? I'm not > > sure what the significance is, I suppose it sets the debuglink on the > > copies of the dll files? > > Looking back to the tools_def.template from edk2-stable202302, we set > OBJCOPY_PATH for CLANG38 IA32 and X64, but not for CLANGPDB or CLANGDWARF. > > I was thinking it's safer to keep existing behavior for now. > Existing behavior of CLANGDWARF for X86 and IA32, right? Yeah that makes sense. Reviewed-by: Ard BIesheuvel