From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web10.6169.1675412908017900197
 for <devel@edk2.groups.io>;
 Fri, 03 Feb 2023 00:28:28 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LXSmDUpp;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id 8FA3A61E2C
	for <devel@edk2.groups.io>; Fri,  3 Feb 2023 08:28:27 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED71DC433EF
	for <devel@edk2.groups.io>; Fri,  3 Feb 2023 08:28:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1675412907;
	bh=FQPSgUMBkDRGihp649ktGFyq+PpfokLcdH8T8FufSqQ=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=LXSmDUppZoogL2H2oOQU2h0uKlyyZV1AWrFUeBiXW4wYIFOKB61pEvTWkO32lIybU
	 RVO8qplW0Zh9H4uHoPSzAzXJfEg2gXiDg+YkJIS33pJwwPXQM1HB6rLj1f+yKe6XO3
	 YObTM6mHsTqL+PBOdXKLjhbbh1Ygc1ABXir3C+fqJM/fZJTRvBEnV11ygJ1lcA5jcI
	 WJAzjO4A5TemOE9nykADxo188+v3Fyg3rabI7MOMUj0uvK/FSYa0CLxx9rxjK5beju
	 pRv3+25BgwHF/udy61xZAfgh8HfUccKEzJRx6n6bVvqEH3BHC0kpezi/wb29uxnNxS
	 nw7gsoldy8B1A==
Received: by mail-lf1-f48.google.com with SMTP id cf42so6782956lfb.1
        for <devel@edk2.groups.io>; Fri, 03 Feb 2023 00:28:26 -0800 (PST)
X-Gm-Message-State: AO0yUKV7GdwX9eaU4YimEVme50nOdxFQ8qGJkOwnjRtLlbuhabGJm/4y
	8OP7dMPeve+bnklDOEKi37eV377togBJ/DdJlYc=
X-Google-Smtp-Source: AK7set/9qwYUCrSloY3JTkM7pBcOWYIj1vY4UXc1gVZJ5/PXIMNwkZxEFhBUoky9eS9fO2FqMQKokvvqbH5l6+qhA0c=
X-Received: by 2002:a05:6512:b88:b0:4b6:fae9:c9b9 with SMTP id
 b8-20020a0565120b8800b004b6fae9c9b9mr1916343lfv.207.1675412904956; Fri, 03
 Feb 2023 00:28:24 -0800 (PST)
MIME-Version: 1.0
References: <CAMj1kXGBh6ka9mSYtfkCbz1wScLaZdwP7gDF6Lewk9=4jr=xFQ@mail.gmail.com>
 <20118.1675412738875218763@groups.io>
In-Reply-To: <20118.1675412738875218763@groups.io>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Fri, 3 Feb 2023 09:28:13 +0100
X-Gmail-Original-Message-ID: <CAMj1kXEB8Timbe8rCG=tdYqei=uORmExXYV=BxK0_GaPTogaFQ@mail.gmail.com>
Message-ID: <CAMj1kXEB8Timbe8rCG=tdYqei=uORmExXYV=BxK0_GaPTogaFQ@mail.gmail.com>
Subject: Re: [edk2-devel] [RFC PATCH 2/3] MdeModulePkg: Enable forward edge CFI in mem attributes table
To: =?UTF-8?Q?Marvin_H=C3=A4user?= <mhaeuser@posteo.de>
Cc: devel@edk2.groups.io
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 3 Feb 2023 at 09:25, Marvin H=C3=A4user <mhaeuser@posteo.de> wrote:
>
> Hi Ard,
>
> Short story: No, TE is not a concern for RT drivers, at least not upstrea=
m [1].
>
> Long story: Even if a downstream added support for RT relocation itself, =
TE images are loaded misaligned by DxeCore, because it lacks a (terrible) w=
orkaround as done in PeiCore [2]. It doesn=E2=80=99t look like anyone tried=
 to use them in DXE at all.
>
> Best regards,
> Marvin
>
> [1] https://github.com/tianocore/edk2/blob/11f0014c0e3046e3762eac420b7600=
91d0cdc063/MdePkg/Library/BasePeCoffLib/BasePeCoff.c#L1759
>
> [2] https://github.com/tianocore/edk2/blob/11f0014c0e3046e3762eac420b7600=
91d0cdc063/MdeModulePkg/Core/Pei/Image/Image.c#L412

Ah thanks for digging that up.

So all the more reason to add this to the PE/COFF spec rather than
anywhere else.