Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/FvLib.h: Add EFIAPI to FfsFindSection()

["Ard Biesheuvel" <ardb@kernel.org>]

On Tue, 9 Feb 2021 at 23:25, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Hi Michael,
>
> Thank you for this patch.
>
> There must be something missing with the GCC5 settings for AARCH64 as this problem does not get flagged.
>

That is because EFIAPI is #define'd to an empty string on all
architectures except X64

> However, this change looks good to me.
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>

I have merged this as #1423 (pending CI)

The other two patches did not apply so they need to be resent.

Thanks,
Ard.


>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of mikuback via groups.io
> Sent: 03 February 2021 03:52 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; Jiewen Yao <jiewen.yao@intel.com>; Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
> Subject: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/FvLib.h: Add EFIAPI to FfsFindSection()
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3203
>
> The EFIAPI modifier is present in the function definition in
> FvLib.c but missing in FvLib.h. Causes a GCC build error.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  StandaloneMmPkg/Include/Library/FvLib.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/StandaloneMmPkg/Include/Library/FvLib.h b/StandaloneMmPkg/Include/Library/FvLib.h
> index c08e043cf65f..4ef2c8540a1f 100644
> --- a/StandaloneMmPkg/Include/Library/FvLib.h
> +++ b/StandaloneMmPkg/Include/Library/FvLib.h
> @@ -50,6 +50,7 @@ FfsFindNextFile (
>    @retval  EFI_SUCCESS
>  **/
>  EFI_STATUS
> +EFIAPI
>  FfsFindSection (
>    IN EFI_SECTION_TYPE              SectionType,
>    IN EFI_FFS_FILE_HEADER           *FfsFileHeader,
> --
> 2.28.0.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#71088): https://edk2.groups.io/g/devel/message/71088
> Mute This Topic: https://groups.io/mt/80346397/1779659
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [sami.mujawar@arm.com]
> -=-=-=-=-=-=
>
>
>
>
> 
>
>