From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web08.476.1612996474722738305 for ; Wed, 10 Feb 2021 14:34:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=g925SAV3; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 1025864E38 for ; Wed, 10 Feb 2021 22:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612996474; bh=cmsrFpcFAYf+VTBtfxYeJOEoqluvFuHbfnWIhoToWzU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=g925SAV3FJfl0/AJlQoyp774mhdVkJkT+CDUcbvq+ta40gFCoPY7MBAGZT2u7ixiQ MXTJnpDwVHx1n/m0ZgnxFjEzKNw2sZeIq3qqb2z26/OK4pKu4ylZyFLT4qQHbdEhQi MHA1IWWkvcgCAnmiswf5QvxP7MIWAffC7PRDjxc+KQlxH0nkoaRC7TjfEakvuue4w0 bgf1UEm/rErTGzOyCIVvBnvIlg9J6xtgxiqvWZ0rf/A+rLhySHbT5noSPXPkJni6Zb XT49XbWqwlJYb4Y+NHLfXpHf+6N5ZtdNFBpK4Wf391nKpODXZNFRiInYsYRNJV0I7T EQzzHuxJk/EtQ== Received: by mail-ot1-f51.google.com with SMTP id r21so3378658otk.13 for ; Wed, 10 Feb 2021 14:34:34 -0800 (PST) X-Gm-Message-State: AOAM531vsWoNWtDTljzRzW6hIbzNVtWAmTcSiGSao7BNxEXkBu0bJn5a hIPbyAsUpPvkE9wx7RqZ91uaUbutcX2nDSYqosA= X-Google-Smtp-Source: ABdhPJySprem9G5XtYpdL08Kg1cp1COEf+yP/xDPcpaqM5D9rRGBpq6Q0OrpEMO8V4vxfGZ+OOSe0SmeYAj6/IY5gXU= X-Received: by 2002:a05:6830:11:: with SMTP id c17mr3745217otp.77.1612996473423; Wed, 10 Feb 2021 14:34:33 -0800 (PST) MIME-Version: 1.0 References: <20210203035215.458-1-mikuback@linux.microsoft.com> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 10 Feb 2021 23:34:22 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/FvLib.h: Add EFIAPI to FfsFindSection() To: devel@edk2.groups.io, Sami Mujawar Cc: "mikuback@linux.microsoft.com" , Ard Biesheuvel , Jiewen Yao , Supreeth Venkatesh , nd Content-Type: text/plain; charset="UTF-8" On Tue, 9 Feb 2021 at 23:25, Sami Mujawar wrote: > > Hi Michael, > > Thank you for this patch. > > There must be something missing with the GCC5 settings for AARCH64 as this problem does not get flagged. > That is because EFIAPI is #define'd to an empty string on all architectures except X64 > However, this change looks good to me. > Reviewed-by: Sami Mujawar > I have merged this as #1423 (pending CI) The other two patches did not apply so they need to be resent. Thanks, Ard. > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of mikuback via groups.io > Sent: 03 February 2021 03:52 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Sami Mujawar ; Jiewen Yao ; Supreeth Venkatesh > Subject: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/FvLib.h: Add EFIAPI to FfsFindSection() > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3203 > > The EFIAPI modifier is present in the function definition in > FvLib.c but missing in FvLib.h. Causes a GCC build error. > > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Signed-off-by: Michael Kubacki > --- > StandaloneMmPkg/Include/Library/FvLib.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/StandaloneMmPkg/Include/Library/FvLib.h b/StandaloneMmPkg/Include/Library/FvLib.h > index c08e043cf65f..4ef2c8540a1f 100644 > --- a/StandaloneMmPkg/Include/Library/FvLib.h > +++ b/StandaloneMmPkg/Include/Library/FvLib.h > @@ -50,6 +50,7 @@ FfsFindNextFile ( > @retval EFI_SUCCESS > **/ > EFI_STATUS > +EFIAPI > FfsFindSection ( > IN EFI_SECTION_TYPE SectionType, > IN EFI_FFS_FILE_HEADER *FfsFileHeader, > -- > 2.28.0.windows.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#71088): https://edk2.groups.io/g/devel/message/71088 > Mute This Topic: https://groups.io/mt/80346397/1779659 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [sami.mujawar@arm.com] > -=-=-=-=-=-= > > > > > > >