From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by mx.groups.io with SMTP id smtpd.web08.4574.1660581363370001866
 for <devel@edk2.groups.io>;
 Mon, 15 Aug 2022 09:36:03 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LttuZgka;
 spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by ams.source.kernel.org (Postfix) with ESMTPS id 911BFB80FE9
	for <devel@edk2.groups.io>; Mon, 15 Aug 2022 16:36:01 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DCEBC433C1
	for <devel@edk2.groups.io>; Mon, 15 Aug 2022 16:36:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1660581360;
	bh=1FRx2e3snTohM8/AgSgWPXIomYJFyeuDjMfpeH/EpWQ=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=LttuZgkaUynnfOm7vP5AOCj2HvL5a5Aa4PNmqSnjTBBqONjB1/ds4YLuvQ3Su7gFP
	 v1raFxrgPY6oYpil4h6dxC2L67C9bQ5PyPq3WrjOrPFTpZjcGVb1+H5elrSnK0kmA3
	 /hIJ+QuLVfWoNVBW+X5sJTHvr/s9xddonwz0brGHRoZWm/dPJYt8FRHZUJna7PBvQB
	 hzzFAg8qisb9ES5w1kgXcJIJEmRqlw+1UuG6rfzrQFliKK5pGONJwbJypqbOYutkJ+
	 EZkiY2+7OS3Yodihf/q3mw1+cQSakPve289vcG09bLg9QCUQs8VtwUYFQwmi+OHGJm
	 /EFpXUdrhmLSA==
Received: by mail-wr1-f47.google.com with SMTP id l4so9635943wrm.13
        for <devel@edk2.groups.io>; Mon, 15 Aug 2022 09:36:00 -0700 (PDT)
X-Gm-Message-State: ACgBeo1Aqu/B90d7/lrEuodcKzjlw7wCoXUODq5OlbFwecTVW1AIVL08
	xVFi7udtpZKQGuGoh0I1Nv/BNBGj2k+1WnCjOBE=
X-Google-Smtp-Source: AA6agR4xcNoEEseUsbY2dmVNwHkleevoZnjGyWsf5uryWXE9Zhvx5cvqJf92wkxxoFmQokbki9OS1K2Sg6aeN/5XOpE=
X-Received: by 2002:adf:f40c:0:b0:225:d09:246d with SMTP id
 g12-20020adff40c000000b002250d09246dmr1942939wro.561.1660581358540; Mon, 15
 Aug 2022 09:35:58 -0700 (PDT)
MIME-Version: 1.0
References: <20220815163119.2877228-1-dimitrije.pavlov@arm.com>
In-Reply-To: <20220815163119.2877228-1-dimitrije.pavlov@arm.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Mon, 15 Aug 2022 18:35:47 +0200
X-Gmail-Original-Message-ID: <CAMj1kXEC5J1B+eKSYAqKxww9kSHuriMgb5QVZJsMoL-1p6R6qw@mail.gmail.com>
Message-ID: <CAMj1kXEC5J1B+eKSYAqKxww9kSHuriMgb5QVZJsMoL-1p6R6qw@mail.gmail.com>
Subject: Re: [PATCH v2 0/3] OvmfPkg: Check arguments for validity
To: Dimitrije Pavlov <dimitrije.pavlov@arm.com>, Liming Gao <gaoliming@byosoft.com.cn>, 
	Michael Kinney <michael.d.kinney@intel.com>
Cc: devel@edk2.groups.io, Jiewen Yao <jiewen.yao@intel.com>, 
	Sunny Wang <Sunny.Wang@arm.com>, Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>, 
	Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 15 Aug 2022 at 18:31, Dimitrije Pavlov <dimitrije.pavlov@arm.com> wrote:
>
> Some functions across OVMF don't check pointer arguments for
> validity, which causes null pointer dereferences and crashes
> in the SCT test suite.
>
> This series adds checks to return EFI_INVALID_PARAMETER if a
> pointer argument is NULL.
>
> v2:
> - Add Liming Gao to Cc [Ard]
> - Turn individual patches into a series [Ard]
> - Fix issue with corrupted patches [Ard]
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Sunny Wang <Sunny.Wang@arm.com>
> Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>
> Dimitrije Pavlov (3):
>   OvmfPkg/PlatformDxe: Check ExtractConfig and RouteConfig arguments
>   OvmfPkg/VirtioGpuDxe: Check QueryMode arguments
>   OvmfPkg/VirtioFsDxe: Check GetDriverName arguments
>

Thank you for the resend.

@Liming: these are all bug fixes that affect SCT results, so unless
there are any objections, I intend to merge these tomorrow (Tuesday).

Thanks,
Ard.