public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io, quic_llindhol@quicinc.com
Cc: Jake Garver <jake@nvidia.com>
Subject: Re: [edk2-devel] [PATCH] ArmPkg/ArmMmuLib: Drop buggy secure memory type check
Date: Tue, 12 Sep 2023 12:25:06 +0200	[thread overview]
Message-ID: <CAMj1kXEDK29jKSBOZJg+J1DB--hcRvOjh6_1aAiy_p3JvMX3sQ@mail.gmail.com> (raw)
In-Reply-To: <ZQA23yq+NRCrYUlR@qc-i7.hemma.eciton.net>

On Tue, 12 Sept 2023 at 12:01, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>
> On Tue, Sep 12, 2023 at 07:42:30 +0000, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel <ardb@kernel.org>
> >
> > Jake reports that the IS_ARM_MEMORY_REGION_ATTRIBUTES_SECURE() macro is
> > no longer accurate since commit 852227a9d52e3cb9 ("ArmPkg/Mmu: Remove
> > handling of NONSECURE memory regions").
> >
> > Fortunately, it only affects the NS bit in level 1 short descriptors,
> > which is ignored when executing in non-secure mode. And given that
> > running UEFI in the secure world is not a use case we aim to support,
> > let's just drop this logic altogether.
> >
> > Reported-by: Jake Garver <jake@nvidia.com>
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
>
> Good riddance.
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
>

Thanks. Merged as #4822.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108528): https://edk2.groups.io/g/devel/message/108528
Mute This Topic: https://groups.io/mt/101311374/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2023-09-12 10:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12  7:42 [edk2-devel] [PATCH] ArmPkg/ArmMmuLib: Drop buggy secure memory type check Ard Biesheuvel via groups.io
2023-09-12 10:01 ` Leif Lindholm
2023-09-12 10:25   ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXEDK29jKSBOZJg+J1DB--hcRvOjh6_1aAiy_p3JvMX3sQ@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox