From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web08.24514.1639481490634069066 for ; Tue, 14 Dec 2021 03:31:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TwuxD93p; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C0E71B8189E for ; Tue, 14 Dec 2021 11:31:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93E73C34608 for ; Tue, 14 Dec 2021 11:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639481486; bh=eHtWes797KIjsXeuVrDHKgBIs/bYdHR5Vfl5qmiSCZQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=TwuxD93pJfu9t90srLCzJK+l1gQ9CfEx2mER6iHZJSk6LdhSFg3jqhiJ1JOKOyAZX 2dUxlrdLxNZLBAUl6B03EmzvCM3kx2kU4ouxSWIqrKF3WVKmEce5lgd9JajczSBe0t d+L4+OslIqAUAFglzGurpitQF6EGfcyBLQZvEPjyQ9ZCeemr9xyIkinmtxLg8Gvsb2 zXyW58lZG0B4BKyZWuK1lx0epetTZQLbL5ZvEtYI0XoFJUW0fR0mT7ckG2CoJB3ZR3 5gdiVX/Y17OgQVwc4pWARjPiCd5Sx/Vu3TGPLXCdzOwZL4fADGn1OWDbPOC0whiFJn ala8DlmRRQKQg== Received: by mail-ot1-f50.google.com with SMTP id a23-20020a9d4717000000b0056c15d6d0caso20485837otf.12 for ; Tue, 14 Dec 2021 03:31:26 -0800 (PST) X-Gm-Message-State: AOAM532VmVBIEd2daYpKafTKEslIYeA1gMkYB9Q5qtpezI11SUozTg9O +fCgA3qGVdPD4OUOrA0ZLumq29OTq6+R32RAn2s= X-Google-Smtp-Source: ABdhPJw4fyfpGWhkhpYx1A4ZG9thwc6dzisfXyeEVTx41Sm6Ip7YvWzCsgVN+RhD80glFnSraot+N6O9fEl4n2BKutE= X-Received: by 2002:a05:6830:1445:: with SMTP id w5mr3833794otp.112.1639481485764; Tue, 14 Dec 2021 03:31:25 -0800 (PST) MIME-Version: 1.0 References: <20211213183056.31444-1-rebecca@nuviainc.com> In-Reply-To: <20211213183056.31444-1-rebecca@nuviainc.com> From: "Ard Biesheuvel" Date: Tue, 14 Dec 2021 12:31:14 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/2] ArmPkg: Add SMC helper functions To: Rebecca Cran Cc: edk2-devel-groups-io , Ard Biesheuvel , Gerd Hoffmann , Samer El-Haj-Mahmoud , Leif Lindholm , nd , Sami Mujawar Content-Type: text/plain; charset="UTF-8" On Mon, 13 Dec 2021 at 19:31, Rebecca Cran wrote: > > To reduce the amount of template code, introduce SMC helper > functions. Update ArmSmcPsciResetSystemLib and Universal/Smbios to use > them. > > Changes from v2 to v3: > > o Fixed code style issues with Uncrustify. > o Fixed patch 2/2 subject. > o Added OPTIONAL tag to functions. > o Added ZeroMem call to initialize Args. > > GitHub Test PR: https://github.com/tianocore/edk2/pull/2300 > > Rebecca Cran (2): > ArmPkg: Add SMC helper functions > ArmPkg: Update SMC calls to use the new ArmCallSmc0/1/2/3 functions > Merged as #2303 Thanks, > ArmPkg/Include/Library/ArmSmcLib.h | 73 +++++++++++ > ArmPkg/Library/ArmSmcLib/ArmSmc.c | 129 ++++++++++++++++++++ > ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf | 3 + > ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c | 85 +++++++++++++ > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c | 10 +- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 40 +++--- > 6 files changed, 308 insertions(+), 32 deletions(-) > create mode 100644 ArmPkg/Library/ArmSmcLib/ArmSmc.c > > -- > 2.31.1 >