public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Leif Lindholm <quic_llindhol@quicinc.com>
Subject: Re: [edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl
Date: Tue, 5 Mar 2024 14:02:02 +0100	[thread overview]
Message-ID: <CAMj1kXEG5sQg9BFkkpZYc5VnNQA1wZNCWQ+aCCqU6GNwF5Jj8Q@mail.gmail.com> (raw)
In-Reply-To: <20240305113843.68812-6-lersek@redhat.com>

On Tue, 5 Mar 2024 at 12:39, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Rely on AutoGen for declaring ProcessLibraryConstructorList().
>
> Build-tested with:
>
>   build -a AARCH64 -b DEBUG \
>     -m ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf \
>     -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5
>
>   build -a AARCH64 -b DEBUG \
>     -m ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf \
>     -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5
>
>   build -a AARCH64 -b DEBUG \
>     -m ArmPlatformPkg/PrePi/PeiMPCore.inf \
>     -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5
>
>   build -a AARCH64 -b DEBUG \
>     -m ArmPlatformPkg/PrePi/PeiUniCore.inf \
>     -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf  |  2 +-
>  ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf |  2 +-
>  ArmPlatformPkg/PrePi/PeiMPCore.inf              |  2 +-
>  ArmPlatformPkg/PrePi/PeiUniCore.inf             |  2 +-
>  ArmPlatformPkg/PrePeiCore/PrePeiCore.h          | 10 ----------
>  ArmPlatformPkg/PrePi/PrePi.h                    |  6 ------
>  6 files changed, 4 insertions(+), 20 deletions(-)
>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

> diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> index 4a3112b58dcb..c5cad7e37fbd 100644
> --- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> @@ -8,7 +8,7 @@
>  #**/
>
>  [Defines]
> -  INF_VERSION                    = 0x00010005
> +  INF_VERSION                    = 1.30
>    BASE_NAME                      = ArmPlatformPrePeiCore
>    FILE_GUID                      = b78d02bb-d0b5-4389-bc7f-b39ee846c784
>    MODULE_TYPE                    = SEC
> diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> index ab5bf1dac2d8..1d50b4d0b5f2 100644
> --- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> @@ -8,7 +8,7 @@
>  #**/
>
>  [Defines]
> -  INF_VERSION                    = 0x00010005
> +  INF_VERSION                    = 1.30
>    BASE_NAME                      = ArmPlatformPrePeiCore
>    FILE_GUID                      = 469fc080-aec1-11df-927c-0002a5d5c51b
>    MODULE_TYPE                    = SEC
> diff --git a/ArmPlatformPkg/PrePi/PeiMPCore.inf b/ArmPlatformPkg/PrePi/PeiMPCore.inf
> index a613b24c340e..0b13b723539c 100644
> --- a/ArmPlatformPkg/PrePi/PeiMPCore.inf
> +++ b/ArmPlatformPkg/PrePi/PeiMPCore.inf
> @@ -8,7 +8,7 @@
>  #**/
>
>  [Defines]
> -  INF_VERSION                    = 0x00010005
> +  INF_VERSION                    = 1.30
>    BASE_NAME                      = ArmPlatformPrePiMPCore
>    FILE_GUID                      = d959e387-7b91-452c-90e0-a1dbac90ddb8
>    MODULE_TYPE                    = SEC
> diff --git a/ArmPlatformPkg/PrePi/PeiUniCore.inf b/ArmPlatformPkg/PrePi/PeiUniCore.inf
> index b62ea3c485bd..2e237172d571 100644
> --- a/ArmPlatformPkg/PrePi/PeiUniCore.inf
> +++ b/ArmPlatformPkg/PrePi/PeiUniCore.inf
> @@ -9,7 +9,7 @@
>  #**/
>
>  [Defines]
> -  INF_VERSION                    = 0x00010005
> +  INF_VERSION                    = 1.30
>    BASE_NAME                      = ArmPlatformPrePiUniCore
>    FILE_GUID                      = 3e401783-cc94-4fcd-97bc-bd35ac369d2f
>    MODULE_TYPE                    = SEC
> diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCore.h b/ArmPlatformPkg/PrePeiCore/PrePeiCore.h
> index c1e13e23e11e..fbf6207db816 100644
> --- a/ArmPlatformPkg/PrePeiCore/PrePeiCore.h
> +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCore.h
> @@ -73,14 +73,4 @@ PeiCommonExceptionEntry (
>    IN UINTN   LR
>    );
>
> -/*
> - * Autogenerated function that calls the library constructors for all of the
> - * module's dependent libraries.
> - */
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> -  VOID
> -  );
> -
>  #endif
> diff --git a/ArmPlatformPkg/PrePi/PrePi.h b/ArmPlatformPkg/PrePi/PrePi.h
> index 6074a22108d2..1d47ba26be3a 100644
> --- a/ArmPlatformPkg/PrePi/PrePi.h
> +++ b/ArmPlatformPkg/PrePi/PrePi.h
> @@ -79,10 +79,4 @@ ArchInitialize (
>    VOID
>    );
>
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> -  VOID
> -  );
> -
>  #endif /* _PREPI_H_ */
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116389): https://edk2.groups.io/g/devel/message/116389
Mute This Topic: https://groups.io/mt/104742525/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-03-05 13:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51 Laszlo Ersek
2024-03-06 21:08   ` Laszlo Ersek
2024-03-06 22:22     ` Michael D Kinney
2024-03-06 21:17   ` Rebecca Cran
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 02/10] OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() decl Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 03/10] OvmfPkg/IntelTdx: auto-gen & fix " Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 04/10] OvmfPkg/RiscVVirt/Sec: clean up " Laszlo Ersek
2024-03-05 14:06   ` Sunil V L
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC " Laszlo Ersek
2024-03-05 13:02   ` Ard Biesheuvel [this message]
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 06/10] ArmVirtPkg: " Laszlo Ersek
2024-03-05 13:01   ` Ard Biesheuvel
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 07/10] EmulatorPkg: " Laszlo Ersek
2024-03-06 21:09   ` Laszlo Ersek
2024-03-06 22:36     ` Michael D Kinney
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: " Laszlo Ersek
2024-03-06 21:09   ` Laszlo Ersek
2024-03-07  9:09     ` Zeng, Star
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: " Laszlo Ersek
2024-03-06 21:10   ` Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: " Laszlo Ersek
2024-03-06 21:10   ` Laszlo Ersek
2024-03-05 12:26 ` [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Yao, Jiewen
2024-03-07  8:24 ` Gerd Hoffmann
2024-03-08  9:13 ` Laszlo Ersek
2024-03-08  9:34   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXEG5sQg9BFkkpZYc5VnNQA1wZNCWQ+aCCqU6GNwF5Jj8Q@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox