From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 538A87803DE for ; Tue, 5 Mar 2024 13:02:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=sxEOEdW+jXmQ5od/1b5vWg8s0uAhISYgcgbLAbTbF5g=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1709643740; v=1; b=YPDQ9Nqbk3aq7HJVnH+AbshDt9z81iuZJ2CcuYj+vSTDdylgM5cdTj0KBllB+gwACKH/PTLh APwFkfKa9l+WWILJLsnBKtSUKugeuiNf3cBcuhCRfy3sJ2ydXMDYaUbVdGYTdvC+kB5RqFYiPji p/SMRdjDw2Xdvip1lEd7LNTM= X-Received: by 127.0.0.2 with SMTP id YRhRYY7687511xOQ1XPSVl46; Tue, 05 Mar 2024 05:02:20 -0800 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.22383.1709643739036349319 for ; Tue, 05 Mar 2024 05:02:19 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 0E444CE1692 for ; Tue, 5 Mar 2024 13:02:17 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FA0CC43390 for ; Tue, 5 Mar 2024 13:02:16 +0000 (UTC) X-Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5131bec457eso4857429e87.0 for ; Tue, 05 Mar 2024 05:02:16 -0800 (PST) X-Gm-Message-State: aj0kppThzudFjv7UjrAjekmvx7686176AA= X-Google-Smtp-Source: AGHT+IEc0bIhIgUyBIi35KtIhD4gwPSgplh4IPPanzH4nkNA0Hq3hcy6fIuKM0b9lWb7TQC/WI6oK2UpAoiwO+sVNdY= X-Received: by 2002:ac2:5bdb:0:b0:512:f501:cca with SMTP id u27-20020ac25bdb000000b00512f5010ccamr727719lfn.14.1709643734513; Tue, 05 Mar 2024 05:02:14 -0800 (PST) MIME-Version: 1.0 References: <20240305113843.68812-1-lersek@redhat.com> <20240305113843.68812-6-lersek@redhat.com> In-Reply-To: <20240305113843.68812-6-lersek@redhat.com> From: "Ard Biesheuvel" Date: Tue, 5 Mar 2024 14:02:02 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl To: Laszlo Ersek Cc: edk2-devel-groups-io , Leif Lindholm Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=YPDQ9Nqb; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 5 Mar 2024 at 12:39, Laszlo Ersek wrote: > > Rely on AutoGen for declaring ProcessLibraryConstructorList(). > > Build-tested with: > > build -a AARCH64 -b DEBUG \ > -m ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf \ > -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5 > > build -a AARCH64 -b DEBUG \ > -m ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf \ > -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5 > > build -a AARCH64 -b DEBUG \ > -m ArmPlatformPkg/PrePi/PeiMPCore.inf \ > -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5 > > build -a AARCH64 -b DEBUG \ > -m ArmPlatformPkg/PrePi/PeiUniCore.inf \ > -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5 > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 > Signed-off-by: Laszlo Ersek > --- > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +- > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +- > ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +- > ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +- > ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 10 ---------- > ArmPlatformPkg/PrePi/PrePi.h | 6 ------ > 6 files changed, 4 insertions(+), 20 deletions(-) > Reviewed-by: Ard Biesheuvel > diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf > index 4a3112b58dcb..c5cad7e37fbd 100644 > --- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf > +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf > @@ -8,7 +8,7 @@ > #**/ > > [Defines] > - INF_VERSION = 0x00010005 > + INF_VERSION = 1.30 > BASE_NAME = ArmPlatformPrePeiCore > FILE_GUID = b78d02bb-d0b5-4389-bc7f-b39ee846c784 > MODULE_TYPE = SEC > diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf > index ab5bf1dac2d8..1d50b4d0b5f2 100644 > --- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf > +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf > @@ -8,7 +8,7 @@ > #**/ > > [Defines] > - INF_VERSION = 0x00010005 > + INF_VERSION = 1.30 > BASE_NAME = ArmPlatformPrePeiCore > FILE_GUID = 469fc080-aec1-11df-927c-0002a5d5c51b > MODULE_TYPE = SEC > diff --git a/ArmPlatformPkg/PrePi/PeiMPCore.inf b/ArmPlatformPkg/PrePi/PeiMPCore.inf > index a613b24c340e..0b13b723539c 100644 > --- a/ArmPlatformPkg/PrePi/PeiMPCore.inf > +++ b/ArmPlatformPkg/PrePi/PeiMPCore.inf > @@ -8,7 +8,7 @@ > #**/ > > [Defines] > - INF_VERSION = 0x00010005 > + INF_VERSION = 1.30 > BASE_NAME = ArmPlatformPrePiMPCore > FILE_GUID = d959e387-7b91-452c-90e0-a1dbac90ddb8 > MODULE_TYPE = SEC > diff --git a/ArmPlatformPkg/PrePi/PeiUniCore.inf b/ArmPlatformPkg/PrePi/PeiUniCore.inf > index b62ea3c485bd..2e237172d571 100644 > --- a/ArmPlatformPkg/PrePi/PeiUniCore.inf > +++ b/ArmPlatformPkg/PrePi/PeiUniCore.inf > @@ -9,7 +9,7 @@ > #**/ > > [Defines] > - INF_VERSION = 0x00010005 > + INF_VERSION = 1.30 > BASE_NAME = ArmPlatformPrePiUniCore > FILE_GUID = 3e401783-cc94-4fcd-97bc-bd35ac369d2f > MODULE_TYPE = SEC > diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCore.h b/ArmPlatformPkg/PrePeiCore/PrePeiCore.h > index c1e13e23e11e..fbf6207db816 100644 > --- a/ArmPlatformPkg/PrePeiCore/PrePeiCore.h > +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCore.h > @@ -73,14 +73,4 @@ PeiCommonExceptionEntry ( > IN UINTN LR > ); > > -/* > - * Autogenerated function that calls the library constructors for all of the > - * module's dependent libraries. > - */ > -VOID > -EFIAPI > -ProcessLibraryConstructorList ( > - VOID > - ); > - > #endif > diff --git a/ArmPlatformPkg/PrePi/PrePi.h b/ArmPlatformPkg/PrePi/PrePi.h > index 6074a22108d2..1d47ba26be3a 100644 > --- a/ArmPlatformPkg/PrePi/PrePi.h > +++ b/ArmPlatformPkg/PrePi/PrePi.h > @@ -79,10 +79,4 @@ ArchInitialize ( > VOID > ); > > -VOID > -EFIAPI > -ProcessLibraryConstructorList ( > - VOID > - ); > - > #endif /* _PREPI_H_ */ > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116389): https://edk2.groups.io/g/devel/message/116389 Mute This Topic: https://groups.io/mt/104742525/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-