From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.3337.1677524267731736316 for ; Mon, 27 Feb 2023 10:57:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HTMeZkHw; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 916BBB80DA1 for ; Mon, 27 Feb 2023 18:57:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AC78C433D2 for ; Mon, 27 Feb 2023 18:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677524264; bh=tMCNDv2JOIIfH8niu+gqNoIVgd+ALeudxdx+CkzJXg4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HTMeZkHweAsnvLP5uhKTJcmjezbmnLr9zbRExpcqjWjXJjI7hObh2FlyHAi64tvqm mtCxARPHDHUB7/2mJCFeVMlWo2F9hrOwEbWnrGrjraFoNdckHgq7zQFQxmnXOaqAfS gKVlNWlHOCTD+K6+DjUZIhhL5056QBf5hD6eXdrf43O2Vpbsm5BapeDeYszdMGBi1y 2I7iBV0rbk0EBWJ/2NqpMk2jV6+zLhS3EzT2nCRhFVoDaCj5VRRaHUwtaaLZ7gl3z3 keoihXyDH23lXEaTmAau29ugyp9i3hk2eKVUBsjRs3xVHgveo/Ql2gtMs5m5H/9X59 M1ibXJ6nm10Rg== Received: by mail-lj1-f177.google.com with SMTP id x6so1937226ljq.1 for ; Mon, 27 Feb 2023 10:57:44 -0800 (PST) X-Gm-Message-State: AO0yUKUVGFv0Mw1Zl3aQP/NI266S0a0P1QUDsLJ7K4S3nGlO/kZCfh8H MfioQM9XMqDjCZipIA5pOVgpJ4En579whMfR7GQ= X-Google-Smtp-Source: AK7set8Bc+OKiCvz7c6iJP9ionse/5J9EAN2RM427tbdnsbn+bxF9uisQSeZWM5QtrvReNBdnE3U1N4k6EX1uoSH8YI= X-Received: by 2002:a2e:a237:0:b0:295:8918:9d77 with SMTP id i23-20020a2ea237000000b0029589189d77mr6903133ljm.2.1677524262394; Mon, 27 Feb 2023 10:57:42 -0800 (PST) MIME-Version: 1.0 References: <320a45f265969df1a108777713e5ac954a75be56.1675735858.git.guillermo.a.palomino.sosa@intel.com> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 27 Feb 2023 19:57:31 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report To: devel@edk2.groups.io, guillermo.a.palomino.sosa@intel.com Cc: "Ni, Ray" , "Kinney, Michael D" , "Chen, Christine" , "Feng, Bob C" , "Gao, Liming" , "Oram, Isaac W" , Sean Brogan Content-Type: text/plain; charset="UTF-8" On Mon, 27 Feb 2023 at 18:40, Guillermo Antonio Palomino Sosa wrote: > > Hi. I have submitted a pull request to edk2-basetools repository: https://github.com/tianocore/edk2-basetools/pull/88 > This is the feature request for it: https://github.com/tianocore/edk2-basetools/issues/87 > I'm also attaching the patch here: (0001-BaseTools-Generate-compile-information-in-build-repo.patch) > > On a side note, seems like tip of edk2-basetools is broken due this commit that makes direct import of Common package: > https://github.com/tianocore/edk2-basetools/commit/8e6018d3ea4c1aae7185f589d129cea14a5d89fd > edk2-basetools\edk2basetools\GenFds\SubTypeGuidSection.py: > import Common.LongFilePathOs as os > > I sent a fix and a PR for this about a month ago: https://github.com/tianocore/edk2-basetools/pull/86 but CodeCov seems to take issue with it, for reasons I don't understand (and I can't be bothered to spend more time on yet another CI automation pass that adds to my workload rather than reduce it)