From: "Ard Biesheuvel" <ardb@kernel.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, Min Xu <min.m.xu@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Michael Roth <michael.roth@amd.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>,
Oliver Steffen <osteffen@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Xiaoyu Lu <xiaoyu1.lu@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
Guomin Jiang <guomin.jiang@intel.com>,
James Bottomley <jejb@linux.ibm.com>
Subject: Re: [PATCH 00/11] OvmfPkg: add Crypto Driver support
Date: Fri, 3 Feb 2023 14:33:07 +0100 [thread overview]
Message-ID: <CAMj1kXEHvSzrQQSFi2LsJ10beJRacjjPQgCTB4UkK1iCJc2BOg@mail.gmail.com> (raw)
In-Reply-To: <20230203132806.2275708-1-kraxel@redhat.com>
On Fri, 3 Feb 2023 at 14:28, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
What is the point of this series? If we are trying to deduplicate
crypto code by moving it into a dedicated driver, can we please just
do that unconditionally, instead of doubling the size of the
validation matrix again? Or are there reasons why one might avoid this
crypto driver approach?
>
>
> Gerd Hoffmann (11):
> CryptoPkg: move Driver PCD configs to include files
> OvmfPkg: add OvmfCryptoLibs.dsc.inc
> OvmfPkg: OvmfPkgX64: use Crypto Libs include
> OvmfPkg: Add Crypto driver support, add more OvmfCrypto*.inc files.
> OvmfPkg: OvmfPkgX64: use new Crypto support includes
> OvmfPkg: add OVMF_X64_CRYPTO_DRIVER test case
> OvmfPkg: OvmfPkgIa32X64: use crypto includes
> OvmfPkg: OvmfPkgIa32: use crypto includes
> OvmfPkg: Microvm: use crypto includes
> OvmfPkg: IntelTdx: use crypto includes
> OvmfPkg: AmdSev: use crypto includes
>
> .../Include/Dsc/CryptoServicePcd.all.dsc.inc | 29 +++++++
> .../Dsc/CryptoServicePcd.min_dxe_smm.dsc.inc | 35 +++++++++
> .../Dsc/CryptoServicePcd.min_pei.dsc.inc | 20 +++++
> .../Include/Dsc/OvmfCryptoComponents.dsc.inc | 41 ++++++++++
> OvmfPkg/Include/Dsc/OvmfCryptoDefines.dsc.inc | 5 ++
> OvmfPkg/Include/Dsc/OvmfCryptoLibs.dsc.inc | 57 ++++++++++++++
> CryptoPkg/CryptoPkg.dsc | 78 +------------------
> OvmfPkg/AmdSev/AmdSevX64.dsc | 11 ++-
> OvmfPkg/IntelTdx/IntelTdxX64.dsc | 15 ++--
> OvmfPkg/Microvm/MicrovmX64.dsc | 22 +++---
> OvmfPkg/OvmfPkgIa32.dsc | 20 ++---
> OvmfPkg/OvmfPkgIa32X64.dsc | 20 ++---
> OvmfPkg/OvmfPkgX64.dsc | 20 ++---
> OvmfPkg/AmdSev/AmdSevX64.fdf | 6 ++
> OvmfPkg/IntelTdx/IntelTdxX64.fdf | 5 ++
> OvmfPkg/Microvm/MicrovmX64.fdf | 7 ++
> OvmfPkg/OvmfPkgIa32.fdf | 6 ++
> OvmfPkg/OvmfPkgIa32X64.fdf | 6 ++
> OvmfPkg/OvmfPkgX64.fdf | 6 ++
> OvmfPkg/Include/Fdf/OvmfCryptoDxeSmm.fdf.inc | 12 +++
> OvmfPkg/Include/Fdf/OvmfCryptoPei.fdf.inc | 9 +++
> .../.azurepipelines/Ubuntu-GCC5.yml | 7 ++
> 22 files changed, 300 insertions(+), 137 deletions(-)
> create mode 100644 CryptoPkg/Include/Dsc/CryptoServicePcd.all.dsc.inc
> create mode 100644 CryptoPkg/Include/Dsc/CryptoServicePcd.min_dxe_smm.dsc.inc
> create mode 100644 CryptoPkg/Include/Dsc/CryptoServicePcd.min_pei.dsc.inc
> create mode 100644 OvmfPkg/Include/Dsc/OvmfCryptoComponents.dsc.inc
> create mode 100644 OvmfPkg/Include/Dsc/OvmfCryptoDefines.dsc.inc
> create mode 100644 OvmfPkg/Include/Dsc/OvmfCryptoLibs.dsc.inc
> create mode 100644 OvmfPkg/Include/Fdf/OvmfCryptoDxeSmm.fdf.inc
> create mode 100644 OvmfPkg/Include/Fdf/OvmfCryptoPei.fdf.inc
>
> --
> 2.39.1
>
next prev parent reply other threads:[~2023-02-03 13:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:27 [PATCH 00/11] OvmfPkg: add Crypto Driver support Gerd Hoffmann
2023-02-03 13:27 ` [PATCH 01/11] CryptoPkg: move Driver PCD configs to include files Gerd Hoffmann
2023-02-03 13:27 ` [PATCH 02/11] OvmfPkg: add OvmfCryptoLibs.dsc.inc Gerd Hoffmann
2023-02-03 13:27 ` [PATCH 03/11] OvmfPkg: OvmfPkgX64: use Crypto Libs include Gerd Hoffmann
2023-02-03 13:27 ` [PATCH 04/11] OvmfPkg: Add Crypto driver support, add more OvmfCrypto*.inc files Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 05/11] OvmfPkg: OvmfPkgX64: use new Crypto support includes Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 06/11] OvmfPkg: add OVMF_X64_CRYPTO_DRIVER test case Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 07/11] OvmfPkg: OvmfPkgIa32X64: use crypto includes Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 08/11] OvmfPkg: OvmfPkgIa32: " Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 09/11] OvmfPkg: Microvm: " Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 10/11] OvmfPkg: IntelTdx: " Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 11/11] OvmfPkg: AmdSev: " Gerd Hoffmann
2023-02-03 13:33 ` Ard Biesheuvel [this message]
2023-02-03 15:36 ` [edk2-devel] [PATCH 00/11] OvmfPkg: add Crypto Driver support Gerd Hoffmann
2023-02-03 15:57 ` Ard Biesheuvel
2023-02-03 16:28 ` Gerd Hoffmann
2023-02-03 19:45 ` Pedro Falcato
2023-02-03 23:24 ` Ard Biesheuvel
2023-02-04 1:08 ` Pedro Falcato
2023-02-04 7:56 ` Ard Biesheuvel
2023-02-04 1:13 ` Marvin Häuser
2023-02-04 8:05 ` Ard Biesheuvel
2023-02-04 9:58 ` Marvin Häuser
2023-02-04 8:10 ` Ard Biesheuvel
2023-02-06 8:21 ` Gerd Hoffmann
2023-02-07 3:15 ` Li, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXEHvSzrQQSFi2LsJ10beJRacjjPQgCTB4UkK1iCJc2BOg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox