From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.10234.1675431202258390694 for ; Fri, 03 Feb 2023 05:33:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J+BMCYB8; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B36661F20 for ; Fri, 3 Feb 2023 13:33:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93A7DC4339B for ; Fri, 3 Feb 2023 13:33:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675431200; bh=Q1Z0IxOKh8O5NoCFB6RskrWEuruZFpr6aisGcMkZTvo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=J+BMCYB8qzTzF6hyvYbm+1lETSM8d34mZF38g3wiHxJeMowE7sHknq4IwPRxqykGH oX7RMCzy5rD67CtTqh7UnGWtH++cgPPpRRSJYhs8M0qVGN4EDxZMuqayqAMnCERWTr Wi11EJ6DDFsmq/grI9521bPIZuzOvwS9DIeZySQXl8uQyFXn9fRJspsZa7n06SU2os 5bKRb1rLnPBqtjM6ipTjRJ6xhS3oxOD2Gexk6FfudmUF3XFyp1goCSrCUYSbR0t8LX JAnIuGwJhNzTGTZxQYq98AN7J2/zIFS2ZqR1CKCLEryAFMpJsEj6G82km6rjZY1kA4 kdch+ftgo2bcQ== Received: by mail-lf1-f50.google.com with SMTP id j17so7813697lfr.3 for ; Fri, 03 Feb 2023 05:33:20 -0800 (PST) X-Gm-Message-State: AO0yUKWHQ+QYnyzZ0gXV/aE9gXHdvj4q3GLPKkvrKErf3jjwuKzdf4oV mNVGreWWgUuQ36XuK4j+pdAHfHtsiNvt7VZpRvY= X-Google-Smtp-Source: AK7set8jXB1LXSxfjeiZzCa6wJfvEn0WY0VAZvvDqgdXnzfU/7WSvOKQb33pj2An99aM+a5h9nzWDjtsHcyZqJUmWJo= X-Received: by 2002:ac2:5b9c:0:b0:4d8:767b:8b6b with SMTP id o28-20020ac25b9c000000b004d8767b8b6bmr1964346lfn.63.1675431198530; Fri, 03 Feb 2023 05:33:18 -0800 (PST) MIME-Version: 1.0 References: <20230203132806.2275708-1-kraxel@redhat.com> In-Reply-To: <20230203132806.2275708-1-kraxel@redhat.com> From: "Ard Biesheuvel" Date: Fri, 3 Feb 2023 14:33:07 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/11] OvmfPkg: add Crypto Driver support To: Gerd Hoffmann Cc: devel@edk2.groups.io, Min Xu , Ard Biesheuvel , Michael Roth , Jiewen Yao , Jian J Wang , Jordan Justen , Pawel Polawski , Oliver Steffen , Tom Lendacky , Xiaoyu Lu , Erdem Aktas , Guomin Jiang , James Bottomley Content-Type: text/plain; charset="UTF-8" On Fri, 3 Feb 2023 at 14:28, Gerd Hoffmann wrote: > What is the point of this series? If we are trying to deduplicate crypto code by moving it into a dedicated driver, can we please just do that unconditionally, instead of doubling the size of the validation matrix again? Or are there reasons why one might avoid this crypto driver approach? > > > Gerd Hoffmann (11): > CryptoPkg: move Driver PCD configs to include files > OvmfPkg: add OvmfCryptoLibs.dsc.inc > OvmfPkg: OvmfPkgX64: use Crypto Libs include > OvmfPkg: Add Crypto driver support, add more OvmfCrypto*.inc files. > OvmfPkg: OvmfPkgX64: use new Crypto support includes > OvmfPkg: add OVMF_X64_CRYPTO_DRIVER test case > OvmfPkg: OvmfPkgIa32X64: use crypto includes > OvmfPkg: OvmfPkgIa32: use crypto includes > OvmfPkg: Microvm: use crypto includes > OvmfPkg: IntelTdx: use crypto includes > OvmfPkg: AmdSev: use crypto includes > > .../Include/Dsc/CryptoServicePcd.all.dsc.inc | 29 +++++++ > .../Dsc/CryptoServicePcd.min_dxe_smm.dsc.inc | 35 +++++++++ > .../Dsc/CryptoServicePcd.min_pei.dsc.inc | 20 +++++ > .../Include/Dsc/OvmfCryptoComponents.dsc.inc | 41 ++++++++++ > OvmfPkg/Include/Dsc/OvmfCryptoDefines.dsc.inc | 5 ++ > OvmfPkg/Include/Dsc/OvmfCryptoLibs.dsc.inc | 57 ++++++++++++++ > CryptoPkg/CryptoPkg.dsc | 78 +------------------ > OvmfPkg/AmdSev/AmdSevX64.dsc | 11 ++- > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 15 ++-- > OvmfPkg/Microvm/MicrovmX64.dsc | 22 +++--- > OvmfPkg/OvmfPkgIa32.dsc | 20 ++--- > OvmfPkg/OvmfPkgIa32X64.dsc | 20 ++--- > OvmfPkg/OvmfPkgX64.dsc | 20 ++--- > OvmfPkg/AmdSev/AmdSevX64.fdf | 6 ++ > OvmfPkg/IntelTdx/IntelTdxX64.fdf | 5 ++ > OvmfPkg/Microvm/MicrovmX64.fdf | 7 ++ > OvmfPkg/OvmfPkgIa32.fdf | 6 ++ > OvmfPkg/OvmfPkgIa32X64.fdf | 6 ++ > OvmfPkg/OvmfPkgX64.fdf | 6 ++ > OvmfPkg/Include/Fdf/OvmfCryptoDxeSmm.fdf.inc | 12 +++ > OvmfPkg/Include/Fdf/OvmfCryptoPei.fdf.inc | 9 +++ > .../.azurepipelines/Ubuntu-GCC5.yml | 7 ++ > 22 files changed, 300 insertions(+), 137 deletions(-) > create mode 100644 CryptoPkg/Include/Dsc/CryptoServicePcd.all.dsc.inc > create mode 100644 CryptoPkg/Include/Dsc/CryptoServicePcd.min_dxe_smm.dsc.inc > create mode 100644 CryptoPkg/Include/Dsc/CryptoServicePcd.min_pei.dsc.inc > create mode 100644 OvmfPkg/Include/Dsc/OvmfCryptoComponents.dsc.inc > create mode 100644 OvmfPkg/Include/Dsc/OvmfCryptoDefines.dsc.inc > create mode 100644 OvmfPkg/Include/Dsc/OvmfCryptoLibs.dsc.inc > create mode 100644 OvmfPkg/Include/Fdf/OvmfCryptoDxeSmm.fdf.inc > create mode 100644 OvmfPkg/Include/Fdf/OvmfCryptoPei.fdf.inc > > -- > 2.39.1 >