From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web08.5802.1666169712809040196 for ; Wed, 19 Oct 2022 01:55:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WsdDeD88; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 255ADB823CD for ; Wed, 19 Oct 2022 08:55:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C35F6C43142 for ; Wed, 19 Oct 2022 08:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666169708; bh=p+1U3DhuSpudz5I9emY+LPQ0hnpaXYokWCg9St+fKys=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WsdDeD887qilER+wYPeBA6Tmr1lVyrq723qNpku4AtzSgsYcIIC3t/WfSBCE/WzxH GZN2QMFi420/rpWWVyOf5vbN4ie1B2j++5la+HQeFiMQI7C6wEJp5ihVLjXZTiTME8 cUngBEJs8bxrRO3Z0FBm/l1/z3Uv3/yzql+Oml7YPXA0XtsZz10RkzurSydxrDnuLF 6ioPxa7xTth3I+2hLClrQ1TjFbuWz1rSvfazGYP4o9Q8iRDxP4zaUH/4TEhXIvupEt xrNEla9qbTRM2W5nenqrZLnRO3btnZqmVbzM3U/cbQ85h5XczDhaJNOF3s5GFtT3Z2 HjcG3p3Bom/WQ== Received: by mail-lf1-f43.google.com with SMTP id j4so27034259lfk.0 for ; Wed, 19 Oct 2022 01:55:08 -0700 (PDT) X-Gm-Message-State: ACrzQf3ha5N4yweNtEazUuoUe2nSOvgTofUjbSuLNUCw1uuSvOjVSKJ5 qZ6AbZ+XoDqA3Aj5FV5HBo7rLyWP0NTlXDOAK4Y= X-Google-Smtp-Source: AMsMyM4XUQTyxtgOvDoGpBGNI7wqmk5AxSitXnKwBXNhwg/qxAWANDdU5QOqZq/Np3TEqtyUKTB+6jziFMmfeqwSooA= X-Received: by 2002:a05:6512:150e:b0:492:d9fd:9bdf with SMTP id bq14-20020a056512150e00b00492d9fd9bdfmr2349686lfb.583.1666169706809; Wed, 19 Oct 2022 01:55:06 -0700 (PDT) MIME-Version: 1.0 References: <20221014164836.1513036-1-sunilvl@ventanamicro.com> <20221014164836.1513036-27-sunilvl@ventanamicro.com> In-Reply-To: <20221014164836.1513036-27-sunilvl@ventanamicro.com> From: "Ard Biesheuvel" Date: Wed, 19 Oct 2022 10:54:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-staging/RiscV64QemuVirt PATCH V4 26/34] EmbeddedPkg/NvVarStoreFormattedLib: Migrate to MdeModulePkg To: Sunil V L Cc: devel@edk2.groups.io, Leif Lindholm , Abner Chang , Daniel Schaefer , Jian J Wang , Liming Gao , Andrew Fish , Michael D Kinney Content-Type: text/plain; charset="UTF-8" On Fri, 14 Oct 2022 at 18:49, Sunil V L wrote: > > This library is required by NorFlashDxe. Since it will be used by > both virtual and real platforms, migrate this library to > MdeModulePkg. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > Cc: Jian J Wang > Cc: Liming Gao > Cc: Andrew Fish > Cc: Michael D Kinney > Signed-off-by: Sunil V L Acked-by: Ard Biesheuvel Can we get an ack on this from the MdeModulePkg maintainers please? > --- > EmbeddedPkg/EmbeddedPkg.dec | 3 --- > MdeModulePkg/MdeModulePkg.dec | 3 +++ > MdeModulePkg/MdeModulePkg.dsc | 2 ++ > {EmbeddedPkg => MdeModulePkg}/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf | 1 - > {EmbeddedPkg => MdeModulePkg}/Include/Guid/NvVarStoreFormatted.h | 0 > {EmbeddedPkg => MdeModulePkg}/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.c | 0 > 6 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec > index 341ef5e6a679..b1f5654835f6 100644 > --- a/EmbeddedPkg/EmbeddedPkg.dec > +++ b/EmbeddedPkg/EmbeddedPkg.dec > @@ -69,9 +69,6 @@ [Guids.common] > # HII form set GUID for ConsolePrefDxe driver > gConsolePrefFormSetGuid = { 0x2d2358b4, 0xe96c, 0x484d, { 0xb2, 0xdd, 0x7c, 0x2e, 0xdf, 0xc7, 0xd5, 0x6f } } > > - ## Include/Guid/NvVarStoreFormatted.h > - gEdkiiNvVarStoreFormattedGuid = { 0xd1a86e3f, 0x0707, 0x4c35, { 0x83, 0xcd, 0xdc, 0x2c, 0x29, 0xc8, 0x91, 0xa3 } } > - > [Protocols.common] > gHardwareInterruptProtocolGuid = { 0x2890B3EA, 0x053D, 0x1643, { 0xAD, 0x0C, 0xD6, 0x48, 0x08, 0xDA, 0x3F, 0xF1 } } > gHardwareInterrupt2ProtocolGuid = { 0x32898322, 0x2da1, 0x474a, { 0xba, 0xaa, 0xf3, 0xf7, 0xcf, 0x56, 0x94, 0x70 } } > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec > index 58e6ab004882..492bff8b7890 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -412,6 +412,9 @@ [Guids] > ## Include/Guid/MigratedFvInfo.h > gEdkiiMigratedFvInfoGuid = { 0xc1ab12f7, 0x74aa, 0x408d, { 0xa2, 0xf4, 0xc6, 0xce, 0xfd, 0x17, 0x98, 0x71 } } > > + ## Include/Guid/NvVarStoreFormatted.h > + gEdkiiNvVarStoreFormattedGuid = { 0xd1a86e3f, 0x0707, 0x4c35, { 0x83, 0xcd, 0xdc, 0x2c, 0x29, 0xc8, 0x91, 0xa3 } } > + > # > # GUID defined in UniversalPayload > # > diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc > index 659482ab737f..4142e1178dcd 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -104,6 +104,7 @@ [LibraryClasses] > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > + NvVarStoreFormattedLib|MdeModulePkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > > [LibraryClasses.EBC.PEIM] > IoLib|MdePkg/Library/PeiIoLibCpuIo/PeiIoLibCpuIo.inf > @@ -443,6 +444,7 @@ [Components] > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > + MdeModulePkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > > [Components.IA32, Components.X64, Components.AARCH64] > MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > diff --git a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf b/MdeModulePkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > similarity index 96% > rename from EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > rename to MdeModulePkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > index e2eed26c5b2d..5e8cd94cc9e0 100644 > --- a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > +++ b/MdeModulePkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > @@ -32,7 +32,6 @@ [Sources] > NvVarStoreFormattedLib.c > > [Packages] > - EmbeddedPkg/EmbeddedPkg.dec > MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > > diff --git a/EmbeddedPkg/Include/Guid/NvVarStoreFormatted.h b/MdeModulePkg/Include/Guid/NvVarStoreFormatted.h > similarity index 100% > rename from EmbeddedPkg/Include/Guid/NvVarStoreFormatted.h > rename to MdeModulePkg/Include/Guid/NvVarStoreFormatted.h > diff --git a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.c b/MdeModulePkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.c > similarity index 100% > rename from EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.c > rename to MdeModulePkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.c > -- > 2.38.0 >