From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.8979.1672828643337381582 for ; Wed, 04 Jan 2023 02:37:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dMfdkEhI; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2594AB81600 for ; Wed, 4 Jan 2023 10:37:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CF5CC433EF for ; Wed, 4 Jan 2023 10:37:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672828639; bh=joMSAsY/mW8CnBLYXsiN/J3eO+LGbpmuj+6C+4i87NE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dMfdkEhIb4wkfo4cdiTmoaXYH088/fL+tzHS0hTcZDIvpUlXIIk3LABMQF+6e4e2F WN8VQiMiG+38NYOlHBAycHrd9FTLFPgRa9cBm78oR6bil7hPHQBzZIF4J9eYf6M9q7 c9iQ8oZFxQiIi/eNTG7SWYoOT3o5cDs5HmsUMn2w52ClTZ9k/BpMcdO+3W0ZfW5tMY 7GzxbIpy6DgBLICbyhUFVybezu6HFwwdXfrf4e6Ls4awOpyO4vGz7rt8noj0iqlSsh Mo6bYLpGjUs/NAO7J3RrPLvt9kqO7stoko//rL8k3F91NbKaK2EoW0xR82Mepw18SB wJ34SX+QypYTg== Received: by mail-lj1-f177.google.com with SMTP id x37so28077070ljq.1 for ; Wed, 04 Jan 2023 02:37:19 -0800 (PST) X-Gm-Message-State: AFqh2krlWRFCgTHMbJkCkRyI1O4B8AZBbQew6LjPk9rxLiPoDcGmMOHz xFRgI99faXYIqDKo3qcqsQgKQ2FOpOkDnnNy6w4= X-Google-Smtp-Source: AMrXdXtU/9MRs/s4hREkSCzrSivb8szuQjDUtSbpTFIBVbfAShXInK6IuD82BxMsJh3PX2g+udXtnYjLy+1vOjwgrhY= X-Received: by 2002:a2e:a804:0:b0:27f:fb12:6c20 with SMTP id l4-20020a2ea804000000b0027ffb126c20mr602579ljq.152.1672828637323; Wed, 04 Jan 2023 02:37:17 -0800 (PST) MIME-Version: 1.0 References: <20221214225252.1660-1-mikuback@linux.microsoft.com> <20221214225252.1660-14-mikuback@linux.microsoft.com> <9c88fe54-5e83-fb43-b845-af4a79eaef79@linux.microsoft.com> <910eccca-b219-86ae-5550-339650b69461@linux.microsoft.com> <843b47a9-d6ee-31dd-fd21-363f3ce8ddc9@linux.microsoft.com> In-Reply-To: <843b47a9-d6ee-31dd-fd21-363f3ce8ddc9@linux.microsoft.com> From: "Ard Biesheuvel" Date: Wed, 4 Jan 2023 11:37:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode To: Michael Kubacki Cc: devel@edk2.groups.io, quic_llindhol@quicinc.com, Sami Mujawar , "Kinney, Michael D" Content-Type: text/plain; charset="UTF-8" On Thu, 15 Dec 2022 at 17:38, Michael Kubacki wrote: > > On 12/15/2022 5:42 AM, Leif Lindholm wrote: > > On Wed, Dec 14, 2022 at 19:04:06 -0500, Michael Kubacki wrote: > >> I'm just trying to understand your position. > >> > >> Are you saying you would rather people check in typos and then later have > >> patches come into the package to fix them? > >> > >> For example, like these: > >> > >> - ArmVirtPkg: https://edk2.groups.io/g/devel/message/97021 > >> - ArmPkg: https://edk2.groups.io/g/devel/message/97022 > >> > >> Why not just have the code checked in without typos in the first place? > > > > A little fairy once whispered in my ear that if I stopped myself and > > tried to rephrase whenever I found myself using the work "just", I > > would meet less friction in context-stripping communication mediums > > such as email. They weren't wrong. > > > > This topic is met with friction regardless of how it is phrased. > > The friction exists because the community chose to enable spell checking > in CI and it is not wanted here. > > The mechanism chosen to ignore words was through YAML files rather than > a button. A common YAML file can store words for the whole project and > packages can add package-specific words. The community was expected to > make the contributions necessary in the common file to minimize impact > on package maintainers. > > The spellcheck log outputs the exact code that needs to be copied/pasted > to the exception list - whether the global list or package list. If you > run CI locally, you can copy/paste the exact lines needed. > > This is a patch series I work on in my spare time to try to improve the > project. I am tired of Ard's dismissive and passive aggressive responses > such as those in https://edk2.groups.io/g/devel/message/97433 so I > revoke the series and will let others decide what they want to do. > I don't think this is a fair characterization of my response. I explained in detail why I think rigid spellcheck rules are counter-productive and do not contribute to the quality of what gets deployed to devices. Nevertheless, I apologize if my frustration with the recent CI changes managed to seep through, although I should also mention that I am a big fan of the pre-merge build and boot tests, as they have been a huge help in my workflow. Only the rigid enforcement of standards that are purely cosmetic is what bothers me, especially because finding the error messages (and suggestions for improvement) in the complex UI is not as straight-forward as it is made out to be. That said, it would be helpful if you could respond to the actual points I made, rather than dismissing them wholesale as a passive-aggressive and hostile response. You have presented your contribution as a take-it-or-leave-it style change, rather than engaging with Leif and me as the package maintainers to converge on something that we can all agree on. You may have also missed my question/invitation regarding collaboration on IBT/BTI enablement in UEFI. Kind regards, Ard.