From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BC79CAC0F6D for ; Thu, 14 Dec 2023 09:55:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zB8o7bkl8JmEMDC/V8J4HAvMJwLDdHTjdHiQYHKugpM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1702547704; v=1; b=BR3nr1SMo+zWsrR7gqkvHt3HyNBuwiY3KRaYhMmTm/2xLQS8SUodhLBqsuruA/qkDOxzN5m4 3eHuitB0YZd/KwEUhjeLMhRXcrifqjdtA9kAgYTe0ANdpMi8mgQPMjLa8SSyxAtnI7gRzlX4mN/ Q6GCzHtso1SdufknY9M5KuVU= X-Received: by 127.0.0.2 with SMTP id 5D5mYY7687511xyqfKYOTizN; Thu, 14 Dec 2023 01:55:04 -0800 X-Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.18606.1702547703546354782 for ; Thu, 14 Dec 2023 01:55:03 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 56E6AB821CB for ; Thu, 14 Dec 2023 09:55:01 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id B19FBC433CB for ; Thu, 14 Dec 2023 09:55:00 +0000 (UTC) X-Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2cc2683fdaaso4196091fa.0 for ; Thu, 14 Dec 2023 01:55:00 -0800 (PST) X-Gm-Message-State: Bs3LHECkvWOrELhy5fMPIPFRx7686176AA= X-Google-Smtp-Source: AGHT+IFv0cKISa1XbHavSqzz7+4Dvyv2NR0N73mjmd5m++oeXZ+pawhWPReDaF3Lxox69CwfhJIMecB5kBe5lVaQUA0= X-Received: by 2002:a2e:a544:0:b0:2c9:f643:d6d7 with SMTP id e4-20020a2ea544000000b002c9f643d6d7mr7231891ljn.8.1702547698892; Thu, 14 Dec 2023 01:54:58 -0800 (PST) MIME-Version: 1.0 References: <20231214075748.9682-1-mjsbeaton@gmail.com> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 14 Dec 2023 10:54:47 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH V5] DebugLib: Update DEBUG macro used when MDEPKG_NDEBUG is defined To: Mike Beaton Cc: devel@edk2.groups.io, Michael Kubacki , lersek@redhat.com, rebecca@bsdio.com, gaoliming@byosoft.com.cn, michael.d.kinney@intel.com, afish@apple.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=BR3nr1SM; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 14 Dec 2023 at 10:37, Mike Beaton wrote: > > > IOW, please don't send a v6 until the discussion comes to a conclusion. > > Apologies, I did _not_ see this before sending. > > > > - #if !defined (MDEPKG_NDEBUG) > > > + #if defined (__CC_ARM) || defined (__GNUC__) > > > > No, this is not going to be acceptable to me. You noted that only the > > ARM code seems to suffer from this issue, so surely, we can find a way > > to change this code that doesn't introduce spurious dependencies on > > the exact toolchain we are using. > > With all due respect, I believe that you are incorrect that this is > spurious. Please check the surrounding code (specifically, this > compiler dependency exactly matches - and is there because of - a > compiler dependency in the surrounding code). (Additionally, though it > doesn't affect the point either way, I thought this is what you had > spotted and were asking for, when previously saying "What about > GCC?"!) > Indeed. I hadn't spotted the context, and actually (patch sent), we need to rip that code out entirely. So please consider this piece solved. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112518): https://edk2.groups.io/g/devel/message/112518 Mute This Topic: https://groups.io/mt/103166459/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-