Re: [PATCH 2/4] MdePkg: Bump implemented UEFI version to v2.10

["Ard Biesheuvel" <ardb@kernel.org>]

On Wed, 1 Feb 2023 at 01:10, Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
>
> Hi Ard,
>
> Have you verified that all the content from UEFI 2.10 has been added and that
> all the behaviors of the edk2 implementations match UEFI 2.10?
>
> What additional work items remain?
>

Ah no, I didn't quite consider that, tbh. I naively assumed that the
availability of any v2.10 material would justify bumping the version,
but as you ask the question, I realize that not everything is
optional. In particular, things like event groups that need to get
signaled at the right time need to be implemented before claiming
version 2.10 compliance.

I glossed over the changelog, and while there don't seem to be many
items that fit that category, going from v2.7 to v2.10 still requires
a lot of those to be double checked and sadly, I don't have the
bandwidth right now for doing that.

So I'll withdraw this patch. But please ack patch #1 if you are happy
for it to go in.

Thanks,
Ard.



> > -----Original Message-----
> > From: Ard Biesheuvel <ardb@kernel.org>
> > Sent: Tuesday, January 31, 2023 2:36 PM
> > To: devel@edk2.groups.io
> > Cc: Ard Biesheuvel <ardb@kernel.org>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Yao, Jiewen <jiewen.yao@intel.com>; Kubacki, Michael <michael.kubacki@microsoft.com>;
> > Sean Brogan <sean.brogan@microsoft.com>; Rebecca Cran <quic_rcran@quicinc.com>; Leif Lindholm
> > <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com>
> > Subject: [PATCH 2/4] MdePkg: Bump implemented UEFI version to v2.10
> >
> > Now that we are adding implementations of protocols added in v2.10,
> > let's bump the version we expose to v2.10 as well.
> >
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> >  MdePkg/Include/Uefi/UefiSpec.h | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h
> > index 3abebbb8d904..9fef5bde4b2d 100644
> > --- a/MdePkg/Include/Uefi/UefiSpec.h
> > +++ b/MdePkg/Include/Uefi/UefiSpec.h
> > @@ -1789,6 +1789,8 @@ EFI_STATUS
> >  // EFI Runtime Services Table
> >
> >  //
> >
> >  #define EFI_SYSTEM_TABLE_SIGNATURE      SIGNATURE_64 ('I','B','I',' ','S','Y','S','T')
> >
> > +#define EFI_2_100_SYSTEM_TABLE_REVISION ((2 << 16) | (100))
> >
> > +#define EFI_2_90_SYSTEM_TABLE_REVISION  ((2 << 16) | (90))
> >
> >  #define EFI_2_80_SYSTEM_TABLE_REVISION  ((2 << 16) | (80))
> >
> >  #define EFI_2_70_SYSTEM_TABLE_REVISION  ((2 << 16) | (70))
> >
> >  #define EFI_2_60_SYSTEM_TABLE_REVISION  ((2 << 16) | (60))
> >
> > @@ -1801,7 +1803,7 @@ EFI_STATUS
> >  #define EFI_2_00_SYSTEM_TABLE_REVISION  ((2 << 16) | (00))
> >
> >  #define EFI_1_10_SYSTEM_TABLE_REVISION  ((1 << 16) | (10))
> >
> >  #define EFI_1_02_SYSTEM_TABLE_REVISION  ((1 << 16) | (02))
> >
> > -#define EFI_SYSTEM_TABLE_REVISION       EFI_2_70_SYSTEM_TABLE_REVISION
> >
> > +#define EFI_SYSTEM_TABLE_REVISION       EFI_2_100_SYSTEM_TABLE_REVISION
> >
> >  #define EFI_SPECIFICATION_VERSION       EFI_SYSTEM_TABLE_REVISION
> >
> >
> >
> >  #define EFI_RUNTIME_SERVICES_SIGNATURE  SIGNATURE_64 ('R','U','N','T','S','E','R','V')
> >
> > --
> > 2.39.0
>