From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.18274.1675238081834959726 for ; Tue, 31 Jan 2023 23:54:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=O8iy5ZOb; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 289CC615FA for ; Wed, 1 Feb 2023 07:54:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E8C9C433A0 for ; Wed, 1 Feb 2023 07:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675238080; bh=rwaSjhqViq4vDFQ3sM5hXhXSqq6qXVQl2JBcYMgtwFQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=O8iy5ZObr+t/y1F73YoQWYsX3ae8K21h+Jgar4CuIp7OpeH7yW+ha76xx3sgiE2MD arLjfsnznw7sR69rN99uUnZMVizSHa11rRBhDmHAMsWHPKG0KQJXj7oKpw5G+M5ZPS xSut8UgDLmefQeaoBotCm4e6Bysfkalv5jRh4WaHqYsrVEjfzDdS7UZxF4vhMju3UZ BqHommoi/v0euGrwo3+x3l6Yjy90DZ7kP9NiqJ5qK0Gwy3wWYJtg8mCwcNskwS4/pd j+v9pM0MhBOVeEiyN48A4abjo9kMGPiIp1/O/fS+xeSflaJ4x6NA3np8CHcqdPMDSC I5uwfKoeyzkrQ== Received: by mail-lf1-f53.google.com with SMTP id bp15so27958668lfb.13 for ; Tue, 31 Jan 2023 23:54:40 -0800 (PST) X-Gm-Message-State: AO0yUKUTeRKKGcQnK0jhNdzagjLMuvK0H0qpfEKKbY3q0jLsVmGfuYOk BVKHMROLNL5FuMDjJ66UrFE3UHnVg3L4PqCKCyc= X-Google-Smtp-Source: AK7set9SXjXhHixUtFeiPr+NpOsbwT6a+469sYg5RHfMoaWaI1GYhwbVmFIAJAy2OCg1KZvPEDz+/fbYggRdp0bqVvc= X-Received: by 2002:ac2:5b9c:0:b0:4d8:767b:8b6b with SMTP id o28-20020ac25b9c000000b004d8767b8b6bmr231616lfn.63.1675238078573; Tue, 31 Jan 2023 23:54:38 -0800 (PST) MIME-Version: 1.0 References: <20230131223550.1775834-1-ardb@kernel.org> <20230131223550.1775834-3-ardb@kernel.org> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 1 Feb 2023 08:54:27 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/4] MdePkg: Bump implemented UEFI version to v2.10 To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "Gao, Liming" , "Yao, Jiewen" , "Kubacki, Michael" , Sean Brogan , Rebecca Cran , Leif Lindholm , Sami Mujawar Content-Type: text/plain; charset="UTF-8" On Wed, 1 Feb 2023 at 01:10, Kinney, Michael D wrote: > > Hi Ard, > > Have you verified that all the content from UEFI 2.10 has been added and that > all the behaviors of the edk2 implementations match UEFI 2.10? > > What additional work items remain? > Ah no, I didn't quite consider that, tbh. I naively assumed that the availability of any v2.10 material would justify bumping the version, but as you ask the question, I realize that not everything is optional. In particular, things like event groups that need to get signaled at the right time need to be implemented before claiming version 2.10 compliance. I glossed over the changelog, and while there don't seem to be many items that fit that category, going from v2.7 to v2.10 still requires a lot of those to be double checked and sadly, I don't have the bandwidth right now for doing that. So I'll withdraw this patch. But please ack patch #1 if you are happy for it to go in. Thanks, Ard. > > -----Original Message----- > > From: Ard Biesheuvel > > Sent: Tuesday, January 31, 2023 2:36 PM > > To: devel@edk2.groups.io > > Cc: Ard Biesheuvel ; Kinney, Michael D ; Gao, Liming > > ; Yao, Jiewen ; Kubacki, Michael ; > > Sean Brogan ; Rebecca Cran ; Leif Lindholm > > ; Sami Mujawar > > Subject: [PATCH 2/4] MdePkg: Bump implemented UEFI version to v2.10 > > > > Now that we are adding implementations of protocols added in v2.10, > > let's bump the version we expose to v2.10 as well. > > > > Signed-off-by: Ard Biesheuvel > > --- > > MdePkg/Include/Uefi/UefiSpec.h | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h > > index 3abebbb8d904..9fef5bde4b2d 100644 > > --- a/MdePkg/Include/Uefi/UefiSpec.h > > +++ b/MdePkg/Include/Uefi/UefiSpec.h > > @@ -1789,6 +1789,8 @@ EFI_STATUS > > // EFI Runtime Services Table > > > > // > > > > #define EFI_SYSTEM_TABLE_SIGNATURE SIGNATURE_64 ('I','B','I',' ','S','Y','S','T') > > > > +#define EFI_2_100_SYSTEM_TABLE_REVISION ((2 << 16) | (100)) > > > > +#define EFI_2_90_SYSTEM_TABLE_REVISION ((2 << 16) | (90)) > > > > #define EFI_2_80_SYSTEM_TABLE_REVISION ((2 << 16) | (80)) > > > > #define EFI_2_70_SYSTEM_TABLE_REVISION ((2 << 16) | (70)) > > > > #define EFI_2_60_SYSTEM_TABLE_REVISION ((2 << 16) | (60)) > > > > @@ -1801,7 +1803,7 @@ EFI_STATUS > > #define EFI_2_00_SYSTEM_TABLE_REVISION ((2 << 16) | (00)) > > > > #define EFI_1_10_SYSTEM_TABLE_REVISION ((1 << 16) | (10)) > > > > #define EFI_1_02_SYSTEM_TABLE_REVISION ((1 << 16) | (02)) > > > > -#define EFI_SYSTEM_TABLE_REVISION EFI_2_70_SYSTEM_TABLE_REVISION > > > > +#define EFI_SYSTEM_TABLE_REVISION EFI_2_100_SYSTEM_TABLE_REVISION > > > > #define EFI_SPECIFICATION_VERSION EFI_SYSTEM_TABLE_REVISION > > > > > > > > #define EFI_RUNTIME_SERVICES_SIGNATURE SIGNATURE_64 ('R','U','N','T','S','E','R','V') > > > > -- > > 2.39.0 >