From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 487ADD80D0C for ; Sun, 1 Sep 2024 08:05:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3g33hwqX2VeJ5WjX8tqwk+wk++g3Ru0uNw2JDcXEntU=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240830; t=1725177941; v=1; x=1725523539; b=RSsaJg9LwwMcHFQ0MzOzMh+qlIO2WsgL515/t3UDVPEJTAQISxXDj3LOveqcqX3f6YIPcbzA Ea7cbkyL0HETQlVNMHP+3TCEQ4JUQhULcqIiVEzj9Q7janhBZK8sxE4KpaAPQuwC23rV8bzS0xS LryURF4BCk89qVJpd3EjvUgguBBJy8vkgEv7qFGr+ZOFO1WVaJHewRP1Hz6uR0OXYF1loh8HJ4S wlGdQzeu/VdPzhZHtButp4RRV/vfeY5BaKhQBJtkgSXweLLLgh8ocHO4W8owjcKYAd+l91FQU5e ylXhut7AeJgTjc9wz4UTD2tfDuTJCc+JE3YOiXBXDBvvA== X-Received: by 127.0.0.2 with SMTP id Sp0iYY7687511xIyPbKGiVcA; Sun, 01 Sep 2024 01:05:39 -0700 X-Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by mx.groups.io with SMTP id smtpd.web10.12461.1725177938848296926 for ; Sun, 01 Sep 2024 01:05:39 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C43D3A40A58 for ; Sun, 1 Sep 2024 08:05:30 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E484C4CECA for ; Sun, 1 Sep 2024 08:05:37 +0000 (UTC) X-Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2f43de7ad5eso41892931fa.1 for ; Sun, 01 Sep 2024 01:05:37 -0700 (PDT) X-Gm-Message-State: nGn8PY5oRCEnlx8LQOofDOVBx7686176AA= X-Google-Smtp-Source: AGHT+IHM9HVYj7eA08gPe9+lTxinh5uyIReqSsiTSj6CKWKqxX98M1sUIipB1I1HRRdeGDli03D44h0jSbvCxTYc8Uw= X-Received: by 2002:a05:6512:1396:b0:52c:dbe7:cfd5 with SMTP id 2adb3069b0e04-53546b40f5emr4117020e87.32.1725177935670; Sun, 01 Sep 2024 01:05:35 -0700 (PDT) MIME-Version: 1.0 References: <20240831223232.59981-1-rebecca@bsdio.com> In-Reply-To: <20240831223232.59981-1-rebecca@bsdio.com> From: "Ard Biesheuvel via groups.io" Date: Sun, 1 Sep 2024 10:05:23 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build To: Rebecca Cran , "Warkentin, Andrei" Cc: devel@edk2.groups.io, quic_llindhol@quicinc.com, michael.d.kinney@intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 01 Sep 2024 01:05:39 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=RSsaJg9L; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io Hi Rebecca, On Sun, 1 Sept 2024 at 00:33, Rebecca Cran wrote: > > Replace the old X86EmulatorDxe with one built from > https://github.com/intel/MultiArchUefiPkg. This is a much more modern, > recent implementation that's more reliable and is actively maintained. > > Add driver binaries for both AArch64 and RISCV64, along with the > LoadOpRom application. > > Signed-off-by: Rebecca Cran > --- > Emulator/X86EmulatorDxe/AArch64/EmulatorDxe.depex | Bin 0 -> 54 bytes > Emulator/X86EmulatorDxe/AArch64/EmulatorDxe.efi | Bin 0 -> 573440 bytes > Emulator/X86EmulatorDxe/AArch64/LoadOpRom.efi | Bin 0 -> 28672 bytes > Emulator/X86EmulatorDxe/README.md | 11 +++++++---- > Emulator/X86EmulatorDxe/RISCV64/EmulatorDxe.depex | Bin 0 -> 54 bytes > Emulator/X86EmulatorDxe/RISCV64/EmulatorDxe.efi | Bin 0 -> 561216 bytes > Emulator/X86EmulatorDxe/RISCV64/LoadOpRom.efi | Bin 0 -> 30848 bytes > Emulator/X86EmulatorDxe/X86EmulatorDxe.depex | Bin 36 -> 0 bytes > Emulator/X86EmulatorDxe/X86EmulatorDxe.efi | Bin 913408 -> 0 bytes > Emulator/X86EmulatorDxe/X86EmulatorDxe.inf | 10 +++++++--- > 10 files changed, 14 insertions(+), 7 deletions(-) > Happy to see that this work has been absorbed into a project that will improve and maintain it going forward. However, according to the github.com repo Readme of MultiArchUefiCpuPkg, these binaries include statically linked UniCorn builds, which are a mix of LPGL and GPLv2, so you will need to update the LICENSE file accordingly. Also, glancing over the code, it seems like it removes the NULL pointer dereference handling that the original X86EmulatorPkg has - this code was added for a purpose, as some Nvidia option ROMs will happily dereference NULL pointers, which happens to work on most older X64 firmware because page 0x0 happens to be mapped. Perhaps Andrei can comment on this point? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120461): https://edk2.groups.io/g/devel/message/120461 Mute This Topic: https://groups.io/mt/108202804/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-