From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web11.502.1626713386486658438
 for <devel@edk2.groups.io>;
 Mon, 19 Jul 2021 09:49:46 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dm7sGg2G;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id BF1496112D
	for <devel@edk2.groups.io>; Mon, 19 Jul 2021 16:49:45 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1626713385;
	bh=/pkVd4ovbn64fD5ulAGo8HI8Xk7HOuTTDnymqyKIp/k=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=dm7sGg2GPMFIzg2E0dy44w5K5rxDsUFq4IV7T0hXLwMjnfu+B1uBoCIX/E6siTr6y
	 fTkJdLGGQP+Iu2yjdUtWAGDmn/yClc0mCjADv1PyF0ST2GufA7O+Bg815/prskHdE2
	 fGCLYQ/0IVLe+2TrCksRJbVEyz/m9aIqqwgnUs8ZqheeHoHHridbsNCQ4gppEabIg5
	 A0B/RI8Smr//d1lE1/ipZ5NGxBjbCEkHskAVMHdkyPWJidcxNpZ5tYADYhgSSm9V/E
	 W8XohUwgfHDEExaYJu5Y8UxYsDaaFXhDwITK+rP510zMOZVFyZuCZACsFT5QVSUhnA
	 QUzlsLNiuHXxQ==
Received: by mail-oi1-f180.google.com with SMTP id s23so5692324oiw.12
        for <devel@edk2.groups.io>; Mon, 19 Jul 2021 09:49:45 -0700 (PDT)
X-Gm-Message-State: AOAM5315MFSl0fknf9G/Zebs6QF3hWzY94r8praKmvlSFnnhDgGIpw4W
	fgU9qDIPLiSdK8HV1eHYkjnhfpxm0ERtEhMC7C4=
X-Google-Smtp-Source: ABdhPJwIbaLana8r/QRIHAdYAXtI9+kSkBcxryJLKx6ZrPu7fqNcFQjw9M/9K35dQZDwRFFgkXr1ZFUluDx3N1oNpzM=
X-Received: by 2002:aca:4c49:: with SMTP id z70mr17799221oia.174.1626713385172;
 Mon, 19 Jul 2021 09:49:45 -0700 (PDT)
MIME-Version: 1.0
References: <20210709032423.17092-1-glin@suse.com> <YPWeTWQ/SRPsDKx3@perard>
In-Reply-To: <YPWeTWQ/SRPsDKx3@perard>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Mon, 19 Jul 2021 18:49:34 +0200
X-Gmail-Original-Message-ID: <CAMj1kXENNWSxkGGciE+qhngRnkOYjxeFZ653nn-JMd00f3NTyw@mail.gmail.com>
Message-ID: <CAMj1kXENNWSxkGGciE+qhngRnkOYjxeFZ653nn-JMd00f3NTyw@mail.gmail.com>
Subject: Re: [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Gary Lin <glin@suse.com>, edk2-devel-groups-io <devel@edk2.groups.io>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Jordan Justen <jordan.l.justen@intel.com>, 
	Julien Grall <julien@xen.org>, Jim Fehlig <jfehlig@suse.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 19 Jul 2021 at 17:46, Anthony PERARD <anthony.perard@citrix.com> wrote:
>
> On Fri, Jul 09, 2021 at 11:24:23AM +0800, Gary Lin wrote:
> > Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download
> > the kernel, initrd, and kernel command line from QEMU's fw_cfg.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Anthony Perard <anthony.perard@citrix.com>
> > Cc: Julien Grall <julien@xen.org>
> > Cc: Jim Fehlig <jfehlig@suse.com>
> > Signed-off-by: Gary Lin <glin@suse.com>
>
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>
>
> And now I understand what the patch "OvmfPkg/OvmfXen: set
> PcdAcpiS3Enable at initialization" is about. "HVM Direct Kernel Boot"
> with OVMF simply doesn't work without that other patch.
>

Thanks. I'll file this one and merge it along with the other S3 patch
once it has been reviewed.