From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4AD4BAC0C5B for ; Thu, 14 Dec 2023 07:40:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=OQMsAz3TJU1ni9OkmMvf07TNWlSWIlJCifjX0zmBtoc=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1702539629; v=1; b=X2pf4SxO7sT+XamM/uXQv7H+kwSlVT8J4w1qCaIRKhhwq7Yh7+y/LwunvZ1e4qAP8P1ELo51 MjfSKIZluIskXP8oJ9Rnb208R7JdZrmaa5G+xpFBe6Iy1OKVSk8iRpmCVjCCW4ZdmyWnKcif8xE pvNurqnw7fbX/PzGlwn4wPEA= X-Received: by 127.0.0.2 with SMTP id 4UTeYY7687511x8Ac8H7PUkW; Wed, 13 Dec 2023 23:40:29 -0800 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.17017.1702539629298440100 for ; Wed, 13 Dec 2023 23:40:29 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D455D620E8 for ; Thu, 14 Dec 2023 07:40:28 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83DCDC433C8 for ; Thu, 14 Dec 2023 07:40:28 +0000 (UTC) X-Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2c9f099cf3aso116216871fa.1 for ; Wed, 13 Dec 2023 23:40:28 -0800 (PST) X-Gm-Message-State: sK45u9BhpgEHr62HogneCTIOx7686176AA= X-Google-Smtp-Source: AGHT+IEwBiXii7rcUA+2z9oHavCrDzBQuFqVbpcEwqs70x/61qocZORDv1QKsc55VhCLW+ccSGRaW7oD10e0Zilaz7E= X-Received: by 2002:a2e:9247:0:b0:2c9:f58e:85da with SMTP id v7-20020a2e9247000000b002c9f58e85damr3955429ljg.93.1702539626726; Wed, 13 Dec 2023 23:40:26 -0800 (PST) MIME-Version: 1.0 References: <20231214072743.6432-1-mjsbeaton@gmail.com> <20231214072743.6432-2-mjsbeaton@gmail.com> In-Reply-To: <20231214072743.6432-2-mjsbeaton@gmail.com> From: "Ard Biesheuvel" Date: Thu, 14 Dec 2023 08:40:15 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined To: devel@edk2.groups.io, mjsbeaton@gmail.com Cc: ardb@google.com, lersek@redhat.com, mcb30@ipxe.org, mikhailkrichanov@gmail.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=X2pf4SxO; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 14 Dec 2023 at 08:28, Mike Beaton wrote: > > From: Mike Beaton > > This is no longer required since the revised DEBUG macro automatically > compiles away unused var accesses when MDEPKG_NDEBUG is defined; > keeping these lines is incompatible with the updated DEBUG macro, as > there has to be a variable, access to which to discard. > > Signed-off-by: Mike Beaton I take it this will trigger a build warning if it is not merged at the same time as the other change? How about GCC? > --- > .../DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c | 4 ---- > .../AArch64/DefaultExceptionHandler.c | 3 --- > 2 files changed, 7 deletions(-) > > diff --git a/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c b/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c > index 432112354f..dc49e8eba7 100644 > --- a/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c > +++ b/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c > @@ -71,9 +71,7 @@ PeCoffLoaderRelocateImageExtraAction ( > IN OUT PE_COFF_LOADER_IMAGE_CONTEXT *ImageContext > ) > { > - #if !defined (MDEPKG_NDEBUG) > CHAR8 Temp[512]; > - #endif > > if (ImageContext->PdbPointer) { > #ifdef __CC_ARM > @@ -106,9 +104,7 @@ PeCoffLoaderUnloadImageExtraAction ( > IN OUT PE_COFF_LOADER_IMAGE_CONTEXT *ImageContext > ) > { > - #if !defined (MDEPKG_NDEBUG) > CHAR8 Temp[512]; > - #endif > > if (ImageContext->PdbPointer) { > #ifdef __CC_ARM > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c > index a39896d576..1d3ea61311 100644 > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c > +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c > @@ -157,7 +157,6 @@ DescribeExceptionSyndrome ( > DEBUG ((DEBUG_ERROR, "\n %a \n", Message)); > } > > -#ifndef MDEPKG_NDEBUG > STATIC > CONST CHAR8 * > BaseName ( > @@ -177,8 +176,6 @@ BaseName ( > return Str; > } > > -#endif > - > /** > This is the default action to take on an unexpected exception > > -- > 2.39.2 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112504): https://edk2.groups.io/g/devel/message/112504 Mute This Topic: https://groups.io/mt/103166254/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-