From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by mx.groups.io with SMTP id smtpd.web08.9843.1639395033589469537
 for <devel@edk2.groups.io>;
 Mon, 13 Dec 2021 03:30:33 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vGLRb+Fg;
 spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by ams.source.kernel.org (Postfix) with ESMTPS id 36606B80D78
	for <devel@edk2.groups.io>; Mon, 13 Dec 2021 11:30:31 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7634C34605
	for <devel@edk2.groups.io>; Mon, 13 Dec 2021 11:30:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639395029;
	bh=6ceKh4wUHEGlscjTgB6P581wSl8VrLZP6zrgT8cMJwI=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=vGLRb+FghaGAZIKvTz3dHAXeCW1nrFTkdgNEWon2aBKK3o4A2P8OWTH75TxO44owk
	 THNkQ1mK7hzCb7e9i0XQasFLpf3nV3CIovuXGuY5nY9vpIlECr30PP1WFUPV/H6YYa
	 tAmG+17F9mRaOLv0rVNgFBD24gVtKM8sAIC+eF716Ovp4o9ZM/+g/popv9yD/DfXQz
	 7b6gIpHHUjafZ51AwNRTda3KqjBAnhytbQKGP5aJz1CKoeFJKoi+BVZm3Ra40V8z63
	 liwA0ri5BY6QNUaOlqN5Z1fa0jcMd6nlEJukzMDnqtgIaEnwmAKhftgHBP0RjWFwgA
	 pn03xL/Ft2H1g==
Received: by mail-ot1-f48.google.com with SMTP id v15-20020a9d604f000000b0056cdb373b82so17081573otj.7
        for <devel@edk2.groups.io>; Mon, 13 Dec 2021 03:30:29 -0800 (PST)
X-Gm-Message-State: AOAM530+asoeWim9v5x3CDfEL+EXiTjqB50YIoB4+uEuRgA1WcB565Oc
	jizlOro/zDKZRgTOMlDwCKGVQhVA9ntuYiY5DKs=
X-Google-Smtp-Source: ABdhPJyT7+u/O0IzH2d8+y6E5vhXjR2wTS1aiVe7/Hnx5rPzXiZBC90dd6iy6iW5tlFCWyjy5zUuitEf/4osZ8fOqcQ=
X-Received: by 2002:a9d:6c54:: with SMTP id g20mr24879399otq.30.1639395029136;
 Mon, 13 Dec 2021 03:30:29 -0800 (PST)
MIME-Version: 1.0
References: <20211213081658.3535809-1-kraxel@redhat.com> <20211213081658.3535809-3-kraxel@redhat.com>
 <CAMj1kXHfCowoUZwEpRhb2Fb9cQ=bQNA8JBtCtEFKhAkz_ZGLNg@mail.gmail.com> <20211213112646.kfhq4b44m2ugcupg@sirius.home.kraxel.org>
In-Reply-To: <20211213112646.kfhq4b44m2ugcupg@sirius.home.kraxel.org>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Mon, 13 Dec 2021 12:30:18 +0100
X-Gmail-Original-Message-ID: <CAMj1kXEOWnUv1cL_eFYRTWu+BRYF7=q2dBbnmfq7zy4zLA3h4g@mail.gmail.com>
Message-ID: <CAMj1kXEOWnUv1cL_eFYRTWu+BRYF7=q2dBbnmfq7zy4zLA3h4g@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v3 2/5] OvmfPkg/Microvm/fdt: load fdt from fw_cfg
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Jordan Justen <jordan.l.justen@intel.com>, 
	Jiewen Yao <jiewen.yao@intel.com>, Pawel Polawski <ppolawsk@redhat.com>, 
	=?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= <philmd@redhat.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Mon, 13 Dec 2021 at 12:26, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
>   Hi,
>
> > > @@ -368,6 +412,7 @@ MiscInitialization (
> > >        break;
> > >      case 0xffff: /* microvm */
> > >        DEBUG ((DEBUG_INFO, "%a: microvm\n", __FUNCTION__));
> > > +      MicrovmInitialization ();
> >
> > Is this the best spot for calling Microvm related init code that is
> > entirely unrelated to PCIe?
>
> Looked like the best place to me.  Various platform-specific
> initialization happens there.  And, yes, for 'pc' and 'q35'
> qemu machines this includes pci host bridge setup.
>

Fair enough. Given the comment that future changes will include DT
based PCIe host bridge probing, I think this is fine.