From: "Ard Biesheuvel" <ardb@kernel.org>
To: Yuan Yu <yuanyu@google.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>,
Julien Grall <julien@xen.org>
Subject: Re: [PATCH v1 1/1] OvmfPkg/PlatformDxe: Check RouteConfig arguments for spec compliance
Date: Mon, 5 Sep 2022 15:55:01 +0200 [thread overview]
Message-ID: <CAMj1kXEOZt+PgCLp=LB0B=LDuRH2=-XaSqjScyLumasrO_muZw@mail.gmail.com> (raw)
In-Reply-To: <20220824023123.3060905-2-yuanyu@google.com>
On Wed, 24 Aug 2022 at 04:31, Yuan Yu <yuanyu@google.com> wrote:
>
> Per UEFI Spec 2.9, EFI_HII_CONFIG_ROUTING_PROTOCOL.RouteConfig()
> should return EFI_INVALID_PARAMETERS if caller passes in a NULL for
> the Configuration parameter (see 35.4 EFI HII Configuration Routing
> Protocol).
>
> Add a check to return EFI_INVALID_PARAMETERS when Configuration is NULL.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
>
> Signed-off-by: Yuan Yu <yuanyu@google.com>
> ---
> OvmfPkg/PlatformDxe/Platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platform.c
> index a6d459f3dfd7..83dcd2216c6d 100644
> --- a/OvmfPkg/PlatformDxe/Platform.c
> +++ b/OvmfPkg/PlatformDxe/Platform.c
> @@ -344,7 +344,7 @@ RouteConfig (
> Configuration
> ));
>
> - if (Progress == NULL) {
> + if (Progress == NULL || Configuration == NULL) {
> return EFI_INVALID_PARAMETER;
> }
>
> --
> 2.37.2.672.g94769d06f0-goog
>
Merged as #3287
prev parent reply other threads:[~2022-09-05 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 2:31 [PATCH v1 0/1] Check arguments to be compliant with spec Yuan Yu
2022-08-24 2:31 ` [PATCH v1 1/1] OvmfPkg/PlatformDxe: Check RouteConfig arguments for spec compliance Yuan Yu
2022-09-05 13:55 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXEOZt+PgCLp=LB0B=LDuRH2=-XaSqjScyLumasrO_muZw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox