From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.4946.1665737012094012952 for ; Fri, 14 Oct 2022 01:43:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EjPRBnLM; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7D3E0B82244 for ; Fri, 14 Oct 2022 08:43:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32EE2C433D6 for ; Fri, 14 Oct 2022 08:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665737008; bh=ZPZ3fp9mXxqWQRPEdIQoIdy+Mp2AYs2uNrciG6eBKBg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=EjPRBnLMmFrjIZjIos4c6uq4OMyKsBTgQ4Zz+Xqh9cs5Iu87eK1FpMNt/la1A3Fbm FuT2a3CqZjLFaWsKMhDchOER7GZj/1hX19KEI8pss3LcUENteCm2XXCBaYS4q7MLxc Lhdp+h9t2Hn5UbWSpTWmyuPva3brIHfh1Xo0nDoPJPvJ+sA9mfjdVaOxtwmi/M4bVo 9pDL/41klJEDZX4pfJp9swwM4U6nkuhWteYdvs63TT/JBElBLyIlr3f5TzoVgJIxnK ky1LEuZ+oJH6EbUMyK4hSHBXKLHLdF36PNPdQfPhrC06Fk7iHqiuuVqh6+P5t6CU3X QvToXSUPwhphQ== Received: by mail-lj1-f176.google.com with SMTP id a25so5251084ljk.0 for ; Fri, 14 Oct 2022 01:43:28 -0700 (PDT) X-Gm-Message-State: ACrzQf3hmDGe/E3jL6VDdbR6RpatvKg3OFM5YQ8Q41Wzaf0Yvx8BX0jU f/vxB+Zmz8crtcUeb7s1GlR5iGAJhBYiUwjHs08= X-Google-Smtp-Source: AMsMyM6Ufas2jTZZOYXSsOmvfyNWZ4g0y6IQ4SmIzkdUbcsXMi/fCO3D3EAFJFZH1cHHGYzxGcPQSdsgnoGWT49jCxk= X-Received: by 2002:a2e:2d0a:0:b0:26c:a1c:cdf with SMTP id t10-20020a2e2d0a000000b0026c0a1c0cdfmr1536953ljt.352.1665737006213; Fri, 14 Oct 2022 01:43:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 14 Oct 2022 10:43:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Pkg-Module: Remove Non-ASCII Characters To: SteveX Li Cc: devel@edk2.groups.io, Leif Lindholm , Abner Chang , Daniel Schaefer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 14 Oct 2022 at 04:14, SteveX Li wrote: > > It would cause compiler error. > Which compiler and which error? > Signed-off-by: SteveX Li > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > --- > EmbeddedPkg/GdbStub/GdbStubInternal.h | 32 ++++++++++++------------ > EmbeddedPkg/Include/Protocol/UsbDevice.h | 2 +- > 2 files changed, 17 insertions(+), 17 deletions(-) > > diff --git a/EmbeddedPkg/GdbStub/GdbStubInternal.h b/EmbeddedPkg/GdbStub/= GdbStubInternal.h > index 9c3929c812..5eaff61d83 100644 > --- a/EmbeddedPkg/GdbStub/GdbStubInternal.h > +++ b/EmbeddedPkg/GdbStub/GdbStubInternal.h > @@ -322,7 +322,7 @@ SendNotSupported ( > VOID > ); > > -/** =E2=80=98p n=E2=80=99 > +/** 'p n' > Reads the n-th register's value into an output buffer and sends it as a= packet > @param SystemContext Register content at time of the exceptio= n > @param InBuffer This is the input buffer received from g= db server > @@ -333,7 +333,7 @@ ReadNthRegister ( > IN CHAR8 *InBuffer > ); > > -/** =E2=80=98g=E2=80=99 > +/** 'g' > Reads the general registers into an output buffer and sends it as a pa= cket > @param SystemContext Register content at time of the exce= ption > **/ > @@ -343,7 +343,7 @@ ReadGeneralRegisters ( > IN EFI_SYSTEM_CONTEXT SystemContext > ); > > -/** =E2=80=98P n...=3Dr...=E2=80=99 > +/** 'P n...=3Dr...' > Writes the new value of n-th register received into the input buffer to= the n-th register > @param SystemContext Register content at time of the exceptio= n > @param InBuffer This is the input buffer received from g= db server > @@ -355,7 +355,7 @@ WriteNthRegister ( > IN CHAR8 *InBuffer > ); > > -/** =E2=80=98G XX...=E2=80=99 > +/** 'G XX...' > Writes the new values received into the input buffer to the general reg= isters > @param SystemContext Register content at time of the = exception > @param InBuffer Pointer to the input buffer rece= ived from gdb server > @@ -368,7 +368,7 @@ WriteGeneralRegisters ( > IN CHAR8 *InBuffer > ); > > -/** =E2=80=98m addr,length =E2=80=99 > +/** 'm addr,length ' > Find the Length of the area to read and the start address. Finally, pas= s them to > another function, TransferFromMemToOutBufAndSend, that will read from t= hat memory space and > send it as a packet. > @@ -381,7 +381,7 @@ ReadFromMemory ( > IN CHAR8 *PacketData > ); > > -/** =E2=80=98M addr,length :XX...=E2=80=99 > +/** 'M addr,length :XX...' > Find the Length of the area in bytes to write and the start address. Fi= nally, pass them to > another function, TransferFromInBufToMem, that will write to that memor= y space the info in > the input buffer. > @@ -394,7 +394,7 @@ WriteToMemory ( > IN CHAR8 *PacketData > ); > > -/** =E2=80=98c [addr ]=E2=80=99 > +/** 'c [addr ]' > Continue. addr is Address to resume. If addr is omitted, resume at curr= ent > Address. > > @@ -409,7 +409,7 @@ ContinueAtAddress ( > IN CHAR8 *PacketData > ); > > -/** =E2=80=98s [addr ]=E2=80=99 > +/** 's [addr ]' > Single step. addr is the Address at which to resume. If addr is omitted= , resume > at same Address. > > @@ -444,10 +444,10 @@ RemoveSingleStep ( > ); > > /** > - =E2=80=98Z1, [addr], [length]=E2=80=99 > - =E2=80=98Z2, [addr], [length]=E2=80=99 > - =E2=80=98Z3, [addr], [length]=E2=80=99 > - =E2=80=98Z4, [addr], [length]=E2=80=99 > + 'Z1, [addr], [length]' > + 'Z2, [addr], [length]' > + 'Z3, [addr], [length]' > + 'Z4, [addr], [length]' > > Insert hardware breakpoint/watchpoint at address addr of size length > > @@ -463,10 +463,10 @@ InsertBreakPoint ( > ); > > /** > - =E2=80=98z1, [addr], [length]=E2=80=99 > - =E2=80=98z2, [addr], [length]=E2=80=99 > - =E2=80=98z3, [addr], [length]=E2=80=99 > - =E2=80=98z4, [addr], [length]=E2=80=99 > + 'z1, [addr], [length]' > + 'z2, [addr], [length]' > + 'z3, [addr], [length]' > + 'z4, [addr], [length]' > > Remove hardware breakpoint/watchpoint at address addr of size length > > diff --git a/EmbeddedPkg/Include/Protocol/UsbDevice.h b/EmbeddedPkg/Inclu= de/Protocol/UsbDevice.h > index b299ee10a7..b07f459afa 100644 > --- a/EmbeddedPkg/Include/Protocol/UsbDevice.h > +++ b/EmbeddedPkg/Include/Protocol/UsbDevice.h > @@ -83,7 +83,7 @@ EFI_STATUS > first interface descriptor. If there are > additional interfaces, their interface > descriptor and endpoint descriptors foll= ow the > - first interface=E2=80=99s endpoint descr= iptors". > + first interface's endpoint descriptors". > > The size of each buffer is the TotalLeng= th > member of the Configuration Descriptor. > -- > 2.31.1.windows.1 >