From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.8702.1675424942138533543 for ; Fri, 03 Feb 2023 03:49:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ijU82JZ+; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4B4CFB82A72 for ; Fri, 3 Feb 2023 11:49:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70969C433A1 for ; Fri, 3 Feb 2023 11:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675424938; bh=ku98jyBcSqlH8wafYbm4YxC1Ra6FHQT9CyOWtoYu+UY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ijU82JZ+dmPmU94g2FTr6ZuaJLOrEnOM/Ji3fKgqQy2lwR46vzkRlAOA9uiREOAHR nE/TY4jknlLP6EBJXHbmJdl3JvFNnUOSMyYufm8xneIo7YICumq4OBmfb1CJOhhpZx soDrGDhwpJKwIxNGjzdW7KsRvpGVoah7KrCNhPWSVdq5PJmZCz4qf8xguBMqAk5WKc 0oU0rQ7NgjlGg1/2/lZmviEFf2t4I67r7uahyqQv+dikUXOFJuN+rzbbXv9IjX87H8 6S6nIoYC61/XDDg3qAwJgJxrL/SSFvPfCKkTLNH+SmI77W0NrgK2lzqvkZh5RKLnOU o9b2KucrPi4qw== Received: by mail-lf1-f50.google.com with SMTP id x40so7373843lfu.12 for ; Fri, 03 Feb 2023 03:48:58 -0800 (PST) X-Gm-Message-State: AO0yUKW6carXbxRYVf+l7QxkzTR8Ju2Xtt17HwgGsc0Q1qg8id2w9IUz SXythQinYv3qTjVuqnQHImr8pQRu1ZB0GJsze9Q= X-Google-Smtp-Source: AK7set/SHAkwda4LKU32/QsAmTKslED2YBE0qaEOmPoz1ZUlx8lceaNilNTCwydd7N5/QHck0vhNfQ/E7y0c9T2tW9Q= X-Received: by 2002:a19:500b:0:b0:4cc:789a:dac8 with SMTP id e11-20020a19500b000000b004cc789adac8mr1821832lfb.198.1675424936494; Fri, 03 Feb 2023 03:48:56 -0800 (PST) MIME-Version: 1.0 References: <20230203110843.2349736-1-ardb@kernel.org> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 3 Feb 2023 12:48:45 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize To: Sunil V L , Sean Brogan , Michael Kinney , "Liming Gao (Byosoft address)" , Michael Kubacki Cc: devel@edk2.groups.io, Leif Lindholm , Abner Chang , Daniel Schaefer Content-Type: text/plain; charset="UTF-8" I pushed this here https://github.com/tianocore/edk2/pull/3994 but I am getting weird errors from the CI An error occurred while provisioning resources (Error Type: Failure). Build_VS2019 TARGET_FMP_FAT_TEST The remote provider was unable to process the request. Build_VS2019 TARGET_FMP_FAT_TEST without any explanation on how I am expected to mitigate this. Sean, Michael: can we fix this please? On Fri, 3 Feb 2023 at 12:16, Sunil V L wrote: > > Thanks a lot!, Ard. > > Reviewed-by: Sunil V L > > > On Fri, Feb 03, 2023 at 12:08:43PM +0100, Ard Biesheuvel wrote: > > The code never references the PCD so the INF should not reference it > > either. The last reference was moved to PrePiHobLib in commit > > 05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in > > commit 97106391955337155e7. > > > > Cc: Leif Lindholm > > Cc: Abner Chang > > Cc: Daniel Schaefer > > Reported-by: Sunil V L > > Signed-off-by: Ard Biesheuvel > > --- > > EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > > index 3c749ca22943..090bfe888f52 100644 > > --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > > +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > > @@ -58,8 +58,6 @@ [Protocols] > > > > > > [FixedPcd.common] > > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > - > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType > > -- > > 2.39.1 > >