public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize
@ 2023-02-03 11:08 Ard Biesheuvel
  2023-02-03 11:16 ` Sunil V L
  0 siblings, 1 reply; 10+ messages in thread
From: Ard Biesheuvel @ 2023-02-03 11:08 UTC (permalink / raw)
  To: devel; +Cc: sunilvl, Ard Biesheuvel, Leif Lindholm, Abner Chang,
	Daniel Schaefer

The code never references the PCD so the INF should not reference it
either. The last reference was moved to PrePiHobLib in commit
05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in
commit 97106391955337155e7.

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Daniel Schaefer <git@danielschaefer.me>
Reported-by: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 --
 1 file changed, 2 deletions(-)

diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
index 3c749ca22943..090bfe888f52 100644
--- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
+++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
@@ -58,8 +58,6 @@ [Protocols]
 
 
 [FixedPcd.common]
-  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
-
   gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory
   gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS
   gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2023-02-06 22:42 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-03 11:08 [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize Ard Biesheuvel
2023-02-03 11:16 ` Sunil V L
2023-02-03 11:48   ` Ard Biesheuvel
2023-02-04  1:26     ` [edk2-devel] " Michael Kubacki
2023-02-06 22:04       ` Ard Biesheuvel
2023-02-06 22:40         ` Michael Kubacki
2023-02-06 22:41           ` Ard Biesheuvel
2023-02-04  1:27     ` EDKII -CI weird issue Yao, Jiewen
2023-02-04  1:39       ` Michael D Kinney
2023-02-04 11:32         ` Yao, Jiewen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox