Re: [edk2-devel] [PATCH 6/7] OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files

["Ard Biesheuvel" <ardb@kernel.org>]

On Tue, 31 Oct 2023 at 13:30, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 10/30/23 15:36, Ard Biesheuvel wrote:
> > On Fri, 27 Oct 2023 at 07:43, duntan <dun.tan@intel.com> wrote:
> >>
> >> Use BaseIoLibIntrinsic.inf in dsc files. The
> >> BaseIoLibIntrinsic supports Tdx and sev now.
> >> The BaseIoLibIntrinsicSev will be removed in
> >> the following patches.
> >>
> >> Signed-off-by: Dun Tan <dun.tan@intel.com>
> >> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> >> Cc: Jiewen Yao <jiewen.yao@intel.com>
> >> Cc: Jordan Justen <jordan.l.justen@intel.com>
> >> Cc: Gerd Hoffmann <kraxel@redhat.com>
> >> Cc: Ray Ni <ray.ni@intel.com>
> >
> > Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
>
> While I agree that this patch *in itself* is (quite obviously) formally
> correct, semantically it is wrong for OVMF; which is why I have NACKed
> the whole series; see <https://edk2.groups.io/g/devel/message/110242>.
>
> (Just highlighting it here too, lest it get lost in the review thread.)
>

Apologies, I missed that.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110410): https://edk2.groups.io/g/devel/message/110410
Mute This Topic: https://groups.io/mt/102215668/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-