From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 912E4AC10FF for ; Tue, 31 Oct 2023 13:19:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qdEwjeeP3du2vOhERJfl0Dw6m/9f+g6GXclfC95eMN8=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1698758365; v=1; b=ftvE87f6McnwmQXFFPbdjkV+HqTafcJGLMyzc7G7KTAmU1pbk6s0Ck/cfGyQ/M6te9p3xEAR mdHq576GJ9kvkJN9eE0hDb68exfqtBkxTG+0xcJ/x/21RtwxOjaqplVcCOG5wzL7nOF7Y7acIRw fSxpQ+D1ec+wUb8g9C02A7MI= X-Received: by 127.0.0.2 with SMTP id 6b1KYY7687511x4IVsezwYut; Tue, 31 Oct 2023 06:19:25 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.186094.1698758364627996446 for ; Tue, 31 Oct 2023 06:19:24 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D864B60F02 for ; Tue, 31 Oct 2023 13:19:23 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85CAEC433C8 for ; Tue, 31 Oct 2023 13:19:23 +0000 (UTC) X-Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-508126afb9bso7799759e87.0 for ; Tue, 31 Oct 2023 06:19:23 -0700 (PDT) X-Gm-Message-State: u76PzLBH7iBR3cOy65fZZfsrx7686176AA= X-Google-Smtp-Source: AGHT+IFlzVJaJtGE5Li7yYl5r27ej6bMdN0CwS66qDvuYje+1RY1Tmvi2fdrv1B5DK/z4yxb90xv6NmLQLC7AUh5MTw= X-Received: by 2002:ac2:4c82:0:b0:507:9a33:f105 with SMTP id d2-20020ac24c82000000b005079a33f105mr8275395lfl.69.1698758361717; Tue, 31 Oct 2023 06:19:21 -0700 (PDT) MIME-Version: 1.0 References: <20231027054300.1382-1-dun.tan@intel.com> <20231027054300.1382-7-dun.tan@intel.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 31 Oct 2023 14:19:10 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 6/7] OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files To: Laszlo Ersek Cc: devel@edk2.groups.io, dun.tan@intel.com, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Ray Ni Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ftvE87f6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 31 Oct 2023 at 13:30, Laszlo Ersek wrote: > > On 10/30/23 15:36, Ard Biesheuvel wrote: > > On Fri, 27 Oct 2023 at 07:43, duntan wrote: > >> > >> Use BaseIoLibIntrinsic.inf in dsc files. The > >> BaseIoLibIntrinsic supports Tdx and sev now. > >> The BaseIoLibIntrinsicSev will be removed in > >> the following patches. > >> > >> Signed-off-by: Dun Tan > >> Cc: Ard Biesheuvel > >> Cc: Jiewen Yao > >> Cc: Jordan Justen > >> Cc: Gerd Hoffmann > >> Cc: Ray Ni > > > > Reviewed-by: Ard Biesheuvel > > While I agree that this patch *in itself* is (quite obviously) formally > correct, semantically it is wrong for OVMF; which is why I have NACKed > the whole series; see . > > (Just highlighting it here too, lest it get lost in the review thread.) > Apologies, I missed that. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110410): https://edk2.groups.io/g/devel/message/110410 Mute This Topic: https://groups.io/mt/102215668/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-