public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Rebecca Cran <rebecca@bsdio.com>,
	devel@edk2.groups.io,  Pawel Polawski <ppolawsk@redhat.com>,
	Oliver Steffen <osteffen@redhat.com>,
	 Jordan Justen <jordan.l.justen@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	 Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformBootManagerLib: use utf8 for the serial console.
Date: Thu, 23 Mar 2023 10:18:49 +0100	[thread overview]
Message-ID: <CAMj1kXER_dNW2vVnU7s00WELSsSOtiuXo7H666CqB5JaxjMFqA@mail.gmail.com> (raw)
In-Reply-To: <q7tuqp2rc2vp45lrgspzrw3iukxjmb2uwkfkf7du5o3o4l2pqb@aud7bqafkze4>

On Thu, 23 Mar 2023 at 09:20, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Wed, Mar 22, 2023 at 10:31:32AM -0600, Rebecca Cran wrote:
> > On 3/22/23 10:20 AM, Ard Biesheuvel wrote:
> > > On Fri, 17 Mar 2023 at 13:19, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > > > Time to leave behind relics from the last century and arrive in the
> > > > modern world.  Drop PC-ANSI Terminal Type for the serial console, use
> > > > UTF-8 instead.
> > > >
> > > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > > No objections here but how will I be able to observe the difference?
> >
> > I'm not sure if it's as simple as this or if it depends on the terminal,
> > TERM setting etc.,
>
> It does.  It depends on the locale the terminal application is
> running in.  These days that is a utf-8 locale in 99% of the cases,
> i.e. "de_DE.UTF-8" for me.
>
> > but I saw a difference when I opened the UiApp and opened
> > the drop-down "Select Language".
> >
> > Before the patch, it showed "Fran?ais", and after, "Français".
>
> Yes, essentially everything which is not ascii shows correct now,
> including the line-drawing characters which you can see in alot
> of places in UiApp on the serial console.
>


Merged as #4164 - thanks

      reply	other threads:[~2023-03-23  9:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17 12:19 [PATCH 1/1] OvmfPkg/PlatformBootManagerLib: use utf8 for the serial console Gerd Hoffmann
2023-03-22 16:20 ` [edk2-devel] " Ard Biesheuvel
2023-03-22 16:31   ` Rebecca Cran
2023-03-23  8:20     ` Gerd Hoffmann
2023-03-23  9:18       ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXER_dNW2vVnU7s00WELSsSOtiuXo7H666CqB5JaxjMFqA@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox