Re: [edk2-devel] [PATCH v5 00/11] DynamicTablesPkg: Enable _PSD/_CPC generation using SCMI

["Ard Biesheuvel" <ardb@kernel.org>]

Hi Pierre,

On Thu, 25 Jan 2024 at 16:19, PierreGondois <pierre.gondois@arm.com> wrote:
>
> v1:
> - https://edk2.groups.io/g/devel/message/104115
> v2:
> - https://edk2.groups.io/g/devel/message/104115
> - Rebase patches on latest version.
> v3:
> - https://edk2.groups.io/g/devel/message/111567
> [PATCH 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION
> - Note the referenced spec spec is SCMI v3.2
> [PATCH 02/11] ArmPkg/ArmScmiDxe: Add PERFORMANCE_DESCRIBE_FASTCHANNEL support
> - Note the referenced spec spec is SCMI v3.2
> - Move SCMI_MESSAGE_ID_PERFORMANCE enum definition out of #pragma pack(1)
> [PATCH 03/11] MdePkg/Acpi65: Add _PSD/_CPC/State Coordination Types macros
> - Macros used to be added to ACPI 6.4 definition file, move them to the
>   latest ACPI 6.5 definition file
> [PATCH 10/11] DynamicTablesPkg: Add DynamicTablesScmiInfoLib
> - Renamed ArmScmiInfoLib to DynamicTablesScmiInfoLib
> [PATCH 11/11] DynamicTablesPkg: Remove check for _CPC field
> - Add warning when missing one of the bypassed field
> All patches:
> - Rebase on latest master
> - Use ACPI 6.5 definitions instead of 6.4 previously
> v4:
> - https://edk2.groups.io/g/devel/message/112378
> - Extracted and submitted patch:
>   - MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions
>   separately at: [1]
> v5:
> [PATCH v4 05/10] DynamicTablesPkg: Add CM_ARM_PSD_INFO object
> - Updated format from "0x%llx" -> "0x%x"
> [PATCH v4 07/10] DynamicTablesPkg: Add AmlCreatePsdNode() to generate _PSD
> - Corrected error handling
> [PATCH v4 09/10] DynamicTablesPkg: Add DynamicTablesScmiInfoLib
> - Moved DynamicTablesScmiInfoLib library to AARCH64 section
> [PATCH v4 10/10] DynamicTablesPkg: Remove check for _CPC field
> - Added a patch 'DynamicTablesPkg: Add PcdDevelopmentPlatformRelaxations Pcd'
>   and make use of the new Pcd
>
> The SCMI performance protocol allows to query the Operating Performance
> Points (OPPs) available for each performance domain. Each OPP has a
> specific frequency/power consumption/performance.
>
> On Device Tree (DT) based platforms, the SCMI protocol is directly
> available from the OS.
> On ACPI based platforms, the _PSD objects allows to identify CPUs
> belonging
> to the same performance domain. CPUs belonging to the same performance
> domain have the same frequency. The _CPC object allows to
> describe/control the performance level/frequency of a CPU (i.e. its
> frequency).
>
> This patchset:
> - Add support for 'DescribeFastchannel' SCMI performance protocol
> - Add a object to the DynamicTablesPkg to describe the PSD information
> - Allows to generate _PSD objects in the SsdtCpuTopologyGenerator
> - Add a ArmScmiInfoLib library populating DynamicTablesPkg CPC objects,
>   relying on the SCMI protocol to fetch the relevant information
>
> A patchset for Juno-r2 platforms will be submitted to demonstrate
> this functionality.
>
> [1] https://edk2.groups.io/g/devel/message/111901
>
> Pierre Gondois (11):
>   ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION
>   ArmPkg/ArmScmiDxe: Add PERFORMANCE_DESCRIBE_FASTCHANNEL support

For these,

Acked-by: Ard Biesheuvel <ardb@kernel.org>

Feel free to merge along with the rest of the series.

Thanks,


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114429): https://edk2.groups.io/g/devel/message/114429
Mute This Topic: https://groups.io/mt/103955491/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-