From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A92629415CE for ; Wed, 6 Sep 2023 09:53:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YnHKJHp5iEw6G3pU7A4QFuO/uqUHxFLPtJ7fz422yLw=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1693994028; v=1; b=T/0M5EkYqocOaMMcbebYmy5XuTHWIQ+UW77J/z5MJlgrxALKKcXrKoU8viVLVM35FnJSI1qV YebqnkPpvgDNIQe1AofYmncG0f4lhExEAM3k4iKnNXHQpX6hDIMAz379jmkKU/iSoXF7aq60c1a JpisBs8FD2LE5rU+5D7O2dL0= X-Received: by 127.0.0.2 with SMTP id cgIGYY7687511xo4WDNp7Uop; Wed, 06 Sep 2023 02:53:48 -0700 X-Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.4903.1693994027488367155 for ; Wed, 06 Sep 2023 02:53:48 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 79910B8185B for ; Wed, 6 Sep 2023 09:53:45 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D4B3C433C8 for ; Wed, 6 Sep 2023 09:53:44 +0000 (UTC) X-Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2bc63e0d8cdso53019191fa.2 for ; Wed, 06 Sep 2023 02:53:44 -0700 (PDT) X-Gm-Message-State: 1KifcArvVsnTgpNTqMfBRuxix7686176AA= X-Google-Smtp-Source: AGHT+IHBhdjZOe5QUyhDY09fHTwg3YOo46cyvkXmMtGlh5TzJBG1KJ2JPanCLqWRnU2n1lUTJi/loN/U5uqfoLyIGhs= X-Received: by 2002:a2e:900b:0:b0:2bc:b0be:e76 with SMTP id h11-20020a2e900b000000b002bcb0be0e76mr1839050ljg.37.1693994022112; Wed, 06 Sep 2023 02:53:42 -0700 (PDT) MIME-Version: 1.0 References: <20230906093715.1589-1-mjsbeaton@gmail.com> In-Reply-To: <20230906093715.1589-1-mjsbeaton@gmail.com> From: "Ard Biesheuvel" Date: Wed, 6 Sep 2023 11:53:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v3] Revert "OvmfPkg: Update build.sh to allow building OVMF then running QEMU" To: devel@edk2.groups.io, mjsbeaton@gmail.com Cc: Rebecca Cran , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="T/0M5EkY"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 6 Sept 2023 at 11:38, Mike Beaton wrote: > > This reverts commit 173a7a7daaad560cd69e1000faca1d2b91774c46 > > Fixes https://bugzilla.tianocore.org/show_bug.cgi?id=4528 > > The build.sh qemu option starts the correct qemu executable for the selected > architecture (build.sh -a option, or implicit) and uses the correct previously > built OVMF image for the selected architecture and build target (build.sh -b > option, or implicit). > > With this revert, the above step will fail if there is no matching previously > built OVMF image. This is advantageous over rebuilding each time the build.sh > qemu option is used (as in the reverted commit), because it provides a quick > way to run a just-built OVMF image in place, while: > a) Starting immediately (saving the time required for a rebuild on each > usage, if the VM is started multiple times) > b) Preserving the NVRAM contents between multiple runs (i.e. until the > image is next rebuilt) > > Signed-off-by: Mike Beaton Merged as #4791 Thanks for the patch, and for your patience. > --- > OvmfPkg/build.sh | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh > index b0334fb76e..279f0d099a 100755 > --- a/OvmfPkg/build.sh > +++ b/OvmfPkg/build.sh > @@ -246,11 +246,11 @@ else > fi > > # > -# Build the edk2 OvmfPkg > +# Run previously built OVMF image for current build options, in place. > +# Do not rebuild first, rather allow multiple runs of a previously built > +# image to start quickly (without rebuild), and with preserved NVRAM contents > +# between runs (until the next rebuild). > # > -echo Running edk2 build for OvmfPkg$Processor > -build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER -DDEBUG_ON_SERIAL_PORT=TRUE > - > if [[ "$RUN_QEMU" == "yes" ]]; then > if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then > mkdir $QEMU_FIRMWARE_DIR > @@ -265,3 +265,10 @@ if [[ "$RUN_QEMU" == "yes" ]]; then > $QEMU_COMMAND "$@" > exit $? > fi > + > +# > +# Build the edk2 OvmfPkg > +# > +echo Running edk2 build for OvmfPkg$Processor > +build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER > +exit $? > -- > 2.40.1.windows.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108321): https://edk2.groups.io/g/devel/message/108321 Mute This Topic: https://groups.io/mt/101189234/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-