From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web11.8.1626456678426444022 for ; Fri, 16 Jul 2021 10:31:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Cj0CHrOf; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id B883A613FB for ; Fri, 16 Jul 2021 17:31:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626456677; bh=1HCVTuevM/hMcZNA/J3goxHBFvRDE88RlVfZNKUChiU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Cj0CHrOfP0tqa1aF16Vge/6bB0ttTjPegPmL0Oo9f8EQayQPtK4rpmCpQfddx5OwG 6E+ZMqlRCGbpUUAATWbYzia2NkUk4mv/Q6K8MHOz/IqRRePMLJq8n2h4Xe1+M98HVz 9jMIMHicm7/kk7SrZhQaXxKrDsatXVbg10mDTlE/HeX7u2kFkpTdidusCU4FjCeitZ o8ADAfOn3fgLtSrIPr+qNgP8fwGNDAVgNItDzP3BZytpxccU2A1KlN9Cs01lJxhEt0 iCfVgHLACIhMyz34sUy3QQqank29iXU7ewD5QYH5fRSMHib/uJByNL4XGBMVzYvfpN Oz+OTHEtSCeCA== Received: by mail-oi1-f175.google.com with SMTP id t143so11718190oie.8 for ; Fri, 16 Jul 2021 10:31:17 -0700 (PDT) X-Gm-Message-State: AOAM531BQ0sDdEkwRcoog6vBaXQcbc+0cOdqbGAQ1mWvjBA409xE9Y7f XpcUVW4nVFMw3FVUhKDEjxnb+m5DgP+RVQc/QHo= X-Google-Smtp-Source: ABdhPJwyfX/4S2fLW2suQwgbWQlVYSRfMrDzWHsUolLd9/MmMkSiRGNwguP3X70Y4EuNpFV3uLELdQWyZdSnqoTRvVg= X-Received: by 2002:aca:d64d:: with SMTP id n74mr13218658oig.47.1626456677120; Fri, 16 Jul 2021 10:31:17 -0700 (PDT) MIME-Version: 1.0 References: <20210714132103.1341207-1-gjb@semihalf.com> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 16 Jul 2021 19:31:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platforms PATCH v3 0/2] Add BootDiscoveryPolicyUiLib To: Samer El-Haj-Mahmoud Cc: Grzegorz Bernacki , "devel@edk2.groups.io" , "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , Sunny Wang , "mw@semihalf.com" , "upstream@semihalf.com" , "pete@akeo.ie" , "jian.j.wang@intel.com" , "hao.a.wu@intel.com" , "dandan.bi@intel.com" , "eric.dong@intel.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 16 Jul 2021 at 13:50, Samer El-Haj-Mahmoud wrote: > > Series Reviewed-By: Samer El-Haj-Mahmoud > Does this series depend on core EDK2 changes, and if so, have they been merged already? > > -----Original Message----- > > From: Grzegorz Bernacki > > Sent: Wednesday, July 14, 2021 9:21 AM > > To: devel@edk2.groups.io > > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud > > ; Sunny Wang ; > > mw@semihalf.com; upstream@semihalf.com; pete@akeo.ie; > > jian.j.wang@intel.com; hao.a.wu@intel.com; dandan.bi@intel.com; > > eric.dong@intel.com; Grzegorz Bernacki > > Subject: [edk2-platforms PATCH v3 0/2] Add BootDiscoveryPolicyUiLib > > > > This patchset extends Boot Maintenance Menu and allows to select > > Boot Discovery Policy. Raspberry Pi platforms uses the variable to > > connect specified class of devices on boot. This patchset also > > removes efdc159e which has similar functionality. > > > > Discussion on design can be found at: > > https://edk2.groups.io/g/rfc/topic/rfc_boot_discovery_policy/82450628 > > > > Changes since v1: > > - make 'Connect All' (0x2) default value for PcdBootDiscoveryPolicy > > - initialize BootDiscoveryPolicy variable in platform code, if not foun= d > > > > Changes since v2: > > - add missing local variable initialization > > > > Grzegorz Bernacki (3): > > edk2: > > MdeModulePkg: Add BootDiscoveryPolicyUiLib. > > edk2-platform: > > Platform/RaspberryPi: Enable Boot Discovery Policy. > > Revert "Platform/RaspberryPi: Setup option for disabling Fast Boot" > > > > Platform/RaspberryPi/RaspberryPi.dec = | 2 - > > Platform/RaspberryPi/RPi3/RPi3.dsc = | 9 +- > > Platform/RaspberryPi/RPi4/RPi4.dsc = | 12 +-- > > Platform/RaspberryPi/RPi4/RPi4.fdf = | 1 + > > Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf = | 3 +- > > > > Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootManager > > Lib.inf | 6 +- > > Platform/RaspberryPi/Include/ConfigVars.h = | 12 +-- > > Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr = | 16 +-- > > Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c = | 11 +-- > > Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c = | > > 102 +++++++++++++++++--- > > Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni = | 10 +- > > MdeModulePkg/MdeModulePkg.dec = | 6 + > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib= .inf > > | 52 +++++++ > > MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h = | 22 > > +++ > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib= .c > > | 160 ++++++++++++++++++++ > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.= uni > > | 18 +++ > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibS= tri > > ngs.uni | 29 ++++ > > > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibV= fr. > > Vfr | 44 ++++++ > > 18 files changed, 438 insertions(+), 77 deletions(-) > > create mode 100644 > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.= inf > > create mode 100644 MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h > > create mode 100644 > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.= c > > create mode 100644 > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.= uni > > create mode 100644 > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibS= tri > > ngs.uni > > create mode 100644 > > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibV= fr. > > Vfr > > -- > > 2.25.1 > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you.