[edk2-devel][PATCH v1 1/1] MdeModulePkg: Remove ArmPkg Dependency

[edk2-devel][PATCH v1 1/1] MdeModulePkg: Remove ArmPkg Dependency

[Oliver Smith-Denny]

With commita21a994f55e53325d3e060c435ca3a87fd7c2c79
MdeModulePkg no longer has a hard dependency on ArmMmuLib and therefore
ArmLib. This is the final dependency on ArmPkg, so remove the
unused libs and drop the allowed dependency on ArmPkg as
MdeModulePkg should not depend on it as this is a circular
dependency.

Github PR: https://github.com/tianocore/edk2/pull/5361

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
---
 MdeModulePkg/MdeModulePkg.dsc     | 2 --
 MdeModulePkg/MdeModulePkg.ci.yaml | 3 +--
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
index 6b3052ff4614..c0f1df3bfbca 100644
--- a/MdeModulePkg/MdeModulePkg.dsc
+++ b/MdeModulePkg/MdeModulePkg.dsc
@@ -179,8 +179,6 @@ [LibraryClasses.common.MM_STANDALONE]
   MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
 
 [LibraryClasses.ARM, LibraryClasses.AARCH64]
-  ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
-  ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
   LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
 
   #
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml
index 669f54e33c0d..a3de60a12c9e 100644
--- a/MdeModulePkg/MdeModulePkg.ci.yaml
+++ b/MdeModulePkg/MdeModulePkg.ci.yaml
@@ -53,8 +53,7 @@
         "AcceptableDependencies": [
             "MdePkg/MdePkg.dec",
             "MdeModulePkg/MdeModulePkg.dec",
-            "StandaloneMmPkg/StandaloneMmPkg.dec",
-            "ArmPkg/ArmPkg.dec"  # this should be fixed by promoting an abstraction
+            "StandaloneMmPkg/StandaloneMmPkg.dec"
         ],
         # For host based unit tests
         "AcceptableDependencies-HOST_APPLICATION":[
-- 
2.40.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115287): https://edk2.groups.io/g/devel/message/115287
Mute This Topic: https://groups.io/mt/104250836/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: Remove ArmPkg Dependency

[Sean]

[-- Attachment #1: Type: text/plain, Size: 2563 bytes --]

I would suggest updating the commit to reference this bugzilla from 2021

3651 – Remove DxeIpl dependency on ArmPkg (tianocore.org) 
<https://bugzilla.tianocore.org/show_bug.cgi?id=3651>


Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>


On 2/8/2024 4:27 PM, Oliver Smith-Denny wrote:
> With commita21a994f55e53325d3e060c435ca3a87fd7c2c79 MdeModulePkg no  > longer has a hard dependency on ArmMmuLib and therefore ArmLib. This 
 > is the final dependency on ArmPkg, so remove the unused libs and drop 
 > the allowed dependency on ArmPkg as MdeModulePkg should not depend on 
 > it as this is a circular dependency. > > Github PR: 
https://github.com/tianocore/edk2/pull/5361 > > Cc: Leif Lindholm 
<quic_llindhol@quicinc.com> Cc: Ard Biesheuvel > 
<ardb+tianocore@kernel.org> Cc: Sami Mujawar <sami.mujawar@arm.com> > 
Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Signed-off-by: Oliver 
Smith-Denny <osde@linux.microsoft.com> --- > 
MdeModulePkg/MdeModulePkg.dsc | 2 -- > MdeModulePkg/MdeModulePkg.ci.yaml 
| 3 +-- 2 files changed, 1 > insertion(+), 4 deletions(-) > > diff --git 
a/MdeModulePkg/MdeModulePkg.dsc > b/MdeModulePkg/MdeModulePkg.dsc index 
6b3052ff4614..c0f1df3bfbca > 100644 --- a/MdeModulePkg/MdeModulePkg.dsc 
+++ > b/MdeModulePkg/MdeModulePkg.dsc @@ -179,8 +179,6 @@ > 
[LibraryClasses.common.MM_STANDALONE] > 
MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf 
 > > [LibraryClasses.ARM, LibraryClasses.AARCH64] - > 
ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf - > 
ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > 
LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf > > # 
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml > 
b/MdeModulePkg/MdeModulePkg.ci.yaml index 669f54e33c0d..a3de60a12c9e > 
100644 --- a/MdeModulePkg/MdeModulePkg.ci.yaml +++ > 
b/MdeModulePkg/MdeModulePkg.ci.yaml @@ -53,8 +53,7 @@ > 
"AcceptableDependencies": [ "MdePkg/MdePkg.dec", > 
"MdeModulePkg/MdeModulePkg.dec", - > 
"StandaloneMmPkg/StandaloneMmPkg.dec", - > "ArmPkg/ArmPkg.dec" # this 
should be fixed by promoting an > abstraction + 
"StandaloneMmPkg/StandaloneMmPkg.dec" ], # > For host based unit tests > 
"AcceptableDependencies-HOST_APPLICATION":[e


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115288): https://edk2.groups.io/g/devel/message/115288
Mute This Topic: https://groups.io/mt/104250836/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 4024 bytes --]

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: Remove ArmPkg Dependency

[Ard Biesheuvel]

On Fri, 9 Feb 2024 at 00:27, Oliver Smith-Denny
<osde@linux.microsoft.com> wrote:
>
> With commita21a994f55e53325d3e060c435ca3a87fd7c2c79
> MdeModulePkg no longer has a hard dependency on ArmMmuLib and therefore
> ArmLib. This is the final dependency on ArmPkg, so remove the
> unused libs and drop the allowed dependency on ArmPkg as
> MdeModulePkg should not depend on it as this is a circular
> dependency.
>
> Github PR: https://github.com/tianocore/edk2/pull/5361
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>
> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  MdeModulePkg/MdeModulePkg.dsc     | 2 --
>  MdeModulePkg/MdeModulePkg.ci.yaml | 3 +--
>  2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
> index 6b3052ff4614..c0f1df3bfbca 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -179,8 +179,6 @@ [LibraryClasses.common.MM_STANDALONE]
>    MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
>
>  [LibraryClasses.ARM, LibraryClasses.AARCH64]
> -  ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
> -  ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
>    LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
>
>    #
> diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml
> index 669f54e33c0d..a3de60a12c9e 100644
> --- a/MdeModulePkg/MdeModulePkg.ci.yaml
> +++ b/MdeModulePkg/MdeModulePkg.ci.yaml
> @@ -53,8 +53,7 @@
>          "AcceptableDependencies": [
>              "MdePkg/MdePkg.dec",
>              "MdeModulePkg/MdeModulePkg.dec",
> -            "StandaloneMmPkg/StandaloneMmPkg.dec",
> -            "ArmPkg/ArmPkg.dec"  # this should be fixed by promoting an abstraction
> +            "StandaloneMmPkg/StandaloneMmPkg.dec"
>          ],
>          # For host based unit tests
>          "AcceptableDependencies-HOST_APPLICATION":[
> --
> 2.40.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115301): https://edk2.groups.io/g/devel/message/115301
Mute This Topic: https://groups.io/mt/104250836/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-