From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 340B07803E6 for ; Fri, 9 Feb 2024 11:37:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2dS9pRxdUpIIBwEaLoOTq/B9kYbgFUZevhww5bpl6Ew=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1707478640; v=1; b=DKyvQLYFatSRlCC7TXuIE+4fDlJWErb2Sln43oPgLWtatCxkEsIgDmnDAkannexhoiTDzYS8 NRQV/67aE1A2pEe1wcYF5h9s91xc3QElbNzxiJhl6PATQ3h9aiFWBnm6Uvf7fLUzl/7ooI5rt5q ojAENe7XVX5YQh20XCj81OUo= X-Received: by 127.0.0.2 with SMTP id gBzXYY7687511xNgZyFdRnQq; Fri, 09 Feb 2024 03:37:20 -0800 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web10.9452.1707478639427204055 for ; Fri, 09 Feb 2024 03:37:19 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 75AE3CE1FEF for ; Fri, 9 Feb 2024 11:37:16 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3F00C43399 for ; Fri, 9 Feb 2024 11:37:15 +0000 (UTC) X-Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2d0d799b55cso12423401fa.0 for ; Fri, 09 Feb 2024 03:37:15 -0800 (PST) X-Gm-Message-State: IGk8hVBC9tMUwAygEgP5fSVox7686176AA= X-Google-Smtp-Source: AGHT+IEetUmuQBpC0srkAsWNmYOy8YaR0T88BGEpo0WubPr9TJepJuFRkekRIyvUYO0iujOwHaXveE9Js22aBKN9OCM= X-Received: by 2002:a05:651c:556:b0:2d0:a22b:db6f with SMTP id q22-20020a05651c055600b002d0a22bdb6fmr1254343ljp.33.1707478633886; Fri, 09 Feb 2024 03:37:13 -0800 (PST) MIME-Version: 1.0 References: <20240209002717.21966-1-osde@linux.microsoft.com> In-Reply-To: <20240209002717.21966-1-osde@linux.microsoft.com> From: "Ard Biesheuvel" Date: Fri, 9 Feb 2024 11:37:02 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: Remove ArmPkg Dependency To: Oliver Smith-Denny Cc: devel@edk2.groups.io, Leif Lindholm , Sami Mujawar , Liming Gao Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=DKyvQLYF; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, 9 Feb 2024 at 00:27, Oliver Smith-Denny wrote: > > With commita21a994f55e53325d3e060c435ca3a87fd7c2c79 > MdeModulePkg no longer has a hard dependency on ArmMmuLib and therefore > ArmLib. This is the final dependency on ArmPkg, so remove the > unused libs and drop the allowed dependency on ArmPkg as > MdeModulePkg should not depend on it as this is a circular > dependency. > > Github PR: https://github.com/tianocore/edk2/pull/5361 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Liming Gao > > Signed-off-by: Oliver Smith-Denny Acked-by: Ard Biesheuvel > --- > MdeModulePkg/MdeModulePkg.dsc | 2 -- > MdeModulePkg/MdeModulePkg.ci.yaml | 3 +-- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc > index 6b3052ff4614..c0f1df3bfbca 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -179,8 +179,6 @@ [LibraryClasses.common.MM_STANDALONE] > MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf > > [LibraryClasses.ARM, LibraryClasses.AARCH64] > - ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > - ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf > > # > diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml > index 669f54e33c0d..a3de60a12c9e 100644 > --- a/MdeModulePkg/MdeModulePkg.ci.yaml > +++ b/MdeModulePkg/MdeModulePkg.ci.yaml > @@ -53,8 +53,7 @@ > "AcceptableDependencies": [ > "MdePkg/MdePkg.dec", > "MdeModulePkg/MdeModulePkg.dec", > - "StandaloneMmPkg/StandaloneMmPkg.dec", > - "ArmPkg/ArmPkg.dec" # this should be fixed by promoting an abstraction > + "StandaloneMmPkg/StandaloneMmPkg.dec" > ], > # For host based unit tests > "AcceptableDependencies-HOST_APPLICATION":[ > -- > 2.40.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115301): https://edk2.groups.io/g/devel/message/115301 Mute This Topic: https://groups.io/mt/104250836/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-